godotengine/godot-interactive-changelog
1
0
Fork 0
mirror of https://github.com/godotengine/godot-interactive-changelog.git synced 2025-12-31 01:49:28 +03:00
Code Issues Packages Projects Releases Wiki Activity

Avoid unnecessary computations when switching views

Browse Source
This commit is contained in:
Yuri Sizov
2023-03-24 11:54:46 +01:00
parent b93c3a8237
commit 4ce5fa9d38
2 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/paths/index/components/changes/ChangesList.js
View File

@@ -266,8 +266,11 @@ export default class ChangesList extends LitElement {
}
update(changedProperties) {
this._updateActiveLog();
this._updateLists();
// Only recalculate when class properties change; skip for manual updates.
if (changedProperties.size > 0) {
this._updateActiveLog();
this._updateLists();
}
super.update(changedProperties);
}

11
src/paths/index/components/changes/ReleaseNotesItem.js
View File

@@ -130,6 +130,8 @@ export default class ReleaseNotesItem extends LitElement {
return "GDScript";
case "gui":
return "GUI";
case "visualscript":
return "VisualScript";
case "xr":
return "XR";
}
@@ -137,7 +139,7 @@ export default class ReleaseNotesItem extends LitElement {
return name.charAt(0).toUpperCase() + name.substring(1);
}
update(changedProperties) {
_updateNotes() {
this._sorted_notes = [];
const generalTopics = [
@@ -233,6 +235,13 @@ export default class ReleaseNotesItem extends LitElement {
});
});
});
}
update(changedProperties) {
// Only recalculate when class properties change; skip for manual updates.
if (changedProperties.size > 0) {
this._updateNotes();
}
super.update(changedProperties);
}