From 4ce5fa9d3859ce811a1aa07ea8eee4cc879e622a Mon Sep 17 00:00:00 2001 From: Yuri Sizov Date: Fri, 24 Mar 2023 11:54:46 +0100 Subject: [PATCH] Avoid unnecessary computations when switching views --- src/paths/index/components/changes/ChangesList.js | 7 +++++-- .../index/components/changes/ReleaseNotesItem.js | 11 ++++++++++- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/src/paths/index/components/changes/ChangesList.js b/src/paths/index/components/changes/ChangesList.js index bd1dcc7..ad6ac89 100644 --- a/src/paths/index/components/changes/ChangesList.js +++ b/src/paths/index/components/changes/ChangesList.js @@ -266,8 +266,11 @@ export default class ChangesList extends LitElement { } update(changedProperties) { - this._updateActiveLog(); - this._updateLists(); + // Only recalculate when class properties change; skip for manual updates. + if (changedProperties.size > 0) { + this._updateActiveLog(); + this._updateLists(); + } super.update(changedProperties); } diff --git a/src/paths/index/components/changes/ReleaseNotesItem.js b/src/paths/index/components/changes/ReleaseNotesItem.js index 85e4673..3375046 100644 --- a/src/paths/index/components/changes/ReleaseNotesItem.js +++ b/src/paths/index/components/changes/ReleaseNotesItem.js @@ -130,6 +130,8 @@ export default class ReleaseNotesItem extends LitElement { return "GDScript"; case "gui": return "GUI"; + case "visualscript": + return "VisualScript"; case "xr": return "XR"; } @@ -137,7 +139,7 @@ export default class ReleaseNotesItem extends LitElement { return name.charAt(0).toUpperCase() + name.substring(1); } - update(changedProperties) { + _updateNotes() { this._sorted_notes = []; const generalTopics = [ @@ -233,6 +235,13 @@ export default class ReleaseNotesItem extends LitElement { }); }); }); + } + + update(changedProperties) { + // Only recalculate when class properties change; skip for manual updates. + if (changedProperties.size > 0) { + this._updateNotes(); + } super.update(changedProperties); }