godotengine/godot-angle-static
1
0
Fork 0
mirror of https://github.com/godotengine/godot-angle-static.git synced 2026-01-06 02:09:55 +03:00
Code Issues Packages Projects Releases Wiki Activity
13,464 Commits 3 Branches 8 Tags
eba501c8a46d02ded35f1c07fa34a9c974ba9d02
Commit Graph

13464 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jamie Madill
eba501c8a4 Samples: Move frame counter to common location. 
Bug: angleproject:5040
Change-Id: I64f762b4eb5734f0768054a330a36e20ff9ba93e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408713
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
 2020-09-14 20:42:54 +00:00
Charlie Lao
e4e2a016a7 Vulkan: Use color mask to handle draw buffer disabled case 
When draw buffers set to GL_NONE, instead of remove the attachment from
renderpass which breaks renderpass, we force vulkan's per buffer color
mask to false while keep the disabled draw buffer attached. This CL also
always create FrameBuffer with all color attachments regardless it is
enabled or not.

Bug: b/167301719
Change-Id: Ice9fca9aacf774a47d13b749f822b222cc050174
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2389007
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
 2020-09-14 20:42:25 +00:00
Shahbaz Youssefi
821aabb385 Add Context::renderbufferStorageMultisampleEXT 
glRenderbufferStorageMultisampleEXT is special in that it doesn't have
the same semantics as glRenderbufferStorageMultisample, but is aliased
in gl.xml for the sake of desktop GL (where it does have the same
semantics).  This change special-cases this function so
multisampled-render-to-texture renderbuffers can be supported.

Bug: angleproject:4881
Change-Id: Iaa321dd0671dd82ea802df22a1ae935942789c21
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405395
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2020-09-14 17:46:54 +00:00
Le Hoang Quyen
63c91a3bb9 Metal: autogen for PBO related shaders. 
Bug: angleproject:2634
Change-Id: I36e5a6a4cb11d82f666c410b33fdb39ad35a5e80
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2336557
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
 2020-09-14 16:19:14 +00:00
Jamie Madill
e82f282289 Correctly forward 'data' for capture_replay sample. 
This will allow the isolation scripts to correctly package the trace
data GZ file.

Bug: angleproject:5040
Change-Id: I9e0229701eb10ea5e46b79304c8da47a42ba552d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408718
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
 2020-09-14 16:14:54 +00:00
Jamie Madill
7402b3f65f Capture/Replay: Disable swap limit in sample. 
This allows us to use the sample for benchmarking.

Bug: angleproject:5040
Change-Id: I9177d04b270a0588dc5f261918eb27b0bc734256
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408716
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
 2020-09-14 16:01:14 +00:00
Jamie Madill
ba7f8913da Samples: Enable Debug callback. 
This moves the debug callback code into a common location. For ease of
access it's in shader_utils since that file has access to the GL API.

Bug: angleproject:5040
Change-Id: Iab9de47c2d520a5618ea6825852f8afa63565c8a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408715
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
 2020-09-14 15:31:13 +00:00
Amy Liu
b3c7d39a29 Align the sample position in blitResolveStencil compute shader 
The input coordinates of blitResolveStencil compute shader start
from 0,we need to align the sample position to start from 0 if x/y
is flipped.

Test: dEQP-GLES3.functional.fbo.invalidate.*.unbind_blit_msaa_*
Bug: b/159995959
Change-Id: If0c9f5b7cacddbe1a2d7062469a757a63bcc1378
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2392162
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
 2020-09-14 14:55:13 +00:00
angle-autoroll
437a811b1a Roll SwiftShader from 41974f57973e to dc552fcef1fe (1 revision) 
https://swiftshader.googlesource.com/SwiftShader.git/+log/41974f57973e..dc552fcef1fe

2020-09-11 capn@google.com Drop the float literal suffix

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I30a1c103cea3d1b53a3af8d03ab611c545bbf0e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409384
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-14 14:17:53 +00:00
angle-autoroll
b369116300 Roll Vulkan-Loader from 45f2f18a69eb to 399f7fd741f7 (1 revision) 
45f2f18a69..399f7fd741

2020-09-11 pdaniell@nvidia.com loader Fix issues with physical device sorting

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I6e7d4257242966479d0b36beecc8432f8086bc4d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409383
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-14 11:55:41 +00:00
angle-autoroll
3c229209cd Roll Vulkan-ValidationLayers from 3114c91b037b to e59713d4edda (3 revisions) 
3114c91b03..e59713d4ed

2020-09-12 mark@lunarg.com corechecks: Remove memory shadow copies
2020-09-11 jzulauf@lunarg.com syncval: Add missing WAW suppression
2020-09-11 tony@lunarg.com gpu: Pass-through driver-returned PipelineFeedback data

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I80145595ddb4f398a7621598aad0155c743f7bce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409381
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-14 11:20:42 +00:00
angle-autoroll
8bb4bb4ea1 Roll SPIRV-Tools from 2de7d3af0c0e to 726af6f78f80 (6 revisions) 
2de7d3af0c..726af6f78f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I26842b1895871dd0922bd8be0a1f9c81d2cac537
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409382
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-14 10:59:11 +00:00
angle-autoroll
1deccdf230 Roll glslang from 6a6e311d81dd to f8a5602c5560 (3 revisions) 
6a6e311d81..f8a5602c55

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I2a2331f1be2bd6f712de60d9699bcd9fa7e037b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409380
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-14 10:54:31 +00:00
angle-autoroll
75d257686e Roll Chromium from fe51fcb522cc to 1960f3b23408 (467 revisions) 
fe51fcb522..1960f3b234

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: 41b95e3b54..dc90e7d103
* testing: 64f2e1cf55..598b9bd5a4
* third_party/libjpeg_turbo: 9d4f8005bc..8ca19625de
* tools/clang: 97d6ab3da3..bf815f1a74
No update to Clang.

Bug: None
Tbr: ianelliott@google.com
Change-Id: I3f240027d8bf02aac6a9bef69bf6aea49751beef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409194
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-14 08:01:03 +00:00
Jamie Madill
183a454b9d Test Runner: Use standard isolate script args. 
This will allow the Android test runner to work seamlessly with
the ANGLE GTest runner script.

Bug: angleproject:3162
Change-Id: Id20d2fd05eb01e90a5a884891d9a1aa609ca744d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407837
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
 2020-09-12 18:34:01 +00:00
Mohan Maiya
ed518d1585 EGL: Refcount external AHB when backing an image 
When an image is backed by an external source like an AHB
we need to refcount the buffer appropriately to prevent
deletion of the buffer while in use.

Bug: angleproject:5018
Tests: angle_end2end_tests --gtest_filter=ImageTest.SourceAHBTarget2DEarlyDelete*
Change-Id: Ib6318fc3dc442460d1a2bdd6d75a4458895667bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2406615
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
 2020-09-12 17:21:05 +00:00
Jamie Madill
2879eb5512 TestRunner: Fix missing "=" on swarming args. 
These were missing from debe468309.
Also fixes a misnamed "perf" parameter.

Bug: angleproject:3162
Change-Id: Iad4c4d8d35cc8a08d0e30d50dd9bbf159a4a7ab9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407833
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
 2020-09-12 13:35:35 +00:00
Mohan Maiya
6830eb6041 EGL: Fix a bug in ImageTest 
During cleanup, we were incorrectly calling
glDeleteRenderbuffers on a texture object.
Also update comments to correctly reflect intent.

Bug: angleproject:5018
Change-Id: I28eaf6a23056f3b09eebb7331620e6a27cb14302
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2406614
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
 2020-09-11 22:47:55 +00:00
angle-autoroll
68af795d03 Roll VK-GL-CTS from a48ed7c29144 to b045bf7d3b6a (9 revisions) 
a48ed7c291..b045bf7d3b

2020-09-11 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master
2020-09-11 ari.suonpaa@siru.fi Add coverage for uniform texel buffer SNORM formats
2020-09-11 gleese@broadcom.com Test OpVectorShuffle with index -1
2020-09-11 alexander.galazin@arm.com Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master
2020-09-11 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/master
2020-09-10 lionel.g.landwerlin@intel.com Test imported signaled sync fd for VkSemaphore
2020-09-10 slawomir.cygan@intel.com Make pipeline destruction exception aware in subgroups tests
2020-09-10 venni.ihanakangas@siru.fi Check support for sampleRateShading
2020-09-07 alexander.galazin@arm.com Update Vulkan headers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC ianelliott@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com,angle-bots+autoroll-info@google.com
Change-Id: I00ec89b97722894e6ee357451d5b71f4a70fd446
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405394
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-11 22:20:54 +00:00
Jamie Madill
bca88739ad Add a perf test that cycles through many VBOs. 
Stresses the RenderPass buffer tracking in the Vulkan back-end.

Bug: angleproject:4950
Change-Id: I33d38d8703d0e333d0092195d34228d90f1af52a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358522
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
 2020-09-11 18:37:47 +00:00
Shahbaz Youssefi
7870cf3f0a Vulkan: Fix RAW hazard with storage images 
Semantic revert of 78304b470 and 7bce5194d.  7bce5194d assumed that a
read transition between same layouts is a noop, but that's not true if
said layout is GENERAL.

This is only possible if an image is simultaneously bound as storage and
sampled image.  This bug was discovered by the new syncval VVL warning.

Bug: b/156661359
Change-Id: I05f94160ca1b05b715701564e27fccee31a8aa45
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404742
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
 2020-09-11 17:07:18 +00:00
Geoff Lang
2999ad4ed5 Flush less frequently in QueryGL. 
StandardQueryGL flushes with every pause/resume/end operation to make
sure the list of pending queries does not grow too large. This ended
up trying to flush the queries as soon as they were ended and unlikely
to have results ready.

Add a threshold of pending queries before flushing, hopefully delaying
the flush calls until the queries are ready.

This is a speculative fix for a GPU hang in query flushing.

Bug: chromium:1078754
Change-Id: I38300995ee6576dee8c8c26fa9ccad26e269337a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2401178
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
 2020-09-11 15:46:07 +00:00
Courtney Goeltzenleuchter
ef315fdcdf Vulkan: Use current commandBuffer pointer 
We were using a passed in commandBuffer in
ImageHelper::flushStagedUpdates which became invalid during the process
of handling the flush upon which subsequent uses could cause problems
when threading is enabled (and maybe when it's not as well, just harder
to see.)
Have ImageHelper::flushStagedUpdates use the current
OutsideRenderPassCommandBuffer and the code will use the proper one.

Bug: b/168144059
Change-Id: Ib9849efe9366cf61df5e68fd25d17df165dbd3a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2402354
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
 2020-09-11 15:44:37 +00:00
Courtney Goeltzenleuchter
19b4dfc6cf Enable precision qualifiers. 
This enables precision qualifiers to be included in the translated GLSL
and the generated SPIR-V.
We do not enable precision qualifiers on Pixel 2 with Android Q due to
bugs in the Vulkan driver. Issues appear to be fixed with later Android
releases and later devices.

Bug: angleproject:3078
Change-Id: Ia5f40befc7ec80fbb63fb6bbe88600301967f9c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2350583
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
 2020-09-11 15:26:07 +00:00
angle-autoroll
a1ecebbc83 Roll Vulkan-ValidationLayers from fcb7ecbe49c5 to 3114c91b037b (3 revisions) 
fcb7ecbe49..3114c91b03

2020-09-10 lionel.g.landwerlin@intel.com layers: CodeGen VkPerformanceConfigurationINTEL validation
2020-09-10 s.fricke@samsung.com scripts: Add SPIRV-Tool option to stats
2020-09-10 locke@lunarg.com layers: Remove VUID-vkCmdDraw-None-02698

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ida1733b8a6562b7affed4de5d41f71d92e4e0486
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405967
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-11 12:47:27 +00:00
angle-autoroll
38215457fe Roll SwiftShader from b24900a1aa39 to 41974f57973e (1 revision) 
https://swiftshader.googlesource.com/SwiftShader.git/+log/b24900a1aa39..41974f57973e

2020-09-10 jaebaek@google.com Allow OpTypeVoid for debug function return type

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I03a77041e3fe88df2f8b172df5e92afe45fd7d14
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405970
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-11 11:52:37 +00:00
angle-autoroll
4331ba7ac0 Roll Vulkan-Tools from ccab4cc42372 to d19622688af4 (1 revision) 
ccab4cc423..d19622688a

2020-09-10 shannon@lunarg.com build: Update known-good files for 1.2.153 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ic6110d1ece16436a7bd613c8bb02b1a10ec801ed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405969
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-11 11:15:37 +00:00
angle-autoroll
9a7e7b08a7 Roll Chromium from 30a5da059e5d to fe51fcb522cc (441 revisions) 
30a5da059e..fe51fcb522

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: 8984f7a2c3..41b95e3b54
* testing: e4f04cd4f5..64f2e1cf55
* third_party/abseil-cpp: de8d9210e5..9967a97317
* third_party/zlib: 898c6c0dd9..f8517bd629
No update to Clang.

Bug: angleproject:4846
Tbr: ianelliott@google.com
Change-Id: If0d924a9a1093b5798e2e95951b894b390c38dc5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405784
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-11 08:12:10 +00:00
Jiawei Shao
0c8f66c716 OpenGL: Get VendorID and DeviceID with angle::GetSystemInfo() 
Previously on the OpenGL backend we get the device ID with funtion
GetDeviceID() which just supports a few types of devices. This patch
fixes this issue by using angle::GetSystemInfo() instead.

Bug: angleproject:5011
Change-Id: Ief0e1228bb1871a73755f05f2debd3a8e5c75597
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2392634
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
 2020-09-11 02:27:00 +00:00
Jamie Madill
3486ec9677 Enable -Wweak-template-vtables. 
Needs one suppression due to Clang warning about multiple vtables
in a cpp file.

Bug: skia:7647
Change-Id: If7f318b7539d23f783b0ef6d6478ce24a0b72bc7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404746
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
 2020-09-11 02:02:00 +00:00
Courtney Goeltzenleuchter
ae09e88957 Fix mismatch issue with precision qualifiers. 
GLSL allows varyings passed from one stage to another to not match in
precision (e.g. float & half-float). Vulkan doesn't allow that so adjust
those mismatches to use the higher precision.

To fix we keep track of the precision of varyings and in the Vulkan
backend if we see they are different patch up the SPIR-V to make them
match.

Bug: angleproject:3078
Change-Id: I385d31e082da46ccdd4817b6612f5f9d9cbce17c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2337755
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
 2020-09-11 01:48:47 +00:00
Courtney Goeltzenleuchter
c5b5cf6c1f Refactor to pass ProgramMergedVaryings to link impl 
Follow-on CL needs the ProgramMergedVaryings in the Vulkan backend to
generate valid SPIRV.

Bug: angleproject:3078
Change-Id: Ic442a3e0bd713fec36bd6b9420f67f3b1118e5ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404336
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
 2020-09-11 00:55:46 +00:00
Jamie Madill
a4ef812c5d De-templatize ResourceManagerBase. 
Bug: skia:7647
Change-Id: I568cb63118c944c7eca7efcd2445718dc7fda350
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404745
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
 2020-09-11 00:39:46 +00:00
Jonah Ryan-Davis
1ab73f0f8c Cleanup disable_program_binary workaround 
This workaround should also clear the shader binary formats. Also,
we can use this workaround when disabling program binaries for
capture/replay.

Bug: angleproject:5007
Change-Id: I57c78e2cc95e7148cb8a1e7fb9bf3ed958fa69c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404383
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
 2020-09-10 20:51:01 +00:00
Hidehiko Abe
90a9cf9619 Expand is_linux to is_linux || is_chromeos. 
Currently is_linux is set to true on Chrome OS build,
but it is planned to set to false. This CL is the preparation
to keep the current behavior.

Bug: chromium:1110266
Test: Built locally. Tryjob.
Change-Id: I4124dfb251d68a519fed3e08555d1aa5a694c77c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404500
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2020-09-10 20:29:01 +00:00
Alexis Hetu
e99a9df2df Added integer overflow detection to ClipRectangle 
Used angle::CheckedNumeric to make sure none of the additions
in ClipRectangle produces an integer overflow.

Bug: chromium:1091364
Change-Id: I23b7943259010bb6bfde3d8ebc41e87a04f5b4f6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404441
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
 2020-09-10 19:42:11 +00:00
Shahbaz Youssefi
1bd71b48fb Make gl::DrawBufferMask a BitSet8 
This shrinks the size of the mask for use in cache key classes.

Bug: angleproject:4881
Change-Id: I87c234832c61e6a663c609b7f6da5d69977b21c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2399182
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2020-09-10 17:31:13 +00:00
Maksim Ivanov
fe8224572d Fix useless move() in SizedMRUCache_unittest.cpp 
Drop std::move() calls in places where there's no actual moving
happing, and only the "bugprone-use-after-move" clang-tidy
warning is triggered.

Bug: chromium:1122844
Change-Id: I692da5af4f96305f09008d1c7fd18f9be7f6273f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2401241
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
 2020-09-10 17:24:29 +00:00
Tim Van Patten
d29d4c6baf Vulkan: Avoid linking to SPIR-V validation if possible 
We unconditionally link to $angle_spirv_tools_dir:spvtools_val, but we
only use SPIR-V validation with ASSERTs. This CL removes this
dependency when ASSERTs are disabled.

Bug: angleproject:4887
Test: CQ
Change-Id: Ic403b78196ecd895e4a0cdefb54ab4497651ccac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2375872
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
 2020-09-10 16:55:08 +00:00
angle-autoroll
65dcbe1245 Roll Vulkan-ValidationLayers from 4ede8ee6e2ec to fcb7ecbe49c5 (5 revisions) 
4ede8ee6e2..fcb7ecbe49

2020-09-09 shannon@lunarg.com build: Update known-good files for 1.2.153 header
2020-09-09 shannon@lunarg.com build: Resolve last 1.2.152 VUID inconsistency
2020-09-09 tony@lunarg.com gpu: Intercept CmdDispatchBase to allocate input buffers
2020-09-09 s.fricke@samsung.com layers: Removed incorrect cmdDraw warnings
2020-09-09 baldurk@baldurk.org layers: Add a couple of missing % to printf specifiers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I2eb5a218a9ede986c5a5c4c27dcba68b1380188e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2403052
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-10 12:04:26 +00:00
angle-autoroll
8b1f0461b5 Roll SwiftShader from ce08265ba5b7 to b24900a1aa39 (1 revision) 
https://swiftshader.googlesource.com/SwiftShader.git/+log/ce08265ba5b7..b24900a1aa39

2020-09-09 sugoi@google.com Update PowerVR Samples to ToT

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I4759bb1c7f1f7a3a5b9c0186acc93b61ad3e3e79
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2403054
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-10 11:43:06 +00:00
angle-autoroll
8fd41dffec Roll SPIRV-Tools from a715b1b40535 to 2de7d3af0c0e (2 revisions) 
a715b1b405..2de7d3af0c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ifea2b79b7f2bf1d0e2cd03afd415b30fa14f8353
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2403053
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-10 11:11:16 +00:00
angle-autoroll
84508b9666 Roll Chromium from e9ccdaed3414 to 30a5da059e5d (421 revisions) 
e9ccdaed34..30a5da059e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: 9c1d4223d1..8984f7a2c3
* buildtools: ff93f3ea1a..a90362b4fc
* testing: 558bae6f39..e4f04cd4f5
No update to Clang.

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ie0d39bc5a74717daf4eb7b22a1a64bc3b59ddece
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2401934
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-10 08:27:41 +00:00
Shahbaz Youssefi
29b1f07f4a Vulkan: Boilerplate for vkCmdNextSubpass 
Bug: angleproject:4881
Change-Id: I5c46c07e8c7865ef2bfd8aff0d3f8b5ba3ecd750
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2399181
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2020-09-10 02:55:40 +00:00
Courtney Goeltzenleuchter
cbbf958764 Fix ASAN issue with accessing application name 
ASAN caught reference outside scope issue regarding
RendererVk::initialize. Need to have a local copy of the string so that
it stays alive for the Vulkan call.

Bug: b/168145220
Change-Id: I13d751a48fe86a5a3d603d892c86c5a7186f2606
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2402353
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2020-09-10 01:27:41 +00:00
Jonah Ryan-Davis
9a7b0a2dc5 Workaround bogus MscRate reported by some XWayland drivers. 
XWayland defaults to a 1hz refresh rate when the surface is not
visible, but this can sometimes cause issues in Chrome. If we see
a bogus rate like that, ANGLE can just report 30hz.

Bug: chromium:1042393
Change-Id: I554b05b4107cea528525ced6e95a5ce529eec3b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2388700
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
 2020-09-09 21:04:48 +00:00
Shrek Shao
a3bf9092e1 Suppress AtomicCounterBufferRangeRead failure on Nexus6P 
TBR=syoussefi@chromium.org
Bug: angleproject:3726
Change-Id: I8e4eb420ef43ee50b7e4df563148ed296f260adb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2401545
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
 2020-09-09 20:01:58 +00:00
Jose Dapena Paz
cee5748326 GCC: init kImageMemoryBarrierData with initializer constructor 
GCC fails to automatically map the initializer assignment for
initializing the angle::PackedEnumMap. So this change adds the
type hint ImageMemoryBarrierData to the second part of the pairs
passed to construct the PackedEnumMap.

GCC error:
    ./../third_party/angle/src/libANGLE/renderer/vulkan/vk_helpers.cpp:387:1: error: could not convert ‘{{rx::vk::ImageLayout::Undefined, {"Undefined", ...}}}’ from ‘<brace-enclosed initializer list>’
    to ‘const angle::PackedEnumMap<rx::vk::ImageLayout, rx::vk::{anonymous}::ImageMemoryBarrierData>’
      387 | };
          | ^
          | |
          | <brace-enclosed initializer list>

Bug: chromium:819294
Change-Id: I314c43c0795e54cabd891205ee935c6354d11658
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2401778
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2020-09-09 18:41:52 +00:00
angle-autoroll
48df087f8a Roll SwiftShader from 10121443c16d to ce08265ba5b7 (3 revisions) 
https://swiftshader.googlesource.com/SwiftShader.git/+log/10121443c16d..ce08265ba5b7

2020-09-09 capn@google.com Fix register assignment for constant arrays
2020-09-09 capn@google.com Fix component swizzle for uniform texel buffers
2020-09-09 sugoi@google.com Allow alphaToCoverage with a single sample

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Iefa5ad1f40ec2dfaae6d53d46e79de8a20471a7e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2400879
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-09 11:01:00 +00:00
angle-autoroll
e05f3af554 Roll SPIRV-Tools from 1ab52e54abfd to a715b1b40535 (2 revisions) 
1ab52e54ab..a715b1b405

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I28c3042c6e03ecde0c16f96889d6b88e0f54c7c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2400878
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2020-09-09 10:59:20 +00:00