21572 Commits

Author SHA1 Message Date
angle-autoroll
58cb5c8396 Roll Chromium from 0143d0520f3f to a78d58d81a3c (602 revisions)
0143d0520f..a78d58d81a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,romanl@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* testing: 184b068a94..b946312a89
* third_party/android_build_tools/manifest_merger: UwtCH6usmvLSrqbzGSTrjqJ1AJnNh-Vkq4hCEKvDM5oC..8fr-1Vf_pfxN9ulzWVaZvIXggDgWDs-0dtlGA1Sue48C
* third_party/android_deps: f588938604..a91b365204
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..84e3795d98
* third_party/depot_tools: d3e43dd431..54e86436a8
* tools/mb: 1b748bc9cb..4b377433d0
* tools/perf: ac82fc7dd9..e392c02236
No update to Clang.

Bug: None
Tbr: romanl@google.com
Change-Id: Ie5eb2c2fb0ef1c963d98533fdc9397a4cd99ecad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4719475
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2023-07-26 07:53:03 +00:00
Yuxin Hu
a09773110c Disable the usage of VK_EXT_legacy_dithering
Disable the usage of extension VK_EXT_legacy_dithering
on ARM until the bugs in this extension is addressed.

Bug: b/293136916
Bug: b/292282210
Change-Id: I1a548a2f6c44a78f8c66f706588a9985326217cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4718306
Reviewed-by: Solti Ho <solti@google.com>
Commit-Queue: Solti Ho <solti@google.com>
Reviewed-by: Kaiyi Li <kaiyili@google.com>
2023-07-26 00:12:02 +00:00
Geoff Lang
84f5295c97 Metal: Flush with NoWait when hitting renderpass count limits
This flush was added as an optimization to handle a specific use case
where many expensive GPU operations (clears and uploads) were queued
without being flushed. The GPU would be idle during these periods.

WaitUntilScheduled forced CPU/GPU synchronization when it was not
needed. We just want to make sure the work is flushed so the GPU can
pick it up later, not synchronize with anything external.

WaitUntilScheduled is used on iOS still because the Chrome waterfall
does not have coverage of iOS performance.

Bug: chromium:1466696
Change-Id: Ia8938eddf5be5ce586a91ad759d1563182176dba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4717367
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
2023-07-25 22:02:40 +00:00
Hailin zhang
4cae3b09ab Vulkan: disable pipline cache serialization
In old NV drivers, Vulkan pipeline cache will only
generate one single huge cache for one process
shared by all graphics piplines in the same process,
which can be huge.

This is temp solution for nvidia driver cache issue.
after driver version 520. nvidia fix the cache issue.
this might affect second running performance.

Bug: b/258207403
Change-Id: I3ea3e9196ad18fb1cec16c931eb744300d6cfdb9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4713207
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
2023-07-25 22:01:16 +00:00
Geoff Lang
05707391dc Metal: Re-add flush to eglBindTexImage but as NoWait
Removing the flush entirely caused performance regressions on a couple
of benchmarks because the GPU became idle waiting for work. Re-add
the flush but with NoWait so there is no CPU/GPU sychronization.

Bug: chromium:1466696, chromium:1467392
Change-Id: I5e2d1ca7b7a4590e3e668d2cd214d09d28c4b085
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4718007
Reviewed-by: Quyen Le <lehoangquyen@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
2023-07-25 20:53:36 +00:00
Brian Ho
b0b71d5939 Search for system libvulkan on CrOS
Currently, ANGLE searches in the "module" directory for libvulkan
during init on CrOS. The library doesn't exist at this location
(/opt/google/chrome/libvulkan.so), and we should instead just call
dlopen(libvulkan.so) to search the system library paths.

Bug: b/292249282
Change-Id: I7ab4803fe294e69f0ab8533ebc2fa43e25f189eb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4716242
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Brian Ho <hob@chromium.org>
2023-07-25 17:52:54 +00:00
Shahbaz Youssefi
7ea61cb3a1 GL: Complete EGL_ANGLE_external_context_and_surface
This change implements two new entry points added for
EGL_ANGLE_external_context_and_surface: glAcquireExternalContextANGLE
and glReleaseExternalContextANGLE.

These functions remove the need to overload eglMakeCurrent for the
purposes of syncing to and from the external context.

Bug: angleproject:5509
Change-Id: I5d46299ee0c8addaef7066914a8a8aacb0ea2c17
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706027
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
2023-07-25 17:07:56 +00:00
Shahbaz Youssefi
2d5fb09d7f Stubs for EGL_ANGLE_external_context_and_surface
Bug: angleproject:5509
Change-Id: I8e2395784abcd2b4e3e1f888e70a879ef49287bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706026
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
2023-07-25 16:16:54 +00:00
Geoff Lang
19dbaf1121 Mention the SwiftShader -> Chromium autoroller for Wranglers
The ANGLE team should make sure that the SwiftShader -> Chromium
autoroller stays green. If it gets too far out of sync, ANGLE's testing
within the ANGLE waterfall and Chromium waterfall will diverge.

Keeping this roller green is also critical for security issues fixes
to propogate to Chrome.

Bug: None
Change-Id: I650d906bbbd8c522b85082965f128a1bf071ae78
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4711827
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
2023-07-25 16:16:02 +00:00
Joanna Wang
7ae6458b66 Temporarily remove repos involved in llvm builds.
Add these deps back once the change in chromium/src is merged:
https://chromium-review.googlesource.com/c/chromium/src/+/4666325

Bug: chromium:1458042
Change-Id: I63b5b80e5a5a594ce61e9b72eaffb3a87d6719c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706819
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
2023-07-25 13:36:54 +00:00
angle-autoroll
e8c8c56512 Roll SwiftShader from 66d6b0dd0c39 to 9fbca2df22a8 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/66d6b0dd0c39..9fbca2df22a8

2023-07-24 bclayton@google.com LLVMReactor: Support LLVM 17+
2023-07-24 bclayton@google.com LLVMReactor: Remove CreateFreeze() call

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC angle-team@google.com,romanl@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: romanl@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: I7f76a349321e23f85f8bd72eb4903163c1cb8bb4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4713596
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2023-07-25 11:07:53 +00:00
angle-autoroll
0b41e4edd7 Roll vulkan-deps from 7db08a9e0a29 to 6f1c3384ecb6 (24 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/7db08a9e0a29..6f1c3384ecb6

Changed dependencies:
* glslang: 65397339c5..4aa56496d6
* spirv-headers: 14914db17a..51b1064617
* spirv-tools: 17d9669d51..ec90d2872a
* vulkan-headers: 6eee20744f..cb7b123f2d
* vulkan-loader: fdae336d4f..220a00bf95
* vulkan-tools: c5ac1413f0..ed6820d508
* vulkan-validation-layers: 34a5dd9aec..e5f54cc2ea

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,romanl@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: romanl@google.com
Change-Id: Ia8e2491d99cd90b6e68e0b8e62fdde0d55c7e6ae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4713573
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2023-07-25 10:57:56 +00:00
angle-autoroll
1b17c91e42 Roll Chromium from 6eba95b5d89b to 0143d0520f3f (584 revisions)
6eba95b5d8..0143d0520f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,romanl@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: 7fb08159d8..860dae780c
* testing: 7a04c5b9df..184b068a94
* third_party/android_deps: 9ce3e620bd..f588938604
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..fa05d995e1
* third_party/depot_tools: d411904b84..d3e43dd431
* third_party/r8: Sz7S7AlqFPYB_t29P5b6i5K80Wq00mpvN2y8aNUAqo0C..O1BBWiBTIeNUcraX8STMtQXVaCleu6SJJjWCcnfhPLkC
* tools/mb: f819d02e6f..1b748bc9cb
* tools/memory: 9a047fd494..2a4c4ba1f4
* tools/skia_goldctl/linux: Q5cqdj5BQE3eWNCe2CqhLT13X-o0w1ta7V2XnmXIrnEC..yiBOCk-vzyyWi8kF1hfi8_yZoQb5Y5nUrgH-gKy3s_4C
* tools/skia_goldctl/mac_amd64: YieDEr0s0SH8j_1Os9w89pblPmGHE2vvLJtvdTYamfAC..IOfj5k7LF0hVZeJ-_iTpGovRg26fblRBMk0wLT1GJnAC
* tools/skia_goldctl/mac_arm64: isJD0ZhCCqmn1h8q6_12lvDCcKt_M-8v548oOoQwpN4C..nAEU10uINeZnsOib3LZlcLZgRr3I8YETFJqTpMpw3ukC
* tools/skia_goldctl/win: OzmCj3mfsBuDD-gOktZNf1BcL8eg8Ewi8ekcYDI4tsAC..pGeqtL9kCYQirdV-A7YpDFltq8_TFh64j6MuVoc7YswC
No update to Clang.

Bug: angleproject:7904
Tbr: romanl@google.com
Change-Id: I4e89898b8961c7be2a3d85f97101270ddf5efab2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4713571
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2023-07-25 08:23:27 +00:00
Roman Lavrov
2d999f7448 Android: Add a way to prepare traces without running tests
Example:
    % out/Android/angle_trace_tests --gtest_filter='*gacha_life' --prepare-only
    ...
    Prepared traces: {'gacha_life'}

Can be used as a setup for running restricted_trace_perf.py

Bug: b/292249127
Change-Id: I901c086a19e1d182c64ec4150ced98c198e21c4d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4711826
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
2023-07-24 18:41:32 +00:00
Igor Nazarov
5e21d7f024 Vulkan: Remove dead code
Dead code remained after this CL:
    https://chromium-review.googlesource.com/c/angle/angle/+/3998747
    Vulkan: Remove unused ShaderAndSerial

Bug: b/257116399
Change-Id: Ica3b941fa98886dff309b5eb1734a1718fa8f6fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4711585
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
2023-07-24 17:08:26 +00:00
Geoff Lang
5a06559231 Metal: Don't flush on eglBindTexImage.
There is nothing that needs synchronization at this point. About 30% of
ANGLE's CPU time is spent here.

Bug: chromium:1466696
Change-Id: I4993804823790ee9cc38530dea334a6fa3abe7f6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706926
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Gregg Tavares <gman@chromium.org>
2023-07-24 15:48:43 +00:00
Roman Lavrov
e1a34cbfce Android.bp generation: vulkan-headers LICENSE.txt -> .md
Bug: angleproject:8271
Change-Id: I7e31ce26afcf8da22f6aa8518433bb131be4e74b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4711825
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
2023-07-24 14:36:07 +00:00
angle-autoroll
a6c751f6dd Roll SwiftShader from 4a260c12b8c1 to 66d6b0dd0c39 (6 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/4a260c12b8c1..66d6b0dd0c39

2023-07-23 bclayton@google.com LLVMReactor: Clamp RHS of bit shifts
using type width
2023-07-22 bclayton@google.com Fix another 'sign-compare' warning as
error
2023-07-22 bclayton@google.com Fix 'sign-compare' warning as error
2023-07-21 bclayton@google.com LLVMReactor: Clamp RHS of bit shifts.
2023-07-21 swiftshader.regress@gmail.com Regres: Update test lists @
4a260c12
2023-07-21 bclayton@google.com ExecutableMemory: Use VirtualAlloc()
instead of `new` on windows

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: abdolrashidi@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: I20955bd6b2b74e9a6696848623e010680905cdb3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4709812
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2023-07-24 11:26:22 +00:00
angle-autoroll
e28575f66a Roll Chromium from 986ed21b8935 to 6eba95b5d89b (527 revisions)
986ed21b89..6eba95b5d8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: 76d3034c73..7fb08159d8
* testing: 1f5c4581ad..7a04c5b9df
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b119dc414e
* third_party/depot_tools: 82e4859614..d411904b84
* third_party/fuchsia-sdk/sdk: version:13.20230721.1.1..version:13.20230714.0.1
* third_party/zlib: d3b3d64f7d..75c09362db
* tools/mb: 0a7e1f1b7a..f819d02e6f
No update to Clang.

Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I02990ac903582a30943da0f32f44be4c7f274afc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706095
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2023-07-24 10:08:41 +00:00
Geoff Lang
430a4f559c Fix read size validation for RGBX formats.
GL_RGBX8_ANGLE is the only format where the upload format is 3-channel
RGB, whilethe download format is 4-channel RGBX.  As such, the internal
format corresponding to format+type expects 3-byte input/output.  The
format is fixed here for readPixels to output 4 bytes per pixel.

Bug: chromium:1458046
Change-Id: Iec737ed64bade003cfab50dc5f595eb4875e81e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706957
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
chromium/5908
2023-07-23 01:36:14 +00:00
Roman Lavrov
938ee1e80f Vulkan: legacy_dithering disallow reactivate when breaking RP
Hitting the assert in dEQP GLES2.functional.fragment_ops.random.0:
https://crsrc.org/c/third_party/angle/src/libANGLE/renderer/vulkan/ContextVk.cpp;drc=52fe3116ead9a5de51ddad17fcb14bf8ecb3a69d;l=2347

Bug: b/292259684
Change-Id: Ib40b90dde3b271c714b6181e4ba4d70f3e1b5e86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706174
Reviewed-by: Charlie Lao <cclao@google.com>
Auto-Submit: Roman Lavrov <romanl@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
2023-07-21 21:31:28 +00:00
Geoff Lang
f586ec98d9 Metal: Validate max render target size without an allocation
We would allocate a MTLRenderPassDescriptor for validating an internal
error case only to throw it away immediately afterwards. This happened
on every new render pass.

This allocation/release amounts to about 10% of ANGLE's CPU time when
running Chrome.

Bug: chromium:1466696
Change-Id: I0bbe086c0b8006d2ff15ae57f25b591f791acb60
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706925
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
2023-07-21 20:20:24 +00:00
Geoff Lang
085f25bbb1 GL: Protect against drivers returning 0 max clip distances.
Some Android devices in the wild were hitting the assert that
maxClipDistances must be greater than 0 if ANGLE_clip_cull_distance
is exposed.

Protect against this by disabling various clip/cull extensions if
they don't meet the requirements for number of distances.

Bug: angleproject:7904
Change-Id: Ic6a5e959437fa7aad5302a12cf8c92d1d18024b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706684
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
2023-07-21 19:18:04 +00:00
angle-autoroll
82d68c577b Manual roll Chromium from e3bcada48f45 to 986ed21b8935 (1346 revisions)
Manual roll requested by ynovikov@google.com

e3bcada48f..986ed21b89

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC
abdolrashidi@google.com,angle-team@google.com,ynovikov@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: 00557a04e4..76d3034c73
* buildtools: 1cc82962cb..ca163845c7
* buildtools/third_party/libunwind/trunk: f1c687e0aa..6c0013015b
* testing: 454f446791..1f5c4581ad
* third_party/abseil-cpp: f317d51223..9544eb36c9
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a02c178207
* third_party/depot_tools: 60b21dd193..82e4859614
* third_party/fuchsia-sdk/sdk: version:13.20230714.0.1..version:13.20230721.1.1
* third_party/jdk: 9-e8GxXJduErc9j3s5VUmbAWTorSHxvcn23GNjYtCNwC..IivIDwNBf73mf7UwCOBceRUuDdtizMCgSOQDfUGHArsC
* third_party/zlib: 61dc0bd13f..d3b3d64f7d
* tools/mb: b559f90fa3..0a7e1f1b7a
No update to Clang.

Bug: None
Tbr: abdolrashidi@google.com,ynovikov@google.com
Change-Id: If602e6f8163e7dd81420ebd20fc1677b68b539f6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4707721
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2023-07-21 18:23:21 +00:00
Geoff Lang
2e190280f5 GL: Extend disable of EXT_clip_control to Mali-G51.
The G51 appears to be the only other device with this issue.

Bug: chromium:1434317
Change-Id: Iffbc95a7f612c1862e9d129649a6211f488df6c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706564
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
2023-07-21 12:54:00 +00:00
angle-autoroll
e1887773b1 Roll vulkan-deps from e1c3b16d5aa5 to 7db08a9e0a29 (12 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/e1c3b16d5aa5..7db08a9e0a29

Changed dependencies:
* glslang: 77417d5c9e..65397339c5
* spirv-tools: 883417544b..17d9669d51
* vulkan-validation-layers: 3c3d04d219..34a5dd9aec

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I661522c96e889ce5ab93f56e3e5d68170da571e2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706476
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2023-07-21 11:00:44 +00:00
angle-autoroll
b60068009d Roll SwiftShader from 4e401427f8dd to 4a260c12b8c1 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/4e401427f8dd..4a260c12b8c1

2023-07-20 avi@google.com Don't allow Swiftshader to be compiled as ARC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: abdolrashidi@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: I4c41c19fb0354a67c3258f0bbb44fa8b2685bfc0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4707174
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2023-07-21 10:58:54 +00:00
Avi Drissman
f2e0f8a0b2 Don't allow ANGLE to be compiled as ARC
Chromium is switching to compilation with ARC. While there are
remnants of ARC dual-compilation, ANGLE isn't ready for that, so don't
allow it to be compiled with ARC.

Bug: chromium:733237, angleproject:8267
Change-Id: If5c8d5ab039fb44e10102df616e72dbcfd55ac70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4698494
Auto-Submit: Avi Drissman <avi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
2023-07-20 18:35:39 +00:00
Jason Macnak
8138ae9b1f Vulkan: EGL's DISPLAY_P3_PASSTHROUGH -> VK's DISPLAY_P3_NONLINEAR
From
https://registry.khronos.org/EGL/extensions/EXT/EGL_EXT_gl_colorspace_display_p3_passthrough.txt

  If its value is EGL_GL_COLORSPACE_DISPLAY_P3_PASSTHROUGH_EXT, then a
  non-linear, sRGB encoded Display-P3 color space is assumed

Bug: b/289125521
Test: cvd start
Test: cts -m CtsViewTestCases
          -t android.view.cts.TextureViewTest#testGetBitmap_8888_PassthroughP3
Change-Id: I07c77c86bbc0d82923ad7435cd2a5558770cd2e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4673910
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Commit-Queue: Jason Macnak <natsu@google.com>
2023-07-20 18:25:16 +00:00
angle-autoroll
a4c283be74 Roll vulkan-deps from 7f74d379edd8 to e1c3b16d5aa5 (7 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/7f74d379edd8..e1c3b16d5aa5

Changed dependencies:
* glslang: 9b1a0f4d3e..77417d5c9e
* spirv-headers: 66e5000344..14914db17a
* spirv-tools: 6c7e1acc5f..883417544b
* vulkan-validation-layers: 971615e6d8..3c3d04d219

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I1ce7bea364a94bc9e522ecafa25014ef24494b0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4704406
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2023-07-20 10:58:48 +00:00
angle-autoroll
5e38a31bd7 Manual roll vulkan-deps from 831910dbe1f3 to 7f74d379edd8 (38 revisions)
Manual roll requested by abdolrashidi@google.com

https://chromium.googlesource.com/vulkan-deps.git/+log/831910dbe1f3..7f74d379edd8

Changed dependencies:
* glslang: f47028995c..9b1a0f4d3e
* spirv-headers: f1ba373ef0..66e5000344
* spirv-tools: 29431859f5..6c7e1acc5f
* vulkan-headers: bc14fdad60..6eee20744f
* vulkan-loader: 6837a92c34..fdae336d4f
* vulkan-tools: 6e7fa4d975..c5ac1413f0
* vulkan-validation-layers: 32a2af3fd6..971615e6d8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: abdolrashidi@google.com
Change-Id: If341ed03d859dc8abaeb9caa3f8d1dcb56cfae2a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4703106
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2023-07-19 22:27:07 +00:00
Mohan Maiya
4515b27077 Account for implementations that support large gl_PointSize values
The PointSizeAboveMaxIsClamped end2end test intends to render a point
with gl_PointSize that is 2x the implementation's max value to test if
this value is clamped correctly. However, when the max gl_PointSize is
large enough, like with AMD drivers, it results in the center of the
point being outside of the viewport which according to the spec can be
discarded.

Update the test to render to a framebuffer, instead of the default
window surface, one large enough to contain a point of implementation
defined max point size.

Bug: angleproject:2113
Test: PointSpritesTest.PointSizeAboveMaxIsClamped*
Change-Id: I724440495bf5a3c93c76cc28109937a56c45f274
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4697681
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
2023-07-19 16:54:48 +00:00
Phan Quang Minh
ef4327f6aa Vulkan: Make UtilsVk::copyImage copy YCbCr images properly
This changes the descriptor binding for the image from
VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE to
VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER for YCbCr source textures and
ensures that the copy pipelines and descriptor sets for YCbCr source
textures are created with the appropriate YCbCr samplers, and use the
`texture()` function instead of `texelFetch()` for YCbCr images.

Bug: angleproject:8252
Change-Id: Ife3e230d3669b275f4e0fab1922d75b6b6c4f8bd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675806
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
2023-07-19 14:44:41 +00:00
angle-autoroll
4dcaad2a89 Roll SwiftShader from 151fa797ee3e to 4e401427f8dd (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/151fa797ee3e..4e401427f8dd

2023-07-18 tiszka@chromium.org [subzero] Fix integer overflows during
alloca coalescing

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in SwiftShader:
https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: abdolrashidi@google.com
Use-Permissive-Angle-Pixel-Comparison: True
Change-Id: I47f72bcc6cdeb1901ea16e7f2039c04a6d2f1fdb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4700723
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2023-07-19 10:56:47 +00:00
angle-autoroll
255dec8864 Roll Chromium from 8806dade91f0 to e3bcada48f45 (580 revisions)
8806dade91..e3bcada48f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: ed8697168d..00557a04e4
* testing: a2c493455a..454f446791
* third_party/abseil-cpp: ae5ee2a38f..f317d51223
* third_party/android_build_tools: e197e4c396..02f9cdf1a9
* third_party/android_build_tools/lint: OPMAEfzTB1WPytaO0pMOPg9GHVByubIOUvOsCwKS1oQC..cLtgSrpk1a4zUb-XNIAaxmKn2OAZ-fnG9kZBqI3n9XEC
* third_party/android_build_tools/manifest_merger: kxzD7gkXhEJiL_u2jVkpX0Npl2MLoSvbnBezhq29dAgC..UwtCH6usmvLSrqbzGSTrjqJ1AJnNh-Vkq4hCEKvDM5oC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..707e9093f7
* third_party/depot_tools: 94f76acc94..60b21dd193
* third_party/libjpeg_turbo: aa4075f116..30bdb85e30
* tools/android: f1f08a05ad..43f8a41f8f
* tools/clang: a7a6e86ea5..9e679731de
* tools/mb: a8b8553345..b559f90fa3
No update to Clang.

Bug: None
Tbr: abdolrashidi@google.com
Change-Id: Iad1a7d705668ce848aa8442e89cc3d73d983b894
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4699572
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2023-07-19 07:56:47 +00:00
angle-autoroll
b32d661389 Manual roll vulkan-deps from aa35b58fce7d to 831910dbe1f3 (8 revisions)
Manual roll requested by abdolrashidi@google.com

https://chromium.googlesource.com/vulkan-deps.git/+log/aa35b58fce7d..831910dbe1f3

Changed dependencies:
* spirv-cross: b8e742c91b..b43c1a1e63
* vulkan-headers: 2565ffa31e..bc14fdad60
* vulkan-validation-layers: 80679543ad..32a2af3fd6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I5e24d509cf13b3a110f84ffeecc228ac7e83ba54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4697917
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2023-07-19 01:43:00 +00:00
Hailin Zhang
6eea5ff4db Vulkan: fix default MSAA framebuffer clear issue.
Bug: b/290813597
Change-Id: I134c5a99382ca30dbd885a17dfa3c7ac227480ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4698113
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Hailin Zhang <hailinzhang@google.com>
2023-07-18 21:27:36 +00:00
Shahbaz Youssefi
52fe3116ea Vulkan: Deduplicate share group's context set tracking
Bug: angleproject:8224
Change-Id: I7a59a37229682fb91ff777f31e02e05d7ab2b80f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4690345
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
2023-07-18 16:31:53 +00:00
Phan Quang Minh
5eb30562b0 Reland "Vulkan: Remove platform restriction of EGL_ANDROID_native_fence_sync"
Instead of enabling it on all non-Mac platforms, this time enable it
only on Linux-kernel based platforms (Linux, ChromeOS, Android). This
should avoid interfering with Fuchsia.

Original change description:
> Remove platform restriction of EGL_ANDROID_native_fence_sync
> extension except for Mac OS.
>
> Bug: angleproject:7834
> Change-Id: I116f44d8baca9cdcdd90013ca173b04461d06ae1
> Signed-off-by: Sungyong Choi <sywow.choi@samsung.com>
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4027707
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: mohan maiya <m.maiya@samsung.com>
> Commit-Queue: mohan maiya <m.maiya@samsung.com>

Bug: angleproject:7834
Change-Id: Ida89100e8c30c3a2df5a0a8d6d0c9b7e7ce3e412
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4687427
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
2023-07-18 16:30:57 +00:00
Cody Northrop
85095480da Android: Update script with sync progress
When running lots of traces, there can be a long pause
when syncing traces to the device.

Add a small update so it is clear that work is happening.

Example output:

I12:21:51.806619Z Syncing 1945_air_force trace (1/238)
I12:21:52.178401Z Syncing 20_minutes_till_dawn trace (2/238)
I12:21:52.463608Z Syncing 2_3_4_player_mini_games trace (3/238)
...

Test: angle_trace_tests
Bug: b/276742336
Change-Id: Id81d69b3fc678cb94c2e683a907c44950ead2117
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4690745
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
2023-07-18 14:25:51 +00:00
Saifuddin Hitawala
a64537f946 Angle: Copy multiplanar d3d11 texture for readPixels
This change performs a copy to an intermediate texture for multiplanar
d3d11 textures before reading from the source texture. This is needed
as we cannot read a plane directly from a multiplanar d3d11 texture.

It also passes the correct format for the plane for multiplanar formats
when initializing the texture instead of getting the format using the
internal format.

We also add a unittest performing glReadPixels for NV12/P010/P016
formats.

Bug: angleproject:7998, chromium:1463924
Change-Id: I9a1708f5a846ace28ac3b6593ea80f1863348333
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4688118
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Auto-Submit: Saifuddin Hitawala <hitawala@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
2023-07-18 13:17:13 +00:00
angle-autoroll
fe541ddbc4 Roll Chromium from 48a8f73f303f to 8806dade91f0 (572 revisions)
48a8f73f30..8806dade91

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC abdolrashidi@google.com,angle-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: a158d61f27..ed8697168d
* buildtools/third_party/libc++abi/trunk: d6ce172e32..d4760c0af9
* testing: b98bc2989c..a2c493455a
* third_party/android_build_tools/bundletool: LbB0aRQ3VKjRJZmc_PD0VTZ1O34_zD92rh71aOEOEcEC..2PJKytTLILAjCO3G7sCO27FO48XB9qrRTHp420zr5G0C
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7a8318124d
* third_party/depot_tools: b389d031a2..94f76acc94
* tools/android: 80da587681..f1f08a05ad
* tools/clang: c05e52187e..a7a6e86ea5
* tools/mb: 5ce938841d..a8b8553345
* tools/perf: a2303f1c72..ac82fc7dd9
No update to Clang.

Bug: None
Tbr: abdolrashidi@google.com
Change-Id: I72354d9bc7c667d070a68544dcc17cb9ae9f38dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4693482
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2023-07-18 09:04:33 +00:00
Brian Sheedy
ec2948c5ed Start Mac Intel 13.4.1 experiment
Bug: chromium:1464635
Change-Id: Ie7cf5d68fff54b0b58ca1a4c102ab8c8368bd3ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4684014
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
2023-07-17 22:24:05 +00:00
Shahbaz Youssefi
9f9284b7de Move ShareGroup to its own files
Bug: angleproject:8224
Change-Id: Id6d272018bb5ee8c3e35488f641efa4d99fa836d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4690003
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
2023-07-17 22:21:48 +00:00
Geoff Lang
9aadc7aacd Metal: Require MSL 2.1.
We had previously shipped both MSL 2.0 and 2.1 shaders to support
MacOS 10.13 (MSL 2.0 only) while also supporting the stencil blit
fast path that MSL 2.1 provides with the has_shader_stencil_output
feature.

Each configuration of precompiled shaders is ~300kb so we will drop
support for MacOS 10.13 and only ship the MSL 2.1 shaders.

Rework of the disablement for NVIDIA and GPU family 1 to be more
readable. The features themselves are always true because "disable on
NVIDIA" is always true and the check for "is NVIDIA" is moved to the
code which fails the initialization.

Bug: angleproject:8258
Change-Id: Icc8c69540e43fd2b0b237fffbfe170bb3422903f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4681130
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
2023-07-17 22:00:36 +00:00
Geoff Lang
d40669bb4b Android: Use ALooper_pollOnce instead of ALooper_pollAll
ALooper_pollAll can cause potential deadlocks.

These calls are only made by our test suites.

Bug: chromium:1464077
Change-Id: Id56c0db67e10d6df00c3e6b9126952ffa1d40d48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4690382
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
2023-07-17 20:42:37 +00:00
Roman Lavrov
0518a3ff4d Android: Simplify power metrics collection
Also check for missing values and dupes

Bug: b/291604008
Change-Id: I909ca2bf53d3aa0bf5ba66f7168e9925cfd7da3c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685323
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
2023-07-17 18:22:33 +00:00
Shahbaz Youssefi
bebb83d918 Translator: Limit variable sizes vs uint overflow
Bug: chromium:1464680
Change-Id: I90e204db1ce57c87ed5fe19912e4c157cee18a90
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685236
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
2023-07-17 17:29:36 +00:00
Mohan Maiya
05ea114724 Vulkan: Bugfix in gl_FragData array redeclaration
Both OpenGL ES and Vulkan spec allows implementations to limit
the number of output attachments when dual-source blending is enabled.
Account for this limit when setting gl_FragData array length by
re-declaring the gl_FragData array size to match
maxFragmentDualSrcAttachments value.

Bug: angleproject:5537
Test: EXTBlendFuncExtendedDrawTest.FragData/ES2_Vulkan
Change-Id: I5a462344f4c4faf850f56e9c5d4c392370d3d010
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4688396
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
2023-07-17 17:16:02 +00:00
Shahbaz Youssefi
bd8001e581 Fix deadlock on device loss
Some backends generate a device loss (propagated to all contexts) while
querying the device status.  The latter is held under a lock, and the
former would attempt to hold the lock when marking the calling context
with device loss.

Bug: chromium:1465262
Change-Id: I55fd96f3573732953daf2a305b0120dbcae6ea30
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4690063
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
2023-07-17 17:10:37 +00:00