Disable the usage of VK_EXT_legacy_dithering

Disable the usage of extension VK_EXT_legacy_dithering
on ARM until the bugs in this extension is addressed.

Bug: b/293136916
Bug: b/292282210
Change-Id: I1a548a2f6c44a78f8c66f706588a9985326217cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4718306
Reviewed-by: Solti Ho <solti@google.com>
Commit-Queue: Solti Ho <solti@google.com>
Reviewed-by: Kaiyi Li <kaiyili@google.com>
This commit is contained in:
Yuxin Hu
2023-07-25 12:18:30 -07:00
committed by Angle LUCI CQ
parent 84f5295c97
commit a09773110c

View File

@@ -4433,8 +4433,10 @@ void RendererVk::initFeatures(DisplayVk *displayVk,
mSwapchainMaintenance1Features.swapchainMaintenance1 == VK_TRUE);
// The VK_EXT_legacy_dithering extension enables dithering support without emulation
// Disable the usage of VK_EXT_legacy_dithering on ARM until the driver bug
// http://issuetracker.google.com/293136916, http://issuetracker.google.com/292282210 are fixed.
ANGLE_FEATURE_CONDITION(&mFeatures, supportsLegacyDithering,
mDitheringFeatures.legacyDithering == VK_TRUE);
mDitheringFeatures.legacyDithering == VK_TRUE && !isARM);
// Applications on Android have come to rely on hardware dithering, and visually regress without
// it. On desktop GPUs, OpenGL's dithering is a no-op. The following setting mimics that