godotengine/godot-angle-static
1
0
Fork 0
mirror of https://github.com/godotengine/godot-angle-static.git synced 2026-01-06 02:09:55 +03:00
Code Issues Packages Projects Releases Wiki Activity

MTLPixelFormatRGB9E5Float is not renderable on simulator.

Browse Source 
See https://developer.apple.com/documentation/metal/
developing_metal_apps_that_run_in_simulator?language=objc

Bug: angleproject:7994
Change-Id: I07e50c19aaf6d033c7c25d0dbd4b21a8c255c1d9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4386403
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
This commit is contained in:
Maksim Sisov
2023-03-31 14:54:17 +03:00
committed by Angle LUCI CQ
parent f176027fcd
commit 61cd24d468
4 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
scripts/code_generation_hashes/Metal_format_table.json
View File

@@ -6,7 +6,7 @@
"src/libANGLE/renderer/metal/gen_mtl_format_table.py":
"28f3065f5d1bc65803b1218b706430ae",
"src/libANGLE/renderer/metal/mtl_format_map.json":
"19bd12ef7042d85051b25ad059fa65dc",
"a5e979c40720bce003457f0d3b6fc7dc",
"src/libANGLE/renderer/metal/mtl_format_table_autogen.mm":
"c347c73fdfca96e6dc4e59840b52dc29"
"af9a50ae7f47145abdfb3deea1e6238c"
}

2
src/libANGLE/renderer/metal/mtl_format_map.json
View File

@@ -454,7 +454,7 @@
"blendable": "display->supportsAppleGPUFamily(1)",
"multisample": "display->supportsAppleGPUFamily(1)",
"resolve": "display->supportsAppleGPUFamily(1)",
"colorRenderable": "display->supportsAppleGPUFamily(1)"
"colorRenderable": "display->supportsAppleGPUFamily(1) && !display->isSimulator()"
},
"MTLPixelFormatR8Uint":{
"filterable": "false",

15
src/libANGLE/renderer/metal/mtl_format_table_autogen.mm
View File

@@ -3719,13 +3719,14 @@ void FormatTable::initNativeFormatCapsAutogen(const DisplayMtl *display)
/** multisample*/ true, /** resolve*/ true, /** colorRenderable*/ true,
/** depthRenderable*/ false);
setFormatCaps(MTLPixelFormatRGB9E5Float, /** filterable*/ true,
/** writable*/ display->supportsAppleGPUFamily(3),
/** blendable*/ display->supportsAppleGPUFamily(1),
/** multisample*/ display->supportsAppleGPUFamily(1),
/** resolve*/ display->supportsAppleGPUFamily(1),
/** colorRenderable*/ display->supportsAppleGPUFamily(1),
/** depthRenderable*/ false);
setFormatCaps(
MTLPixelFormatRGB9E5Float, /** filterable*/ true,
/** writable*/ display->supportsAppleGPUFamily(3),
/** blendable*/ display->supportsAppleGPUFamily(1),
/** multisample*/ display->supportsAppleGPUFamily(1),
/** resolve*/ display->supportsAppleGPUFamily(1),
/** colorRenderable*/ display->supportsAppleGPUFamily(1) && !display->isSimulator(),
/** depthRenderable*/ false);
setFormatCaps(MTLPixelFormatRGBA16Float, /** filterable*/ true, /** writable*/ true,
/** blendable*/ true, /** multisample*/ true, /** resolve*/ true,

2
src/tests/angle_end2end_tests_expectations.txt
View File

@@ -788,8 +788,6 @@
7853 IOS : FramebufferExtensionsTest.ColorBufferHalfFloat/ES2_OpenGL = SKIP
// Some Metal tests fail on iOS Intel simulator
7994 IOS METAL : CopyTextureTestES3.ES3FloatFormats/ES3_Metal = SKIP
7994 IOS METAL : CopyTextureTestES3.CopySubTextureOffsetNonRenderableFloat/ES3_Metal = SKIP
7994 IOS METAL : CubeMapTextureTest.SampleCoordinateTransformGrad/ES2_Metal = SKIP
7994 IOS METAL : CubeMapTextureTest.SampleCoordinateTransformGrad/ES3_Metal = SKIP
7994 IOS METAL : CubeMapTextureTest.SampleCoordinateTransformGrad_ES3/ES3_Metal = SKIP