godotengine/godot-interactive-changelog
1
0
Fork 0
mirror of https://github.com/godotengine/godot-interactive-changelog.git synced 2026-01-04 02:10:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

Prevent hard errors when data is missing for some configs

Browse Source
This commit is contained in:
Yuri Sizov
2023-03-23 21:44:15 +01:00
parent 16b0dfb9b8
commit c7c7b50deb
2 changed files with 56 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/paths/index/components/changes/ChangesList.js
View File

@@ -84,19 +84,19 @@ export default class ChangesList extends LitElement {
}
// Default to the main log of the version.
this._active_log = this.version.commit_log;
this._version_ref = this.version.ref;
this._version_from_ref = this.version.from_ref;
this._version_article = this.version.article;
this._active_log = this.version.commit_log || [];
this._version_ref = this.version.ref || "";
this._version_from_ref = this.version.from_ref || "";
this._version_article = this.version.article || "";
// But if we're in a specific release, find its log.
if (this.selectedRelease !== "") {
if (this.selectedRelease !== "" && typeof this.version.releases !== "undefined") {
for (let release of this.version.releases) {
if (release.name === this.selectedRelease) {
this._active_log = release.commit_log;
this._version_ref = release.ref;
this._version_from_ref = release.from_ref;
this._version_article = release.article;
this._active_log = release.commit_log || [];
this._version_ref = release.ref || "";
this._version_from_ref = release.from_ref || "";
this._version_article = release.article || "";
break;
}
}

91
src/paths/index/entry.js
View File

@@ -109,61 +109,64 @@ export default class EntryComponent extends LitElement {
this._loadingVersions.push(version.name);
const versionData = await greports.api.getVersionData(this._selectedRepository, version.name);
versionData.config = version;
this._versionData[version.name] = versionData;
// Calculate number of changes for the version, and each if its releases.
const [...commitLog] = versionData.log;
commitLog.reverse();
if (versionData) {
versionData.config = version;
this._versionData[version.name] = versionData;
// We need to filter out all merge commits for display and the count.
version.commit_log = [];
commitLog.forEach((commitHash) => {
const commit = versionData.commits[commitHash];
if (commit.is_merge) {
return; // Continue.
}
// Calculate number of changes for the version, and each if its releases.
const [...commitLog] = versionData.log;
commitLog.reverse();
version.commit_log.push(commitHash);
});
version.releases.forEach((release) => {
release.commit_log = [];
let counting = false;
commitLog.forEach((commitHash, index) => {
// We need to filter out all merge commits for display and the count.
version.commit_log = [];
commitLog.forEach((commitHash) => {
const commit = versionData.commits[commitHash];
// We need to filter out all merge commits for display and the count.
if (counting && !commit.is_merge) {
release.commit_log.push(commitHash);
if (commit.is_merge) {
return; // Continue.
}
// We need to check indices for some refs, because they are not written
// in the commit hash format.
version.commit_log.push(commitHash);
});
// Start counting.
if (release.from_ref === version.from_ref && index === 0) {
counting = true;
// HACK: Exclude the lower end by default, but include for the first range.
if (!commit.is_merge) {
// It shouldn't be possible for the first commit to be a merge commit,
// but let's guard anyway.
version.releases.forEach((release) => {
release.commit_log = [];
let counting = false;
commitLog.forEach((commitHash, index) => {
const commit = versionData.commits[commitHash];
// We need to filter out all merge commits for display and the count.
if (counting && !commit.is_merge) {
release.commit_log.push(commitHash);
}
}
else if (commitHash === release.from_ref) {
counting = true;
}
// Stop counting.
if (release.ref === version.ref && index === (commitLog.length - 1)) {
counting = false;
}
else if (commitHash === release.ref) {
counting = false;
}
// We need to check indices for some refs, because they are not written
// in the commit hash format.
// Start counting.
if (release.from_ref === version.from_ref && index === 0) {
counting = true;
// HACK: Exclude the lower end by default, but include for the first range.
if (!commit.is_merge) {
// It shouldn't be possible for the first commit to be a merge commit,
// but let's guard anyway.
release.commit_log.push(commitHash);
}
}
else if (commitHash === release.from_ref) {
counting = true;
}
// Stop counting.
if (release.ref === version.ref && index === (commitLog.length - 1)) {
counting = false;
}
else if (commitHash === release.ref) {
counting = false;
}
});
});
});
}
// Finish loading, hide the indicator.
const index = this._loadingVersions.indexOf(version.name);