godotengine/godot-git-plugin
1
0
Fork 0
mirror of https://github.com/godotengine/godot-git-plugin.git synced 2026-01-01 01:48:28 +03:00
Code Issues Packages Projects Releases Wiki Activity

Stop progress_cb from generating spurious warnings (#243)

Browse Source 
`progress_cb` is used to give progress updates on pushes and pulls. There is
no reason for it to pollute the logs by logging its updates as warnings.
Changed these to plain print statements.
This commit is contained in:
Joel Croteau
2024-07-06 22:15:37 -05:00
committed by GitHub
parent f6002fab42
commit e86106b8c2
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
godot-git-plugin/src/git_callbacks.cpp
View File

@@ -10,11 +10,7 @@
extern "C" int progress_cb(const char *str, int len, void *data) {
(void)data;
char *progress_str = new char[len + 1];
std::memcpy(progress_str, str, len);
progress_str[len] = '\0';
godot::UtilityFunctions::push_warning("remote: ", godot::String::utf8(progress_str).strip_edges());
delete[] progress_str;
godot::UtilityFunctions::print("remote: ", godot::String::utf8(str, len).strip_edges());
return 0;
}
@@ -63,7 +59,7 @@ extern "C" int push_transfer_progress_cb(unsigned int current, unsigned int tota
progress = (current * 100) / total;
}
godot::UtilityFunctions::print("Writing Objects: ", uint32_t(progress), "% (", uint32_t(current), "/", uint32_t(total), ", ", uint32_t(bytes), " bytes done.");
godot::UtilityFunctions::print("Writing Objects: ", uint32_t(progress), "% (", uint32_t(current), "/", uint32_t(total), ", ", uint32_t(bytes), " bytes done.)");
return 0;
}