Geoff Lang
19dbaf1121
Mention the SwiftShader -> Chromium autoroller for Wranglers
...
The ANGLE team should make sure that the SwiftShader -> Chromium
autoroller stays green. If it gets too far out of sync, ANGLE's testing
within the ANGLE waterfall and Chromium waterfall will diverge.
Keeping this roller green is also critical for security issues fixes
to propogate to Chrome.
Bug: None
Change-Id: I650d906bbbd8c522b85082965f128a1bf071ae78
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4711827
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-25 16:16:02 +00:00
Brian Sheedy
ec2948c5ed
Start Mac Intel 13.4.1 experiment
...
Bug: chromium:1464635
Change-Id: Ie7cf5d68fff54b0b58ca1a4c102ab8c8368bd3ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4684014
Commit-Queue: Brian Sheedy <bsheedy@chromium.org >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
2023-07-17 22:24:05 +00:00
Yuly Novikov
e8e17211e2
Retry angle_deqp_gles2_metal_tests
...
Flaky crashes in OSXWindow::messageLoop(), like the other GTest based
tests on Mac, which already have retries enabled.
Bug: angleproject:6570
Change-Id: I65ffc4b09a6ece68dcfe404055fcfe50d013c000
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4685573
Auto-Submit: Yuly Novikov <ynovikov@chromium.org >
Reviewed-by: Roman Lavrov <romanl@google.com >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Roman Lavrov <romanl@google.com >
2023-07-17 16:14:42 +00:00
angle-autoroll
a18246ac1a
Roll Chromium from 68d783529187 to 48a8f73f303f (690 revisions)
...
68d7835291..48a8f73f30https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com ,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: 7565823755..a158d61f272bac855313..b98bc2989c6514de5457..9ce3e620bdhttps://chromium.googlesource.com/catapult.git/+log/ {catapult_..394c179782
* third_party/depot_tools: abbd5858fa..b389d031a24786f206b4..c05e52187ef8f7cb6141..5ce938841d86375f9e21..a2303f1c7227e9a92f3b..e10259da24cnorthrop@google.com
Change-Id: I3f305f69842c73569aad368fb3fb7d222c91d231
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4688527
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-07-17 08:13:47 +00:00
Cody Northrop
cdb822e7eb
Revert "Android: Assert that CFI is disabled"
...
This reverts commit 43ef50f389https://reviews.llvm.org/rG92fbb602f3b635110417e40e2f774b31798b0b1d
LLVM Roll:
243d4473a37586aeab..0c545a44https://chromium-review.googlesource.com/c/angle/angle/+/4684008
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Auto-Submit: Cody Northrop <cnorthrop@google.com >
Commit-Queue: Roman Lavrov <romanl@google.com >
Commit-Queue: Cody Northrop <cnorthrop@google.com >
Reviewed-by: Roman Lavrov <romanl@google.com >
2023-07-13 16:55:41 +00:00
Yuxin Hu
759027e852
Enable the new deqp khr test suites on Bot
...
This CL enables the deqp khr test suites added in
https://chromium-review.googlesource.com/c/angle/angle/+/4654841
on below bots:
pixel4 vulkan backend
pixel6 vulkan backend
windows vulkan backend
linux swiftshader backend
linux swiftshader backend tsan
linux swiftshader backend asan
The current linux driver on bot does not support the
new test suites on vulkan backend. We will enable the
test suites on linux vulkan backend after we upgrade the
bot machine driver to a newer version:
https://bugs.chromium.org/p/chromium/issues/detail?id=1271688
Bug: b/286921997
Bug: angleproject:8251
Change-Id: I659424efc09028f685edff076711c9089ec635d4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4673582
Commit-Queue: Yuxin Hu <yuxinhu@google.com >
Reviewed-by: Roman Lavrov <romanl@google.com >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
2023-07-11 17:50:08 +00:00
Yuly Novikov
648f24c92f
Start Mac AMD 13.4.1 experiment
...
Bug: chromium:1462473
Change-Id: Ic30d5f5a0999c10949581aff813febdb83a8cef9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675805
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
Reviewed-by: Brian Sheedy <bsheedy@chromium.org >
2023-07-11 11:41:48 +00:00
angle-autoroll
db6b035713
Manual roll Chromium from 8a1e61637248 to 749d653d9a36 (139 revisions)
...
Manual roll requested by ynovikov@google.com
8a1e616372..749d653d9ahttps://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com ,cnorthrop@google.com ,ynovikov@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* testing: 11876f21fd..24349b4e60https://chromium.googlesource.com/catapult.git/+log/ {catapult_..7d7df42f80
* third_party/turbine: 9rSngS4o9OIlNubLcU1zXF_w0dPYif6AS-_k1pPAV1kC..2I2Nz480QsuCxpQ1lMfbigX8l5HAhX3_ykWU4TKRGo4C
No update to Clang.
Bug: None
Tbr: cnorthrop@google.com ,ynovikov@google.com
Change-Id: I7fd7532722aca9f5a7d7bdd42bf3a0ef92fe95f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675961
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-07-10 17:17:34 +00:00
Yuly Novikov
5527944990
Roll chromium_revision 2e0371f07e..ad19957265 (1162850:1165395)
...
Don't update testing beyond
8e38c8e8a6a5415f3c672e0371f07e..ad199572652e0371f07e..ad19957265e4262406c0..e0690c7c78f089c59d7c..6d00f8d8c5b272a1c128..84fb809dd6b5a43ecdac..f1c687e0aa46c0754180..ac3cb62a5a66a5ea107e..7d4c4bf4732@r25c.cr1 ..R_8suM8m0oHbZ1awdxGXvKEFpAOETscbfZxkkMthyk8C
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ {catapult_..48b31edbfc
* third_party/depot_tools: f0fba1d307..872ac9bd3df81f385906..f999826d2d5c2008090e..39d4cc4ec8053092c268..36a80749cff80577ef22..33899440a1daed2f7981..422351564c2e0371f07e..ad19957265https://chromium-review.googlesource.com/c/angle/angle/+/4660052
Reviewed-by: Ian Elliott <ianelliott@google.com >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
2023-07-04 13:31:46 +00:00
angle-autoroll
bcfc214f91
Roll Chromium from 14fa1a826dad to 2e0371f07e01 (1224 revisions)
...
Manually update third_party/flatbuffers
14fa1a826d..2e0371f07ehttps://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com ,solti@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: 4438010153..e4262406c0ad9b993f2f..f089c59d7c745104ff4a..b272a1c12875c78f8f64..46c07541808f8f07bdce..66a5ea107e3b0115d9f8..4cb10f1315https://chromium.googlesource.com/catapult.git/+log/ {catapult_..1a0894f20f
* third_party/depot_tools: 98d3bb27f0..f0fba1d30713fc75cb6b..28861d1d7d9b4ea9e0d4..5c2008090eff9b9e9ce2..053092c26831a576a999..daed2f7981solti@google.com
Change-Id: I7bf9a5c427845ac28e9cc70051c9b07381313cc9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4649047
Reviewed-by: Solti Ho <solti@google.com >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
2023-07-03 19:05:33 +00:00
Yuly Novikov
f834ba7fda
Switch Linux SwANGLE testing to Ubuntu22.04
...
Turn off experimental builders at the same time.
Bug: chromium:1380082
Change-Id: I1cf5f3efef791819ad01af63197bb931af10e019
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4639183
Reviewed-by: Brian Sheedy <bsheedy@chromium.org >
Auto-Submit: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Brian Sheedy <bsheedy@chromium.org >
2023-06-23 19:12:34 +00:00
Yuly Novikov
74cf0be3fe
Temporarily remove NVIDIA testing from mac-test
...
To facilitate removing macOS 10.14 support while MacBook Pro 2013
machines are being upgraded to a newer OS version.
Bug: chromium:1456549
Change-Id: Ibb3e597d82482c1c86010f94aa4c75cd9bf44995
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4632818
Auto-Submit: Yuly Novikov <ynovikov@chromium.org >
Reviewed-by: Geoff Lang <geofflang@chromium.org >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Geoff Lang <geofflang@chromium.org >
2023-06-21 17:00:06 +00:00
Roman Lavrov
46ff02f8a2
Capture/Replay: Initial setup for angle_capture_tests
...
Implements the first part (FrameCapture) of the proposal
go/frame-capture-and-interpreter-testing
Adds a basic test (CapturedTest) with a few frames. This test gets
captured by capture_tests.py into a temporary directory and the
resulting files are diff'ed with the files under expected/
A diff fails the test. When capture changes, the workflow would be to
run the command indicated by the error message in the test which will
overwrite the files with new ones so that they can be added to the CL.
Example test failure on capture change:
https://chromium-swarm.appspot.com/task?id=62b5f4034527c610
when testing https://crrev.com/c/4598046/3
Tests in CI: https://screenshot.googleplex.com/77o8vZVuj8AbFRj
Also adds a "angle_capture_tests_trace" lib with the trace just to test
that this capture also builds, the lib is not currently loaded by
anything.
Bug: b/286067106
Change-Id: I7d5f6eed088d84f9e3eb8a72b24b1d92515fff38
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4545408
Reviewed-by: Cody Northrop <cnorthrop@google.com >
Commit-Queue: Roman Lavrov <romanl@google.com >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
2023-06-15 22:23:29 +00:00
Roman Lavrov
f102184dd7
Make Test spec JSON generator hashless.
...
Removes scripts/code_generation_hashes/Test_spec_JSON.json
Instead, run codegen in --verify-only mode and compare content.
This run during presubmits and is fast (~0.2s in my tests)
Similar to https://crrev.com/c/4604579
With this, should be able to auto-resolve conflicts in
infra/specs/angle.json
Also testing/buildbot/mixins.pyl
seems to have had hashes routinely updated by autorolls.
Bug: angleproject:8193
Change-Id: Ic1a657dbf464e6f4a8066ea8c5e18297e27a3b4c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4605467
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Auto-Submit: Roman Lavrov <romanl@google.com >
Commit-Queue: Roman Lavrov <romanl@google.com >
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
2023-06-15 15:31:38 +00:00
Yuly Novikov
df787cf049
Add ANGLE experimental SwiftShader builders
...
For testing Ubuntu 22.04
Recipe-side CL http://crrev.com/c/4614428
Testers:
linux-exp-swiftshader
linux-exp-swiftshader-asan
linux-exp-swiftshader-tsan
Builders:
linux-exp-asan-test
linux-exp-tsan-test
Modify LUCI MILO console to show only the active experimental builders.
Bug: chromium:1380082
Change-Id: Iac74b606fca7b1762028cebf4868e691b3ed074c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4614533
Reviewed-by: Roman Lavrov <romanl@google.com >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
Reviewed-by: Brian Sheedy <bsheedy@chromium.org >
2023-06-15 15:16:18 +00:00
Cody Northrop
43ef50f389
Android: Assert that CFI is disabled
...
There appears to be a bug in the interaction of CFI and
relative vtables. On armv9 it results in a crash with SIGILL
when loading traces.
Since we can't overwrite the flags used to control this
just assert that it is correct in GN args.
To avoid the assert, add the following to your GN args:
arm_control_flow_integrity = "none"
Test: Build and run traces on armv9 devices
Bug: b/278955379
Bug: chromium:1441148
Change-Id: I71bf93dca9bd15d6c66ad2a7223d9bbd0c54392e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4602027
Reviewed-by: Roman Lavrov <romanl@google.com >
Commit-Queue: Cody Northrop <cnorthrop@google.com >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
2023-06-12 15:57:27 +00:00
Roman Lavrov
3e4f4caebc
Tests: reduce load on perf bots by collecting less data
...
Collecting this data takes a significant amount of resources but we do
not actively use it at the moment.
Disable --split-shard-samples (will avoid separate calibration on each
shard)
Reduce samples to 6 (from default 10)
Bug: angleproject:7671
Change-Id: I87d45f21badb30ed44de9b9854c94fe7f67ecdc8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4605335
Reviewed-by: Cody Northrop <cnorthrop@google.com >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
2023-06-09 17:21:46 +00:00
Yuly Novikov
9208efb60c
Stop ANGLE Mac Intel 13.3 experiment
...
Bug: chromium:1429033
Change-Id: I2a4cf72d68855c54b87fc33bc6b0c150ad5246ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4549123
Commit-Queue: Roman Lavrov <romanl@google.com >
Auto-Submit: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
Reviewed-by: Roman Lavrov <romanl@google.com >
2023-05-19 17:44:36 +00:00
angle-autoroll
d238e8b97d
Manual roll Chromium from 79f85a216141 to bc320a94824d (1646 revisions)
...
Manual roll requested by ynovikov@google.com
79f85a2161..bc320a9482https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com ,ynovikov@google.com ,yuxinhu@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: 44a4b24b05..36246d88faf2cb09f94e..7454e17b0d129773dde5..55ceecab999d1f44540f..7e91557f2b534624edd1..72efcb2452https://chromium.googlesource.com/catapult.git/+log/ {catapult_..f1f7a299cb
* third_party/depot_tools: a1e578320b..cdefe67b38062d938956..096dcd2735d0e45e54c3..f4fa549a2b25bb7e161f..c278749207yuxinhu@google.com ,ynovikov@google.com
Change-Id: I6d78dc2cd54eac092554bb3792a32561a39f00ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4545305
Reviewed-by: Yuxin Hu <yuxinhu@google.com >
Commit-Queue: Yuxin Hu <yuxinhu@google.com >
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-05-18 18:00:11 +00:00
Yuly Novikov
39ac3fab8d
Start ANGLE Mac Intel 13.3 experiment
...
Bug: chromium:1429033
Change-Id: I8c640004f3255b8c563e172b8bbce9c516437277
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4517830
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
Reviewed-by: Kenneth Russell <kbr@chromium.org >
2023-05-10 18:44:17 +00:00
Yuly Novikov
a7b26adf71
Revert "Retry flaky failures on SwiftShader *SAN builds."
...
This reverts commit f0d2dbec74https://chromium-review.googlesource.com/c/angle/angle/+/3804745
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
> Auto-Submit: Jamie Madill <jmadill@chromium.org >
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Bug: chromium:1275223
Change-Id: I53645f859d7288fb82c258a0540259ae8a9e7138
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4517644
Auto-Submit: Yuly Novikov <ynovikov@chromium.org >
Reviewed-by: Roman Lavrov <romanl@google.com >
Commit-Queue: Roman Lavrov <romanl@google.com >
2023-05-09 19:02:35 +00:00
angle-autoroll
1a847d4a6e
Roll Chromium from 16e9449c3c88 to d08108198321 (723 revisions)
...
16e9449c3c..d081081983https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com ,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: 54bd39c0c5..d609da478edd3595d173..a26ff314e9737446fc52..f8279b010866967963e9..d5e79e117c88bd83fe09..229ff3e2327a97f0e3c4..74258afcd3eec484b5a6..2248225726https://chromium.googlesource.com/catapult.git/+log/ {catapult_..7924448af6
* third_party/depot_tools: 71ab1b77a7..4931c18599dc8628ce87..0377ee52d902f2a2edd4..5b4a9ede47cnorthrop@google.com
Change-Id: I319fdde69f4ff5b854a86f45c70175a2eb03cf77
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4511879
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-05-08 08:25:41 +00:00
angle-autoroll
df8733c91a
Roll Chromium from becaac9672a0 to 16e9449c3c88 (618 revisions)
...
becaac9672..16e9449c3chttps://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com ,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: 1345fb9c5d..54bd39c0c5fe9a4e4107..dd3595d1739460fb138d..737446fc5219470647da..7a97f0e3c4f0c7b47622..f312145c415353fa6142..d8e55758cbhttps://chromium.googlesource.com/catapult.git/+log/ {catapult_..6b573b0676
* third_party/depot_tools: dbcecc9017..71ab1b77a79969814713..448305bbeb295d9239b1..dc8628ce87ce6519bca3..02f2a2edd400ecbd0693..64dd0e593f9969814713..448305bbebcnorthrop@google.com
Change-Id: Ifa152a1d4e8239666c070cf1353efe708938a0e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4508558
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-05-05 10:03:22 +00:00
Roman Lavrov
d4aacb291e
angle_end2end_tests Pixel 6 shards: 4 -> 8
...
There are much more Pixel 6 bots now and even without the current
slowdown we should be running this in more shards.
Bug: angleproject:8150
Change-Id: Id688f27f77dcc4181e21a1d7b2b8c50fd0363278
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4497730
Reviewed-by: Cody Northrop <cnorthrop@google.com >
Auto-Submit: Roman Lavrov <romanl@google.com >
Commit-Queue: Roman Lavrov <romanl@google.com >
Commit-Queue: Cody Northrop <cnorthrop@google.com >
2023-05-02 15:14:56 +00:00
Roman Lavrov
fbf0e02583
Re-enable angle_restricted_trace_gold_interpreted_tests
...
Works again once libangle_trace_interpreter is handled the same way as
other trace libraries.
Bug: b/276742336
Change-Id: Idc55c502c05cabbc38b766823ddfaa92cf2144b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4492537
Reviewed-by: Cody Northrop <cnorthrop@google.com >
Commit-Queue: Roman Lavrov <romanl@google.com >
2023-05-01 19:21:30 +00:00
Roman Lavrov
25d57e4163
Disable angle_restricted_trace_gold_interpreted_tests
...
Blocking Cody's changes to move .so outside of the apk.
Will fix and reland later.
Bug: b/276742336
Change-Id: I726f8ea71db26b29606bb7395d6ca54fba1e7990
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4470388
Reviewed-by: Cody Northrop <cnorthrop@google.com >
Auto-Submit: Roman Lavrov <romanl@google.com >
Commit-Queue: Cody Northrop <cnorthrop@google.com >
2023-04-24 23:52:45 +00:00
Roman Lavrov
f2d1958ef7
Trace Interpreter: disable angle_trace_interpreter_tests on bots
...
Interpreter handles tokens too loosely which makes failures in this
suite hard to understand and debug.
Bug: angleproject:8137
Change-Id: Ibd1ca9de29cf43a819d6fb292a4af6e3c144053a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4455147
Commit-Queue: Roman Lavrov <romanl@google.com >
Auto-Submit: Roman Lavrov <romanl@google.com >
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
2023-04-20 14:13:34 +00:00
Roman Lavrov
25f843f89e
Remove unused angle_trace_tests from isolate
...
We use wrappers instead:
angle_trace_perf_tests
angle_restricted_trace_gold_tests
Bug: b/276474703
Change-Id: I6741f4f1453e6d9321bc6dd59f0ba05f926598e6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4444286
Reviewed-by: Cody Northrop <cnorthrop@google.com >
Auto-Submit: Roman Lavrov <romanl@google.com >
Commit-Queue: Cody Northrop <cnorthrop@google.com >
2023-04-19 01:35:38 +00:00
Roman Lavrov
4e07335654
Trace Interpreter: gzip cpp and run gold tests.
...
New test step:
angle_restricted_trace_gold_interpreted_tests
similar to existing
angle_restricted_trace_gold_tests
but runs a subset of newest traces that have the right format.
Currently there are 8 of them and the filter is hard-coded in
test_suites.pyl. rise_of_empires can also be run interpreted but
happened to flake during testing so it's not included for now.
Trace cpp files are concatenated and gzipped
as a build step producing gen/tracegz_{trace}.gz
and these gz files are then distributed as part of the build
--trace-interpreter flag changes from boolean to string to support:
--trace-interpreter=gz:
* this uses the gz file above
* gold tests added in this CL use this option
--trace-interpreter=c:
* using uncompressed c/cpp file
* existing angle_trace_interpreter_tests runs a retrace
saving .c files and uses this option
Bug: b/276742336
Change-Id: I69544f25bda873af191978195d02ffbdd34363c0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4424690
Reviewed-by: Cody Northrop <cnorthrop@google.com >
Commit-Queue: Roman Lavrov <romanl@google.com >
2023-04-14 22:48:37 +00:00
Yuly Novikov
7b92fa4fd3
Stop running tests on experimental Mac AMD bot
...
Bug: chromium:1382149
Change-Id: Ibcfa4d5e00c6fb5c62409ef801adf8acacc885ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4428870
Reviewed-by: Roman Lavrov <romanl@google.com >
Auto-Submit: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Roman Lavrov <romanl@google.com >
2023-04-14 18:08:46 +00:00
Jamie Madill
735fb48079
Trace Interpreter: Support \\ escape sequences.
...
This enables the 'catalyst_black' trace.
Cloned from https://crrev.com/c/4178022
Bug: b/276742336
Change-Id: I9df703150504e7fcf4e18ff0a538aa3f6caddfdb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4423269
Commit-Queue: Roman Lavrov <romanl@google.com >
Reviewed-by: Cody Northrop <cnorthrop@google.com >
2023-04-13 19:19:21 +00:00
angle-autoroll
32fa13927f
Manual roll Chromium from 902dbf2d8350 to f048076954b4 (61 revisions)
...
Manual roll requested by ynovikov@google.com
902dbf2d83..f048076954https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com ,ynovikov@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* buildtools/third_party/libunwind/trunk: 54cb62e9f8..123963cbd68024c48463..768eecf603https://chromium.googlesource.com/catapult.git/+log/ {catapult_..c5af5d5bf5
No update to Clang.
Bug: None
Tbr: ynovikov@google.com
Change-Id: Ibef7902dc57f9c6d79dccde118ca1441d33f63a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4422932
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-04-13 12:40:10 +00:00
Jamie Madill
f093a9b346
Trace Interpreter: Support gClientArrays
...
Needed to run cut_the_rope, fishdom, other traces.
Add cut_the_rope and fishdom to interpreter CI.
CL cloned from https://crrev.com/c/4178021
Bug: b/276742336
Change-Id: If7da78ba3fd7c19262692d1386c5eaa47df2ca6c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4415246
Reviewed-by: Cody Northrop <cnorthrop@google.com >
Auto-Submit: Roman Lavrov <romanl@google.com >
Commit-Queue: Roman Lavrov <romanl@google.com >
2023-04-11 23:05:59 +00:00
Roman Lavrov
cef7dcbf52
Trace Interpreter: support harry_potter_hogwarts_mystery
...
Handling of calls like:
glGetBooleanv(GL_DEPTH_WRITEMASK, (GLboolean *)gReadBuffer);
glGetFloatv(GL_DEPTH_CLEAR_VALUE, (GLfloat *)gReadBuffer);
Add interpreted test to CI.
Bug: b/276742336
Change-Id: Iae3ff9035044461ca1a208980c170d5d48d1a424
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4416166
Commit-Queue: Roman Lavrov <romanl@google.com >
Reviewed-by: Cody Northrop <cnorthrop@google.com >
2023-04-11 21:46:27 +00:00
angle-autoroll
c8b32849b5
Roll Chromium from 8701b5ed1d64 to 837a7f0f9df1 (574 revisions)
...
8701b5ed1d..837a7f0f9dhttps://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com ,syoussefi@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: c43c0192b6..00bbfdfba064c9f314b8..64174283d0ab37483b42..049d48aa99041196414a..2868dcda2bbe2d6d3f7a..e7cf8e76e3https://chromium.googlesource.com/catapult.git/+log/ {catapult_..fdeb9d47a8
* third_party/depot_tools: bf6e21d9d7..019e73a13b89a6caa12c..26ed9753573d8a315223..66b61ae669syoussefi@google.com
Change-Id: Ie1513ea1fe724f66e4e9b2695c82baa536b178ae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4410571
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-04-10 11:05:22 +00:00
angle-autoroll
c3c41889f4
Roll Chromium from f7c2a70f23b1 to 1393a98c62ae (1678 revisions)
...
f7c2a70f23..1393a98c62https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com ,geofflang@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: 052437a6e1..0cdf15da5bc97a3b8902..76bdd92e1c26ace673c4..6f868b20039643f2cf13..4a9d0560b429a6dda8c6..f3464caa6adf3b0c9f14..5e393c2f70b5b8912f72..20c8ae002d115fe1141d..c17c192772https://chromium.googlesource.com/catapult.git/+log/ {catapult_..fdcbdb2b3e
* third_party/depot_tools: df528a9d7a..0c99af905171a32a2f82..a848535fa404d87bfe25..f686247260993b50afde..eeb51e8ca2892ad5cc94..18e0d7aac4geofflang@google.com
Change-Id: I336b2c934561c9824eab0b97bcdd5278a8831363
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4385566
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-03-31 08:29:21 +00:00
Yuly Novikov
34a06e25df
Start MacBook Pro AMD 2019 experiment on ANGLE bots
...
Suppress failing tests
Bug: chromium:1382149, angleproject:8091
Change-Id: I817d3db8badc35a12ecc9650750ca9190c617f6c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4341695
Commit-Queue: Geoff Lang <geofflang@chromium.org >
Auto-Submit: Yuly Novikov <ynovikov@chromium.org >
Reviewed-by: Geoff Lang <geofflang@chromium.org >
2023-03-23 15:20:59 +00:00
angle-autoroll
0cb0907436
Manual roll Chromium from 4d26ea50cec7 to 52ec1cb28f1b (235 revisions)
...
Manual roll requested by ynovikov@google.com
4d26ea50ce..52ec1cb28fhttps://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com ,romanl@google.com ,ynovikov@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: 984f82d89c..1185a77c82c20dc6aaed..2cdfeaa2d0e136ec5032..3cf0fe4445e943c1ba28..764c1fa4e428c6deacab..6b9c63c69ahttps://chromium.googlesource.com/catapult.git/+log/ {catapult_..2da767c6c1
* third_party/fuchsia-sdk/sdk: version:11.20230307.3.1..version:12.20230308.2.1
* third_party/kotlin_stdlib: Mg7371mEUwDQH4_z29HdWqYWVlXN6t2dXX0kIutg_SwC..zeFlVAEGvnpaj3JJujWHzRlUiBEm4XeeaMQzVsdW6D4C
* tools/clang: 2a70735180..ef1eb208a27ee68c5321..12d39d4fd8romanl@google.com ,ynovikov@google.com
Change-Id: I0d0010c35b9692a3726ccf7871376199b188662d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4321865
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-03-08 20:54:25 +00:00
Yuly Novikov
6e58328d4e
Add Mac AMD experimental bot
...
Bug: chromium:1382149
Change-Id: I4652585abee747d4a9a738a679deefb7ae57f64f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4300871
Auto-Submit: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
Reviewed-by: Roman Lavrov <romanl@google.com >
Commit-Queue: Roman Lavrov <romanl@google.com >
2023-03-01 20:19:48 +00:00
Brian Sheedy
9566011bd7
Add support for permissive pixel comparison
...
Adds support for running ANGLE pixel tests with a more permissive
inexact matching algorithm. This is done by passing in
--use-permissive-pixel-comparison=1 to the test runner.
This is intended to reduce the amount of manual triage work
required on CLs that are expected to have a larger amount of
differences, such as SwiftShader rolls.
On the bots, this will normally be disabled, but will be enabled
if "Use-Permissive-Angle-Pixel-Comparison: True" is present as
a CL footer.
This footer is not yet included automatically anywhere, so
there should be no functional change as a result of this CL yet.
Bug: angleproject:7985
Change-Id: Ie815fac42edb2198dd4d115fc50650504df136c0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4288612
Auto-Submit: Brian Sheedy <bsheedy@chromium.org >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
2023-02-24 10:16:39 +00:00
Yuly Novikov
2678b8307c
Reenable GLES 1.0 conformance tests on Win/Intel
...
Hopefully blue screen and timeouts are fixed by the new driver.
Bug: angleproject:7750
Change-Id: Ic84f3080aeac689fa04f4fc8fc2f7f9c582abc10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4286568
Auto-Submit: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
2023-02-23 19:43:25 +00:00
Jamie Madill
e960355a9a
Trace Interpreter: Support DOTA underlords.
...
Supports zero pointer parameters, which are used to indicate
unwritten parameters.
Bug: angleproject:7887
Change-Id: Ibee1d558567020eeeeb2ed6ac98f38cf985d87a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4140259
Reviewed-by: Cody Northrop <cnorthrop@google.com >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2023-01-19 16:04:58 +00:00
Jamie Madill
2c4de3a744
Trace Interpreter: Support Genshin Impact.
...
Includes a couple fixes:
- parsing hexidecimal values instead of enums
- support sharing strings and functions between modules
- support 32-bit int pointers
Bug: angleproject:7887
Change-Id: I6e20a64a862c45c17ccde78a58d6069d83b31867
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4135797
Commit-Queue: Jamie Madill <jmadill@chromium.org >
Reviewed-by: Cody Northrop <cnorthrop@google.com >
2023-01-19 16:00:03 +00:00
Jamie Madill
2c582dcb7b
Trace Interpreter: Support Manhattan trace.
...
Adds the following fixes and features:
- support transform feedback varying strings
- support infinity and NaN constants
- support for sampler and query resources
Bug: angleproject:7887
Change-Id: Ib01afe66e4fda9bc77d0cb5eed52fa83a694a7d6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4126885
Reviewed-by: Cody Northrop <cnorthrop@google.com >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2023-01-19 15:52:21 +00:00
Jamie Madill
f7b5d5d1e0
Capture/Replay: Remove inline variable declarations.
...
This makes parsing easier for the "simplified C" interpreter.
We introduce a resource ID buffer as a way to manage a list
of resource IDs to replace the inline resource lists.
Turns on the Among Us trace in the interpreter tests.
Bug: angleproject:7775
Change-Id: I1bb9c0e9b087965a18691bc99b2e9947610b9eaf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4128719
Reviewed-by: Cody Northrop <cnorthrop@google.com >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2023-01-19 15:42:09 +00:00
Jamie Madill
f609d294f9
Infra: Re-enable TSAN on CV.
...
The flakiness in this config is mitigated by retries now.
Putting it on CV should help prevent the regressions that
happen often in this config.
Bug: angleproject:7944
Change-Id: Ie9d5443bda2031785a5c3d81fb45986272da8b58
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4162558
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2023-01-12 19:38:17 +00:00
Roman Lavrov
4403abc0d4
Enable merge script failure detection
...
chromium_swarming.expose_merge_script_failures
https://crbug.com/1346781#c96
Bug:chromium:1346781
Change-Id: I33c7fcbaa286f4c0401a16c0a03635054c7330f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4144179
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Roman Lavrov <romanl@google.com >
2023-01-09 15:27:56 +00:00
Yuly Novikov
e7ded5d951
Add ANGLE Pixel 6 CQ and Perf bots
...
Keeping the experimental bot to test adding GLES backend tests.
Bug: angleproject:6819
Change-Id: I869fc3fe29964756d0231b0a6fc51aa7774963f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4143159
Reviewed-by: Roman Lavrov <romanl@google.com >
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
2023-01-06 15:22:47 +00:00
Yuly Novikov
f2290d80cf
Re-enable tests on win10-x64-intel-perf
...
Bot was switched to new GPU and driver in crrev.com/c/4133266,
so hopefully BSOD issue is fixed.
Bug: angleproject:6332
Change-Id: I4b7d5ab6b8dc559f75b487a85ec453876ac13932
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4133267
Commit-Queue: Jamie Madill <jmadill@chromium.org >
Auto-Submit: Yuly Novikov <ynovikov@chromium.org >
Reviewed-by: Jamie Madill <jmadill@chromium.org >
2023-01-04 17:55:22 +00:00
Yuly Novikov
6382dd74de
Switch Win Intel to Optiplex 7080 by rolling Chromium
...
Optiplex 7050 had HD 630 GPU PCI ID 8086:5912.
Optiplex 7060 had UHD 630 GPU PCI ID 8086:3e92.
Optiplex 7080 has UHD 630 GPU PCI ID 8086:9bc5.
Also upgrading the driver from 26.20.100.8141 to 31.0.101.2111.
And the Windows 10 version from 1909 to 21H1.
Re-enable angle_restricted_trace_gold_tests on Intel,
since they looked stable on the experimental bot.
Stop running tests on the experimental win10-x64-exp-intel.
Roll chromium_revision 87b7ed3032..9b6c0a64c3 (1088609:1088686)
Change log:
87b7ed3032..9b6c0a64c387b7ed3032..9b6c0a64c39c112b5654..c5a91cd488https://chromium.googlesource.com/catapult.git/+log/ {catapult_..a404e6d108
* tools/mb:
eb0a826405..2c8d8028037e2765e6fa..0f2155f84587b7ed3032..9b6c0a64c3https://chromium-review.googlesource.com/c/angle/angle/+/4133266
Auto-Submit: Yuly Novikov <ynovikov@chromium.org >
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2023-01-04 16:29:34 +00:00
