godotengine/godot-angle-static
1
0
Fork 0
mirror of https://github.com/godotengine/godot-angle-static.git synced 2026-01-03 14:09:33 +03:00
Code Issues Packages Projects Releases Wiki Activity

Mark more TraceFunctions methods as pure virtual

Browse Source 
Otherwise there's expected to be an implementation of them,
causing breakages like

    ld.lld: error: undefined symbol: typeinfo for angle::TraceFunctions

Change-Id: Ieda87db9983a08c139ce7cf2ad962d33c1eeeac2
Bug: chromium:1453674
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4799335
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Auto-Submit: Arthur Eubanks <aeubanks@google.com>
Commit-Queue: Arthur Eubanks <aeubanks@google.com>
This commit is contained in:
Arthur Eubanks
2023-08-21 13:17:21 -07:00
committed by Angle LUCI CQ
parent 8f5a61243e
commit 30c9bd21cc
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
util/capture/trace_interface.h
View File

@@ -62,10 +62,10 @@ struct TraceFunctions
virtual void ResetReplay() = 0;
virtual void FinishReplay() = 0;
virtual void SetBinaryDataDir(const char *dataDir) = 0;
virtual void SetReplayResourceMode(const ReplayResourceMode resourceMode);
virtual void SetTraceGzPath(const std::string &traceGzPath);
virtual void SetTraceInfo(const TraceInfo &traceInfo);
virtual void SetBinaryDataDir(const char *dataDir) = 0;
virtual void SetReplayResourceMode(const ReplayResourceMode resourceMode) = 0;
virtual void SetTraceGzPath(const std::string &traceGzPath) = 0;
virtual void SetTraceInfo(const TraceInfo &traceInfo) = 0;
virtual ~TraceFunctions() {}
};