celisej567/Nuake
1
0
Fork 0
mirror of https://github.com/antopilo/Nuake.git synced 2026-09-21 20:08:40 +03:00
Code Issues Packages Projects Releases Wiki Activity

Reimplemented scene editor window caching to fix crash when closing one during iteration

Browse Source
This commit is contained in:
antopilo
2025-02-02 10:31:08 -05:00
parent bb7d7aafbc
commit 21647c27cf
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Editor/Source/Editor/Windows/EditorInterface.cpp
View File

@@ -2787,8 +2787,9 @@ namespace Nuake {
SceneEditorDockspaceNodeID = ImGui::DockBuilderAddNode(dockspaceId, ImGuiDockNodeFlags_DockSpace);
}
// We need to cache, because we might delete one while iterating
for (auto& sceneEditor : sceneEditors)
// We need to make a copy, because we might delete one while iterating
std::vector<Ref<SceneEditorWindow>> cachedEditors = sceneEditors;
for (auto& sceneEditor : cachedEditors)
{
sceneEditor->Draw();
}