godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2026-01-03 18:11:19 +03:00
Code Issues Packages Projects Releases Wiki Activity

Web: Clarify that OS.get_unique_id is not supported

Browse Source 
Remove the base error message in `OS`, we no longer really error out this
way for not implemented methods. Instead, each platform should override them
to provide the context they want.

Fixes #82439.

(cherry picked from commit 0a10f09ce4)
This commit is contained in:
Rémi Verschelde
2023-09-27 15:17:02 +02:00
parent 574a5e59f3
commit f706a3bd54
4 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
platform/javascript/os_javascript.cpp
View File

@@ -1005,6 +1005,10 @@ int OS_JavaScript::get_processor_count() const {
return godot_js_os_hw_concurrency_get();
}
String OS_JavaScript::get_unique_id() const {
ERR_FAIL_V_MSG("", "OS::get_unique_id() is not available on the HTML5 platform.");
}
bool OS_JavaScript::_check_internal_feature_support(const String &p_feature) {
if (p_feature == "HTML5" || p_feature == "web") {
return true;

1
platform/javascript/os_javascript.h
View File

@@ -194,6 +194,7 @@ public:
virtual int get_process_id() const;
bool is_process_running(const ProcessID &p_pid) const;
int get_processor_count() const;
String get_unique_id() const;
virtual void alert(const String &p_alert, const String &p_title = "ALERT!");
virtual void set_window_title(const String &p_title);