godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2026-01-03 18:11:19 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix MIDI note-on events being converted to note-off events

Browse Source 
Update documentation with note about MIDI velocity interpretation
This commit is contained in:
voidshine
2022-09-17 11:29:41 -07:00
committed by voidshine
parent 4ab3fdcda0
commit f0f72b3132
2 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/os/midi_driver.cpp
View File

@@ -86,11 +86,6 @@ void MIDIDriver::receive_input_packet(uint64_t timestamp, uint8_t *data, uint32_
if (length >= 2 + param_position) {
event->set_pitch(data[param_position]);
event->set_velocity(data[param_position + 1]);
if (event->get_message() == MIDIMessage::NOTE_ON && event->get_velocity() == 0) {
// https://www.midi.org/forum/228-writing-midi-software-send-note-off,-or-zero-velocity-note-on
event->set_message(MIDIMessage::NOTE_OFF);
}
}
break;