godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2026-01-03 18:11:19 +03:00
Code Issues Packages Projects Releases Wiki Activity

Revert "GDScript: Add warnings that are set to error by default"

Browse Source 
This reverts commit a166833bfa.

This caused multiple regressions.
Needs to be redone with more testing before merge.

Fixes #72501.
This commit is contained in:
Rémi Verschelde
2023-02-01 10:54:22 +01:00
parent f7397a5ac6
commit afe3b94ab2
18 changed files with 57 additions and 313 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
modules/gdscript/tests/scripts/analyzer/warnings/get_node_without_onready.gd
View File

@@ -1,15 +0,0 @@
extends Node
var add_node = do_add_node() # Hack to have one node on init and not fail at runtime.
var shorthand = $Node
var with_self = self.get_node("Node")
var without_self = get_node("Node")
func test():
print("warn")
func do_add_node():
var node = Node.new()
node.name = "Node"
add_child(node)

14
modules/gdscript/tests/scripts/analyzer/warnings/get_node_without_onready.out
View File

@@ -1,14 +0,0 @@
GDTEST_OK
>> WARNING
>> Line: 5
>> GET_NODE_DEFAULT_WITHOUT_ONREADY
>> The default value is using "$" which won't return nodes in the scene tree before "_ready()" is called. Use the "@onready" annotation to solve this.
>> WARNING
>> Line: 6
>> GET_NODE_DEFAULT_WITHOUT_ONREADY
>> The default value is using "get_node()" which won't return nodes in the scene tree before "_ready()" is called. Use the "@onready" annotation to solve this.
>> WARNING
>> Line: 7
>> GET_NODE_DEFAULT_WITHOUT_ONREADY
>> The default value is using "get_node()" which won't return nodes in the scene tree before "_ready()" is called. Use the "@onready" annotation to solve this.
warn

6
modules/gdscript/tests/scripts/analyzer/warnings/inference_with_variant.gd
View File

@@ -1,6 +0,0 @@
func test():
var inferred_with_variant := return_variant()
print(inferred_with_variant)
func return_variant() -> Variant:
return "warn"

6
modules/gdscript/tests/scripts/analyzer/warnings/inference_with_variant.out
View File

@@ -1,6 +0,0 @@
GDTEST_OK
>> WARNING
>> Line: 2
>> INFERENCE_ON_VARIANT
>> The variable type is being inferred from a Variant value, so it will be typed as Variant.
warn

6
modules/gdscript/tests/scripts/analyzer/warnings/onready_with_export.gd
View File

@@ -1,6 +0,0 @@
extends Node
@onready @export var conflict = ""
func test():
print("warn")

6
modules/gdscript/tests/scripts/analyzer/warnings/onready_with_export.out
View File

@@ -1,6 +0,0 @@
GDTEST_OK
>> WARNING
>> Line: 3
>> ONREADY_WITH_EXPORT
>> The "@onready" annotation will make the default value to be set after the "@export" takes effect and will override it.
warn

5
modules/gdscript/tests/scripts/analyzer/warnings/overriding_native_method.gd
View File

@@ -1,5 +0,0 @@
func test():
print("warn")
func get(_property: StringName) -> Variant:
return null

6
modules/gdscript/tests/scripts/analyzer/warnings/overriding_native_method.out
View File

@@ -1,6 +0,0 @@
GDTEST_OK
>> WARNING
>> Line: 4
>> NATIVE_METHOD_OVERRIDE
>> The method "get" overrides a method from native class "Object". This won't be called by the engine and may not work as expected.
warn