godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2026-01-03 18:11:19 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #76560 from aaronfranke/node-set-string-name

Browse Source 
Change Node `set_name` to use StringName, slightly improves performance
This commit is contained in:
Thaddeus Crews
2025-05-02 09:25:25 -05:00
parent bec3856cec a404b668a1
commit acf38b2292
6 changed files with 69 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/core/object/test_class_db.h
View File

@@ -359,11 +359,7 @@ void validate_property(const Context &p_context, const ExposedClass &p_class, co
if (getter && setter) {
const ArgumentData &setter_first_arg = setter->arguments.back()->get();
if (getter->return_type.name != setter_first_arg.type.name) {
// Special case for Node::set_name
bool whitelisted = getter->return_type.name == p_context.names_cache.string_name_type &&
setter_first_arg.type.name == p_context.names_cache.string_type;
TEST_FAIL_COND(!whitelisted,
TEST_FAIL(
"Return type from getter doesn't match first argument of setter, for property: '", p_class.name, ".", String(p_prop.name), "'.");
}
}