godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2026-01-03 18:11:19 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix error spam when adding tabs to TabBar without deselect

Browse Source 
`current` was allowed to be `-1` when deselection was disabled, causing
errors in other methods when updating the size.
This commit is contained in:
A Thousand Ships
2024-02-18 14:15:13 +01:00
parent b8f106acb2
commit a56c03d495
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
scene/gui/tab_bar.cpp
View File

@@ -627,6 +627,10 @@ void TabBar::set_tab_count(int p_count) {
offset = MIN(offset, p_count - 1);
max_drawn_tab = MIN(max_drawn_tab, p_count - 1);
current = MIN(current, p_count - 1);
// Fix range if unable to deselect.
if (current == -1 && !_can_deselect()) {
current = 0;
}
_update_cache();
_ensure_no_over_offset();
@@ -1557,10 +1561,7 @@ bool TabBar::_can_deselect() const {
}
void TabBar::ensure_tab_visible(int p_idx) {
if (!is_inside_tree() || !buttons_visible) {
return;
}
if (p_idx == -1 && _can_deselect()) {
if (p_idx == -1 || !is_inside_tree() || !buttons_visible) {
return;
}
ERR_FAIL_INDEX(p_idx, tabs.size());