godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2026-01-03 18:11:19 +03:00
Code Issues Packages Projects Releases Wiki Activity

Reduce String CoW

Browse Source 
By introducing an intermediate proxy class for the array subscript
operator for String and CharString we can control better when CowData
will actually CoW.

This should improve performance of String usage for most cases.
This commit is contained in:
Hein-Pieter van Braam
2018-12-16 00:44:18 +00:00
parent 7ac67bfec1
commit 4e25e5066b
8 changed files with 44 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
core/ustring.cpp
View File

@@ -179,7 +179,7 @@ void String::copy_from_unchecked(const CharType *p_char, const int p_length) {
resize(p_length + 1);
set(p_length, 0);
CharType *dst = &operator[](0);
CharType *dst = ptrw();
for (int i = 0; i < p_length; i++) {
dst[i] = p_char[i];
@@ -250,7 +250,7 @@ String &String::operator+=(const String &p_str) {
resize(length() + p_str.size());
const CharType *src = p_str.c_str();
CharType *dst = &operator[](0);
CharType *dst = ptrw();
set(length(), 0);
@@ -289,7 +289,7 @@ String &String::operator+=(const char *p_str) {
resize(from + src_len + 1);
CharType *dst = &operator[](0);
CharType *dst = ptrw();
set(length(), 0);
@@ -1431,7 +1431,7 @@ bool String::parse_utf8(const char *p_utf8, int p_len) {
}
resize(str_size + 1);
CharType *dst = &operator[](0);
CharType *dst = ptrw();
dst[str_size] = 0;
while (cstr_size) {
@@ -3476,7 +3476,7 @@ String String::xml_unescape() const {
if (len == 0)
return String();
str.resize(len + 1);
_xml_unescape(c_str(), l, &str[0]);
_xml_unescape(c_str(), l, str.ptrw());
str[len] = 0;
return str;
}