godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2026-01-06 10:11:57 +03:00
Code Issues Packages Projects Releases Wiki Activity

Initial fix for double caret inserting in NodePath

Browse Source 
Additional cases where prepending doubles up

Moved code to helper function

Added unit tests

Lookup caret character instead of passing position

Switched to using the parsed type

Adding safety checks and various cleanup
This commit is contained in:
Logan Apple
2025-06-22 12:04:09 -07:00
committed by Logan Apple
parent 48f361a6eb
commit 216c462277
5 changed files with 104 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
modules/gdscript/tests/scripts/completion/argument_options/string_literals/add_node_path_tween_prepended.cfg Normal file
View File

@@ -0,0 +1,11 @@
[input]
add_node_path_literals=true
[output]
include=[
{"insert_text": "\"property_of_a\""},
{"insert_text": "\"name\""},
]
exclude=[
{"insert_text": "^\"property_of_a\""},
{"insert_text": "^\"name\""},
]

8
modules/gdscript/tests/scripts/completion/argument_options/string_literals/add_node_path_tween_prepended.gd Normal file
View File

@@ -0,0 +1,8 @@
extends Node
const A = preload("res://completion/class_a.notest.gd")
func _ready() -> void:
var a := A.new()
var tween := get_tree().create_tween()
tween.tween_property(a, ^"➡")

9
modules/gdscript/tests/scripts/completion/argument_options/string_literals/add_string_name_input_event_prepended.cfg Normal file
View File

@@ -0,0 +1,9 @@
[input]
add_string_name_literals=true
[output]
include=[
{"insert_text": "\"test_input_action\""},
]
exclude=[
{"insert_text": "&\"test_input_action\""},
]

3
modules/gdscript/tests/scripts/completion/argument_options/string_literals/add_string_name_input_event_prepended.gd Normal file
View File

@@ -0,0 +1,3 @@
func _input(event: InputEvent) -> void:
event.is_action_pressed(&"➡")
pass