mirror of
https://github.com/godotengine/godot.git
synced 2026-01-05 06:11:29 +03:00
Style: Enforce separation line between function definitions
I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
This commit is contained in:
@@ -92,6 +92,7 @@ bool GraphNode::_get(const StringName &p_name, Variant &r_ret) const {
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
void GraphNode::_get_property_list(List<PropertyInfo> *p_list) const {
|
||||
int idx = 0;
|
||||
for (int i = 0; i < get_child_count(); i++) {
|
||||
@@ -305,11 +306,13 @@ void GraphNode::clear_slot(int p_idx) {
|
||||
update();
|
||||
connpos_dirty = true;
|
||||
}
|
||||
|
||||
void GraphNode::clear_all_slots() {
|
||||
slot_info.clear();
|
||||
update();
|
||||
connpos_dirty = true;
|
||||
}
|
||||
|
||||
bool GraphNode::is_slot_enabled_left(int p_idx) const {
|
||||
if (!slot_info.has(p_idx))
|
||||
return false;
|
||||
@@ -428,6 +431,7 @@ void GraphNode::set_show_close_button(bool p_enable) {
|
||||
show_close = p_enable;
|
||||
update();
|
||||
}
|
||||
|
||||
bool GraphNode::is_close_button_visible() const {
|
||||
return show_close;
|
||||
}
|
||||
@@ -487,6 +491,7 @@ int GraphNode::get_connection_input_count() {
|
||||
|
||||
return conn_input_cache.size();
|
||||
}
|
||||
|
||||
int GraphNode::get_connection_output_count() {
|
||||
if (connpos_dirty)
|
||||
_connpos_update();
|
||||
|
||||
Reference in New Issue
Block a user