mirror of
https://github.com/godotengine/godot-visual-script.git
synced 2025-12-31 21:48:42 +03:00
9a4df15d3e
We've made several updates to improve our codebase and application performance. - Clang format was applied for better readability and consistency, aiding other developers in understanding and contributing to the code. - We resolved issues that were causing visual script compilation failure. The visual script now compiles successfully, ensuring application functionality. - Broken sections within the codebase were fixed, improving overall stability. - Built-in functions from the visual script were removed to simplify the code and enhance readability. - Generic search performance was improved to provide faster results, enhancing user experience. - Missing flow nodes were added to the Visual Script, ensuring all necessary components are present for correct functioning. In an effort to streamline the codebase: - `VisualScriptComment` class and related code were removed, reducing complexity and improving maintainability. - Error messages were optimized for quicker feedback when errors occur. - Licenses were updated to reflect recent changes, ensuring legal compliance and project transparency. - The `get_global_name()` override in `visual_script.h` was fixed, and `TYPE_BUILTIN_FUNC` in `visual_script_expression.h` was removed, improving code functionality. - Search logic was refactored to avoid double searching, enhancing performance. - Documentation was updated to reflect recent changes, providing accurate information to users and developers. - Property selection logic in `VisualScriptPropertySelector` was refactored for easier understanding and modification. - Code was refactored to avoid variable shadowing, improving readability and reducing potential errors. - `.clang-format` and `.clang-tidy` configuration files were added to ensure consistent code styling. To make the code more robust and easier to understand: - Variable names were corrected for clarity, and error handling in `visual_script_expression.cpp` was improved. - Function and variable names were refactored for better readability and maintainability. - Member editing logic in `VisualScriptEditor` was simplified. - Name variables were updated to be unique, avoiding potential conflicts and errors. - The `VisualScriptSubCall` class was refactored for simplicity and ease of understanding. For macOS workflow: - It was updated to use the latest version and correct path for installing Vulkan SDK, enabling the application to leverage the latest features and improvements from the Vulkan SDK. - Mac Vulkan SDK was installed to support Vulkan-based functionalities. Lastly, we made necessary changes to pass CI/CD tests, ensuring the code quality and stability of the application.
71 lines
2.3 KiB
Bash
71 lines
2.3 KiB
Bash
#!/usr/bin/env bash
|
|
|
|
# This script ensures proper POSIX text file formatting and a few other things.
|
|
# This is supplementary to clang_format.sh, but should be run before it.
|
|
|
|
# We need dos2unix and recode.
|
|
if [ ! -x "$(command -v dos2unix)" -o ! -x "$(command -v recode)" ]; then
|
|
printf "Install 'dos2unix' and 'recode' to use this script.\n"
|
|
fi
|
|
|
|
set -uo pipefail
|
|
IFS=$'\n\t'
|
|
|
|
# Loops through all text files tracked by Git.
|
|
git grep -zIl '' |
|
|
while IFS= read -rd '' f; do
|
|
# Exclude 3rd party files
|
|
if [[ "$f" == "glad"* ]]; then
|
|
continue
|
|
elif [[ "$f" == "godot-cpp"* ]]; then
|
|
continue
|
|
elif [[ "$f" == "thirdparty"* ]]; then
|
|
continue
|
|
elif [[ "$f" == "gradle"* ]]; then
|
|
continue
|
|
elif [[ "$f" == "build"* ]]; then
|
|
continue
|
|
elif [[ "$f" == "android"* ]]; then
|
|
continue
|
|
elif [[ "$f" == "api.json" ]]; then
|
|
continue
|
|
fi
|
|
# Ensure that files are UTF-8 formatted.
|
|
recode UTF-8 "$f" 2> /dev/null
|
|
# Ensure that files have LF line endings and do not contain a BOM.
|
|
dos2unix "$f" 2> /dev/null
|
|
# Remove trailing space characters and ensures that files end
|
|
# with newline characters. -l option handles newlines conveniently.
|
|
perl -i -ple 's/\s*$//g' "$f"
|
|
# Remove the character sequence "== true" if it has a leading space.
|
|
perl -i -pe 's/\x20== true//g' "$f"
|
|
# We don't want to change lines around braces in godot/tscn files.
|
|
if [[ "$f" == *"godot" ]]; then
|
|
continue
|
|
elif [[ "$f" == *"tscn" ]]; then
|
|
continue
|
|
fi
|
|
# Disallow empty lines after the opening brace.
|
|
perl -i -0777 -pe 's/\x7B\x0A\x0A/\x7B\x0A/g' "$f"
|
|
# Disallow some empty lines before the closing brace.
|
|
perl -i -0777 -pe 's/\x0A\x0A\x7D/\x0A\x7D/g' "$f"
|
|
done
|
|
|
|
git diff > patch.patch
|
|
|
|
# If no patch has been generated all is OK, clean up, and exit.
|
|
if [ ! -s patch.patch ] ; then
|
|
printf "Files in this commit comply with the formatting rules.\n"
|
|
rm -f patch.patch
|
|
exit 0
|
|
fi
|
|
|
|
# A patch has been created, notify the user, clean up, and exit.
|
|
printf "\n*** The following differences were found between the code "
|
|
printf "and the formatting rules:\n\n"
|
|
cat patch.patch
|
|
printf "\n*** Aborting, please fix your commit(s) with 'git commit --amend' or 'git rebase -i <hash>'\n"
|
|
rm -f patch.patch
|
|
|
|
exit 1
|