godotengine/godot-visual-script
1
0
Fork 0
mirror of https://github.com/godotengine/godot-visual-script.git synced 2026-01-04 18:10:07 +03:00
Code Issues Packages Projects Releases Wiki Activity

Rename remove() to remove_at() when removing by index

Browse Source
This commit is contained in:
Lightning_A
2021-07-03 16:17:03 -06:00
committed by Aaron Record
parent df1fcaf100
commit cb47e7f319
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
visual_script.cpp
View File

@@ -661,7 +661,7 @@ void VisualScript::custom_signal_remove_argument(const StringName &p_func, int p
ERR_FAIL_COND(instances.size()); ERR_FAIL_COND(instances.size());
ERR_FAIL_COND(!custom_signals.has(p_func)); ERR_FAIL_COND(!custom_signals.has(p_func));
ERR_FAIL_INDEX(p_argidx, custom_signals[p_func].size()); ERR_FAIL_INDEX(p_argidx, custom_signals[p_func].size());
custom_signals[p_func].remove(p_argidx); custom_signals[p_func].remove_at(p_argidx);
} }
int VisualScript::custom_signal_get_argument_count(const StringName &p_func) const { int VisualScript::custom_signal_get_argument_count(const StringName &p_func) const {

6
visual_script_expression.cpp
View File

@@ -1190,7 +1190,7 @@ VisualScriptExpression::ENode *VisualScriptExpression::_parse_expression() {
op->nodes[1] = nullptr; op->nodes[1] = nullptr;
expression.write[i].is_op = false; expression.write[i].is_op = false;
expression.write[i].node = op; expression.write[i].node = op;
expression.remove(i + 1); expression.remove_at(i + 1);
} }
} else { } else {
@@ -1222,8 +1222,8 @@ VisualScriptExpression::ENode *VisualScriptExpression::_parse_expression() {
//replace all 3 nodes by this operator and make it an expression //replace all 3 nodes by this operator and make it an expression
expression.write[next_op - 1].node = op; expression.write[next_op - 1].node = op;
expression.remove(next_op); expression.remove_at(next_op);
expression.remove(next_op); expression.remove_at(next_op);
} }
} }

6
visual_script_nodes.cpp
View File

@@ -253,7 +253,7 @@ String VisualScriptFunction::get_argument_name(int p_argidx) const {
void VisualScriptFunction::remove_argument(int p_argidx) { void VisualScriptFunction::remove_argument(int p_argidx) {
ERR_FAIL_INDEX(p_argidx, arguments.size()); ERR_FAIL_INDEX(p_argidx, arguments.size());
arguments.remove(p_argidx); arguments.remove_at(p_argidx);
ports_changed_notify(); ports_changed_notify();
} }
@@ -623,7 +623,7 @@ void VisualScriptLists::remove_input_data_port(int p_argidx) {
ERR_FAIL_INDEX(p_argidx, inputports.size()); ERR_FAIL_INDEX(p_argidx, inputports.size());
inputports.remove(p_argidx); inputports.remove_at(p_argidx);
ports_changed_notify(); ports_changed_notify();
notify_property_list_changed(); notify_property_list_changed();
@@ -679,7 +679,7 @@ void VisualScriptLists::remove_output_data_port(int p_argidx) {
ERR_FAIL_INDEX(p_argidx, outputports.size()); ERR_FAIL_INDEX(p_argidx, outputports.size());
outputports.remove(p_argidx); outputports.remove_at(p_argidx);
ports_changed_notify(); ports_changed_notify();
notify_property_list_changed(); notify_property_list_changed();