diff --git a/editor/visual_script_property_selector.cpp b/editor/visual_script_property_selector.cpp index d79b01b..4dc2445 100644 --- a/editor/visual_script_property_selector.cpp +++ b/editor/visual_script_property_selector.cpp @@ -42,39 +42,25 @@ #include "editor/editor_node.h" #include "editor/editor_scale.h" #include "editor/editor_settings.h" -#include "editor/visual_script_property_selector.h" #include "scene/main/node.h" #include "scene/main/window.h" void VisualScriptPropertySelector::_update_icons() { - search_box->set_right_icon( - results_tree->get_theme_icon(SNAME("Search"), SNAME("EditorIcons"))); + search_box->set_right_icon(results_tree->get_theme_icon(SNAME("Search"), SNAME("EditorIcons"))); search_box->set_clear_button_enabled(true); - search_box->add_theme_icon_override( - "right_icon", - results_tree->get_theme_icon(SNAME("Search"), SNAME("EditorIcons"))); + search_box->add_theme_icon_override("right_icon", results_tree->get_theme_icon(SNAME("Search"), SNAME("EditorIcons"))); - search_visual_script_nodes->set_icon(results_tree->get_theme_icon( - SNAME("VisualScript"), SNAME("EditorIcons"))); - search_classes->set_icon( - results_tree->get_theme_icon(SNAME("Object"), SNAME("EditorIcons"))); - search_methods->set_icon(results_tree->get_theme_icon(SNAME("MemberMethod"), - SNAME("EditorIcons"))); - search_operators->set_icon( - results_tree->get_theme_icon(SNAME("Add"), SNAME("EditorIcons"))); - search_signals->set_icon(results_tree->get_theme_icon(SNAME("MemberSignal"), - SNAME("EditorIcons"))); - search_constants->set_icon(results_tree->get_theme_icon( - SNAME("MemberConstant"), SNAME("EditorIcons"))); - search_properties->set_icon(results_tree->get_theme_icon( - SNAME("MemberProperty"), SNAME("EditorIcons"))); - search_theme_items->set_icon( - results_tree->get_theme_icon(SNAME("MemberTheme"), SNAME("EditorIcons"))); + search_visual_script_nodes->set_icon(results_tree->get_theme_icon(SNAME("VisualScript"), SNAME("EditorIcons"))); + search_classes->set_icon(results_tree->get_theme_icon(SNAME("Object"), SNAME("EditorIcons"))); + search_methods->set_icon(results_tree->get_theme_icon(SNAME("MemberMethod"), SNAME("EditorIcons"))); + search_operators->set_icon(results_tree->get_theme_icon(SNAME("Add"), SNAME("EditorIcons"))); + search_signals->set_icon(results_tree->get_theme_icon(SNAME("MemberSignal"), SNAME("EditorIcons"))); + search_constants->set_icon(results_tree->get_theme_icon(SNAME("MemberConstant"), SNAME("EditorIcons"))); + search_properties->set_icon(results_tree->get_theme_icon(SNAME("MemberProperty"), SNAME("EditorIcons"))); + search_theme_items->set_icon(results_tree->get_theme_icon(SNAME("MemberTheme"), SNAME("EditorIcons"))); - case_sensitive_button->set_icon( - results_tree->get_theme_icon(SNAME("MatchCase"), SNAME("EditorIcons"))); - hierarchy_button->set_icon( - results_tree->get_theme_icon(SNAME("ClassList"), SNAME("EditorIcons"))); + case_sensitive_button->set_icon(results_tree->get_theme_icon(SNAME("MatchCase"), SNAME("EditorIcons"))); + hierarchy_button->set_icon(results_tree->get_theme_icon(SNAME("ClassList"), SNAME("EditorIcons"))); } void VisualScriptPropertySelector::_sbox_input(const Ref &p_ie) { @@ -114,89 +100,6 @@ void VisualScriptPropertySelector::_update_results() { _update_icons(); search_runner = Ref(memnew(SearchRunner(this, results_tree))); set_process(true); - - TreeItem *root = results_tree->create_item(); - - if (search_classes->is_pressed()) { - List class_list; - ClassDB::get_class_list(&class_list); - - for (const StringName &class_name : class_list) { - if (search_box->get_text().findn(String(class_name)) == -1) { - continue; - } - - TreeItem *item = results_tree->create_item(root); - item->set_text(0, String(class_name)); - item->set_icon( - 0, EditorNode::get_singleton()->get_class_icon(class_name, "Object")); - item->set_metadata(0, "class:" + String(class_name)); - } - } - - if (search_methods->is_pressed()) { - List class_list; - ClassDB::get_class_list(&class_list); - - for (const StringName &class_name : class_list) { - List method_list; - ClassDB::get_method_list(class_name, &method_list, true); - - for (const MethodInfo &method_info : method_list) { - if (method_info.name.findn(search_box->get_text()) == -1 && - (method_info.flags & METHOD_FLAG_VIRTUAL) != 0) { - continue; - } - - TreeItem *item = results_tree->create_item(root); - item->set_text(0, String(class_name) + "::" + method_info.name); - item->set_icon(0, EditorNode::get_singleton()->get_class_icon(class_name, "Object")); - item->set_metadata(0, "method:" + String(class_name) + "::" + method_info.name); - } - } - } - - if (search_properties->is_pressed()) { - List class_list; - ClassDB::get_class_list(&class_list); - - for (const StringName &class_name : class_list) { - List property_list; - ClassDB::get_property_list(class_name, &property_list, true); - - for (const PropertyInfo &property_info : property_list) { - if (property_info.name.findn(search_box->get_text()) == -1) { - continue; - } - - TreeItem *item = results_tree->create_item(root); - item->set_text(0, String(class_name) + "::" + property_info.name); - item->set_icon(0, EditorNode::get_singleton()->get_class_icon(class_name, "Object")); - item->set_metadata(0, "property:" + String(class_name) + "::" + property_info.name); - } - } - } - - if (search_signals->is_pressed()) { - List class_list; - ClassDB::get_class_list(&class_list); - - for (const StringName &class_name : class_list) { - List signal_list; - ClassDB::get_signal_list(class_name, &signal_list, true); - - for (const MethodInfo &signal_info : signal_list) { - if (signal_info.name.findn(search_box->get_text()) == -1) { - continue; - } - - TreeItem *item = results_tree->create_item(root); - item->set_text(0, String(class_name) + "::" + signal_info.name); - item->set_icon(0, EditorNode::get_singleton()->get_class_icon(class_name, "Object")); - item->set_metadata(0, "signal:" + String(class_name) + "::" + signal_info.name); - } - } - } } void VisualScriptPropertySelector::_confirmed() { @@ -204,14 +107,12 @@ void VisualScriptPropertySelector::_confirmed() { if (!ti) { return; } - emit_signal(SNAME("selected"), ti->get_metadata(0), ti->get_metadata(1), - connecting); + emit_signal(SNAME("selected"), ti->get_metadata(0), ti->get_metadata(1), connecting); set_visible(false); } void VisualScriptPropertySelector::_item_selected() { - help_bit->set_text(results_tree->get_selected()->get_meta( - "description", "No description available")); + help_bit->set_text(results_tree->get_selected()->get_meta("description", "No description available")); } void VisualScriptPropertySelector::_hide_requested() { @@ -225,8 +126,7 @@ void VisualScriptPropertySelector::_notification(int p_what) { } break; case NOTIFICATION_ENTER_TREE: { - connect("confirmed", - callable_mp(this, &VisualScriptPropertySelector::_confirmed)); + connect("confirmed", callable_mp(this, &VisualScriptPropertySelector::_confirmed)); } break; case NOTIFICATION_PROCESS: { @@ -247,21 +147,21 @@ void VisualScriptPropertySelector::_notification(int p_what) { } } -void VisualScriptPropertySelector::select_method_from_base_type( - const String &p_base, const bool p_virtuals_only, const bool p_connecting, - bool clear_text) { +void VisualScriptPropertySelector::select_method_from_base_type(const String &p_base, const bool p_virtuals_only, const bool p_connecting, bool clear_text) { set_title(TTR("Select method from base type")); base_type = p_base; base_script = ""; type = Variant::NIL; connecting = p_connecting; - if (clear_text && !p_virtuals_only) { - search_box->set_text(" "); // show all methods - search_box->set_caret_column(1); - } else { - search_box->set_text("._"); // show all _methods - search_box->set_caret_column(2); + if (clear_text) { + if (p_virtuals_only) { + search_box->set_text("._"); // show all _methods + search_box->set_caret_column(2); + } else { + search_box->set_text("."); // show all methods. + search_box->set_caret_column(1); + } } search_visual_script_nodes->set_pressed(false); @@ -281,17 +181,20 @@ void VisualScriptPropertySelector::select_method_from_base_type( _update_results(); } -void VisualScriptPropertySelector::select_from_visual_script( - const Ref