godotengine/godot-team-reports
1
0
Fork 0
mirror of https://github.com/godotengine/godot-team-reports.git synced 2026-01-05 14:10:05 +03:00
Code Issues Packages Projects Releases Wiki Activity

Improve team and reviewer sorting

Browse Source
This commit is contained in:
Yuri Sizov
2021-09-04 03:15:19 +03:00
parent 5258330056
commit dbb453ad55
2 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/paths/index/components/prs/PullRequestItem.js
View File

@@ -228,9 +228,12 @@ export default class PullRequestItem extends LitElement {
const other_teams = [].concat(this.teams); const other_teams = [].concat(this.teams);
other_teams.sort((a, b) => { other_teams.sort((a, b) => {
if (a > b) return 1; const a_name = a.toLowerCase().replace(/^_/, "");
if (a < b) return -1; const b_name = b.toLowerCase().replace(/^_/, "");
return 0;
if (a_name > b_name) return 1;
if (a_name < b_name) return -1;
return 0;
}); });
const authorClassList = [ "pr-author-value" ]; const authorClassList = [ "pr-author-value" ];

14
src/paths/index/entry.js
View File

@@ -73,15 +73,21 @@ export default class EntryComponent extends LitElement {
if (a.id === -1) return -1; if (a.id === -1) return -1;
if (b.id === -1) return -1; if (b.id === -1) return -1;
if (a.name > b.name) return 1; const a_name = a.name.toLowerCase().replace(/^_/, "");
if (a.name < b.name) return -1; const b_name = b.name.toLowerCase().replace(/^_/, "");
if (a_name > b_name) return 1;
if (a_name < b_name) return -1;
return 0; return 0;
}); });
this._orderedReviewers = Object.values(this._reviewers); this._orderedReviewers = Object.values(this._reviewers);
this._orderedReviewers.sort((a, b) => { this._orderedReviewers.sort((a, b) => {
if (a.name > b.name) return 1; const a_name = a.name.toLowerCase();
if (a.name < b.name) return -1; const b_name = b.name.toLowerCase();
if (a_name > b_name) return 1;
if (a_name < b_name) return -1;
return 0; return 0;
}); });