From 8fd41702c61856daf59b348c245cdec70ccbc320 Mon Sep 17 00:00:00 2001 From: Fabio Alessandrelli Date: Sun, 28 Jul 2024 01:35:33 +0200 Subject: [PATCH] Fix typing errors in webrtc_signaling demo (#1096) --- networking/webrtc_signaling/client/multiplayer_client.gd | 4 ++-- networking/webrtc_signaling/client/ws_webrtc_client.gd | 4 ++-- networking/webrtc_signaling/demo/client_ui.gd | 4 ++-- networking/webrtc_signaling/server/ws_webrtc_server.gd | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/networking/webrtc_signaling/client/multiplayer_client.gd b/networking/webrtc_signaling/client/multiplayer_client.gd index b22a99bb..88c8bcbb 100644 --- a/networking/webrtc_signaling/client/multiplayer_client.gd +++ b/networking/webrtc_signaling/client/multiplayer_client.gd @@ -97,13 +97,13 @@ func _peer_disconnected(id: int) -> void: rtc_mp.remove_peer(id) -func _offer_received(id: int, offer: int) -> void: +func _offer_received(id: int, offer: String) -> void: print("Got offer: %d" % id) if rtc_mp.has_peer(id): rtc_mp.get_peer(id).connection.set_remote_description("offer", offer) -func _answer_received(id: int, answer: int) -> void: +func _answer_received(id: int, answer: String) -> void: print("Got answer: %d" % id) if rtc_mp.has_peer(id): rtc_mp.get_peer(id).connection.set_remote_description("answer", answer) diff --git a/networking/webrtc_signaling/client/ws_webrtc_client.gd b/networking/webrtc_signaling/client/ws_webrtc_client.gd index 98fe1297..c81ae6cf 100644 --- a/networking/webrtc_signaling/client/ws_webrtc_client.gd +++ b/networking/webrtc_signaling/client/ws_webrtc_client.gd @@ -25,8 +25,8 @@ signal connected(id: int, use_mesh: bool) signal disconnected() signal peer_connected(id: int) signal peer_disconnected(id: int) -signal offer_received(id: int, offer: int) -signal answer_received(id: int, answer: int) +signal offer_received(id: int, offer: String) +signal answer_received(id: int, answer: String) signal candidate_received(id: int, mid: String, index: int, sdp: String) signal lobby_sealed() diff --git a/networking/webrtc_signaling/demo/client_ui.gd b/networking/webrtc_signaling/demo/client_ui.gd index 0731db31..b0b679e5 100644 --- a/networking/webrtc_signaling/demo/client_ui.gd +++ b/networking/webrtc_signaling/demo/client_ui.gd @@ -19,8 +19,8 @@ func _ready() -> void: @rpc("any_peer", "call_local") -func ping(argument: String) -> void: - _log("[Multiplayer] Ping from peer %d: arg: %s" % [multiplayer.get_remote_sender_id(), argument]) +func ping(argument: float) -> void: + _log("[Multiplayer] Ping from peer %d: arg: %f" % [multiplayer.get_remote_sender_id(), argument]) func _mp_server_connected() -> void: diff --git a/networking/webrtc_signaling/server/ws_webrtc_server.gd b/networking/webrtc_signaling/server/ws_webrtc_server.gd index c9c4bf44..dface0ee 100644 --- a/networking/webrtc_signaling/server/ws_webrtc_server.gd +++ b/networking/webrtc_signaling/server/ws_webrtc_server.gd @@ -225,7 +225,7 @@ func _parse_msg(peer: Peer) -> bool: if not lobbies.has(peer.lobby): # Lobby not found? return false - var lobby: Peer = lobbies[peer.lobby] + var lobby: Lobby = lobbies[peer.lobby] if msg.type == Message.SEAL: # Client is sealing the room.