From 42fbc4008aff490a839d8e9f360ccae3751b3a3d Mon Sep 17 00:00:00 2001 From: Francisco Demartino Date: Thu, 1 Feb 2024 15:02:49 -0300 Subject: [PATCH] Fix convex hull benchmarks (multiple of 3) (#55) The benchmark was bogus before. I missed this error: convex_hull_3d.gd:34 @ _bench_convex(): Ignoring surface 0, incorrect vertex count: 10000 (for PRIMITIVE_TRIANGLES). Condition "(len % 3) != 0" is true. Continuing. Also tweaked the iteration count so it takes a reasonable time. --- benchmarks/math/convex_hull_3d.gd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/benchmarks/math/convex_hull_3d.gd b/benchmarks/math/convex_hull_3d.gd index 452b752..2f630e2 100644 --- a/benchmarks/math/convex_hull_3d.gd +++ b/benchmarks/math/convex_hull_3d.gd @@ -1,7 +1,7 @@ extends Benchmark -const NUM_ITERATIONS := 100 -const NUM_POINTS := 10_000 +const NUM_ITERATIONS := 10 +const NUM_POINTS := 1002 # Should be a multiple of three, triangles will be built with this. const CLOUD_SIZE := 1.0 const POSITION := Vector3(0.0, 0.0, 0.0)