godot-angle-static/overlay_widgets.json at c3c41889f437e06ae0d4e691f27aadf6d93c0cfe - godot-angle-static - GitFuck

godotengine/godot-angle-static

mirror of https://github.com/godotengine/godot-angle-static.git synced 2026-01-07 06:09:57 +03:00

Files

Charlie Lao 376d309c40 Vulkan: Remove unnecessary usesBuffer() check

There are places that we call setQueueSerial after usesBuffer() check.
This was useful when we had the ResourceList where it is more expensive
to set serial. But now setQueueSerial is cheap (actually is cheaper than
usesBuffer check), so there is no need to do this check any more. This
CL removes the check to further reduce the CPU overhead. Because of
this, mUsedBufferCount will not be accurate, so this CL also removes the
tracking of mUsedBufferCount (was only for informational purpose
anyway).

This CL also removes commandBufferQueueSerial.valid() check in
Resource::usedByCommandBuffer() and turns it into assertion. Some places
in contextVk will ensure we only call it on started renderpass so that
other places that calls usedByCommandBuffer will not need to eat the if
check.

Bug: b/262047600
Change-Id: I6b8004b6aa5b567fa94c0eb56801054f818838b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4112145
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

2022-12-19 18:18:41 +00:00

10 lines

316 B

JSON

Raw Blame History

 {
   "src/libANGLE/Overlay_autogen.cpp":
     "565b0fcdabdad7a0d4d548d0257e080e",
   "src/libANGLE/Overlay_autogen.h":
     "ca908da927f007729dc3d4ade0f03c4e",
   "src/libANGLE/gen_overlay_widgets.py":
     "10d70715aa19ac3a8b6680aae9f26b8a",
   "src/libANGLE/overlay_widgets.json":
     "35dca0d861735e1af56a0c763c65f3a4"
 }