Phan Quang Minh
4cab5e94fc
Vulkan: Enable timeline semaphores if supported by device
...
This is needed for a similar change in Chromium to function with
`--enable-features=VulkanFromANGLE`.
Bug: angleproject:8253
Change-Id: I422964ea010c650439dd4797ee8ba7b533f26a87
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675807
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-12 11:11:51 +00:00
angle-autoroll
2134a9def0
Roll vulkan-deps from 03c816988bfd to 4ba3255697ef (11 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/03c816988bfd..4ba3255697ef
Changed dependencies:
* glslang: eaa7057768..44779f508a4be7d0e3ca..7ff331af66db290809b5..011b0090edhttps://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com ,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I82ccb55b54c9e8d30eb9a889a08cb48eb9f0771f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4679255
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-07-12 10:56:29 +00:00
Alexey Knyazev
94ceedb7e8
Add GL_EXT_texture_compression_astc_decode_mode stubs
...
Bug: angleproject:8254
Change-Id: I2a839139b5738710e32842b04db35eab8fb04687
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4679683
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-12 10:27:03 +00:00
angle-autoroll
1aa2c87ca7
Roll Chromium from d0f9360d7ae6 to 3d5d845687d5 (622 revisions)
...
d0f9360d7a..3d5d845687https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com ,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: 143d726c8e..e7cd327c477a9572876c..0732a94e42aa4f4558ff..e197e4c396https://chromium.googlesource.com/catapult.git/+log/ {catapult_..2565a43987
* third_party/depot_tools: e5277508c8..43bf9b7258https://chromium.googlesource.com/external/github.com/kennethreitz/requests.git/+log/refs/tags/..c7e0fc087c
* third_party/zlib: 7eff33bc00..1206f0dbef7b20bcffe9..e5b5f210e756589b6087..3fd043fc8b4b4a958480..86375f9e21cnorthrop@google.com
Change-Id: Ie61d1ebe8be0620b0d41d6ee8a39d49b97a29527
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4679254
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-07-12 08:20:53 +00:00
Geoff Lang
ebaadc6c2c
Terminate the display if initialization fails.
...
If DisplayImpl::initialize fails, call terminate to ensure no resources
are leaked.
This is a speculative fix for dual GPU macs not falling back to the
low power GPU. DisplayMtl leaks the metal device if it fails to
initialize due to unsupported GPU families or vendors.
Bug: chromium:1322521
Change-Id: Ie227216bc92ef2834ec50190fbb78bec45e9c053
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4641107
Commit-Queue: Geoff Lang <geofflang@chromium.org >
Reviewed-by: Kenneth Russell <kbr@chromium.org >
2023-07-11 18:11:53 +00:00
Yuxin Hu
759027e852
Enable the new deqp khr test suites on Bot
...
This CL enables the deqp khr test suites added in
https://chromium-review.googlesource.com/c/angle/angle/+/4654841
on below bots:
pixel4 vulkan backend
pixel6 vulkan backend
windows vulkan backend
linux swiftshader backend
linux swiftshader backend tsan
linux swiftshader backend asan
The current linux driver on bot does not support the
new test suites on vulkan backend. We will enable the
test suites on linux vulkan backend after we upgrade the
bot machine driver to a newer version:
https://bugs.chromium.org/p/chromium/issues/detail?id=1271688
Bug: b/286921997
Bug: angleproject:8251
Change-Id: I659424efc09028f685edff076711c9089ec635d4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4673582
Commit-Queue: Yuxin Hu <yuxinhu@google.com >
Reviewed-by: Roman Lavrov <romanl@google.com >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
2023-07-11 17:50:08 +00:00
Oliver Wolff
6473008c2e
winrt: Fix initialization of zero-sized window
...
The clientRect might be empty when creating a window of zero size. The
side effect of a division by zero is that matrix transformation fails
and hence the swapchain gets into an invalid state.
See:
https://code.qt.io/cgit/qt/qtbase.git/tree/src/angle/patches/0005-ANGLE-Fix-initialization-of-zero-sized-window.patch?h=5.15
Signed-off-by: L. E. Segovia <amy@amyspark.me >
Bug: None
Change-Id: Idbaed72deadb7b87052ac27e194a40d1810e6f7a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661674
Reviewed-by: Geoff Lang <geofflang@chromium.org >
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-11 17:43:53 +00:00
Shahbaz Youssefi
9b63700be1
Translator: Reorganize files
...
This change makes the translator files more organized by:
- Grouping files that are specific to a certain output under their own
directory,
- Moving transformations under tree_ops
- Removing Direct from metal translation now that that SPIR-V Cross path
is removed
Bug: angleproject:6394
Change-Id: Iaf5bb8d5604b84748dece029821b1f77b2813967
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678780
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
Reviewed-by: Geoff Lang <geofflang@chromium.org >
2023-07-11 17:43:15 +00:00
Geoff Lang
4e6124dae8
GL: Ensure all instanced attributes have a buffer with data
...
Apple OpenGL drivers sometimes crash when given an instanced draw with
a buffer that has never been given data.
It's not efficient to check if the attribute is both zero-sized and
instanced so just ensure that every time a zero-sized buffer is bound
to an attribute, it gets initialized with some data.
Bug: chromium:1456243
Change-Id: I66b7c7017843153db2df3bc50010cba765d03c5f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4642048
Commit-Queue: Geoff Lang <geofflang@chromium.org >
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-11 17:25:50 +00:00
Oliver Wolff
5922b83bff
D3D11: Fix Windows Store D3D Trim and Level 9 requirements
...
Due to additional validation not covered in previous patches, the
Windows Store certification compatibility had regressed. These
changes ensure that the required D3D behaviors are met.
See:
https://code.qt.io/cgit/qt/qtbase.git/tree/src/angle/patches/0003-ANGLE-Fix-Windows-Store-D3D-Trim-and-Level-9-require.patch?h=5.15
Co-authored-by: L. E. Segovia <amy@amyspark.me >
Signed-off-by: L. E. Segovia <amy@amyspark.me >
Bug: None
Change-Id: If8bc2f8cd4b2f84e1d92a1627951da2537212125
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661673
Reviewed-by: Geoff Lang <geofflang@chromium.org >
Commit-Queue: Geoff Lang <geofflang@chromium.org >
2023-07-11 16:19:48 +00:00
Shahbaz Youssefi
f065346170
Translator: Fix metal-only build
...
Bug: angleproject:6306
Change-Id: I068dc93528b7583ddc84836ac73b52adcde890f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4677722
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-11 15:20:50 +00:00
Shahbaz Youssefi
f5ad056b0d
GL: Fix ScalarizeVecAndMatConstructorArgs and move to gl/
...
This transformation was buggy and was disabled. Originally, it was
intended to be used everywhere. It is now needed for a GL driver
workaround.
This change reimplements this transformation and uses it as a GL
workaround.
Bug: chromium:1420130
Change-Id: I42d63fa5844bcf683ac41e61925aa637e033ca2e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4676634
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
Reviewed-by: Geoff Lang <geofflang@chromium.org >
2023-07-11 15:08:28 +00:00
Shahbaz Youssefi
0312c76fcf
Translator: Move metal-only transformation to its own dir
...
Bug: angleproject:6306
Change-Id: I5ff453f03cccd1c4bcec59e21a18fc6049598383
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675654
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-11 11:49:42 +00:00
Yuly Novikov
648f24c92f
Start Mac AMD 13.4.1 experiment
...
Bug: chromium:1462473
Change-Id: Ic30d5f5a0999c10949581aff813febdb83a8cef9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675805
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
Reviewed-by: Brian Sheedy <bsheedy@chromium.org >
2023-07-11 11:41:48 +00:00
angle-autoroll
7de7b9a4f6
Roll vulkan-deps from 869b279baef4 to 03c816988bfd (17 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/869b279baef4..03c816988bfd
Changed dependencies:
* glslang: 3ebb72cc74..eaa7057768870fd1e17a..4be7d0e3ca179b26a792..2565ffa31e9d38cccf33..8b94e87bff39090f9152..6e7fa4d975db466666ac..db290809b5https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com ,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Change-Id: Idb10483c233a386723d71bd478c396ba5546947c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675703
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-07-11 11:03:13 +00:00
angle-autoroll
daeef9fa89
Roll Chromium from 749d653d9a36 to d0f9360d7ae6 (471 revisions)
...
749d653d9a..d0f9360d7ahttps://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com ,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: 194f8687fe..143d726c8e24349b4e60..7a9572876cfa6fe66454..aa4f4558ffea2e39562f..14eb523de5https://chromium.googlesource.com/catapult.git/+log/ {catapult_..7d7df42f80
* third_party/depot_tools: 247429efd9..e5277508c8c96255caa8..32c68ae5c1eaa6ca74e2..c29b6b927f21264809df..56589b6087cnorthrop@google.com
Change-Id: I89b29bf8b6a8a065b70a1c6037f0ddd4c804b955
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4676841
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-07-11 08:40:05 +00:00
Sunny Sachanandani
7bcd88cc1c
gl: Do not propagate copyTexSubImage2D error to client
...
https://chromium-review.googlesource.com/c/angle/angle/+/4662393 ensured
that BlitGL::copyTexSubImage allowed the caller to fallback when the
underlying copyTexSubImage2D call failed, but the GL error was also
propagated to the client due to the Context::handleError call in
CheckError - that error still causes webgl conformance failures even
though the pixel expectations are now satisfied.
This CL makes BlitGL::copyTexSubImage use getError directly so that the
error is not propagated to the client.
Bug: chromium:1458040
Change-Id: I3e4c06871c55d449facbe471c78e84f68b529f60
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4671325
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org >
2023-07-11 00:03:29 +00:00
Shahbaz Youssefi
c0069e6279
Vulkan: Enable ANGLE_pack_reverse_row_order
...
This allows testing the compute path implementation of PBO download for
SNORM targets.
Bug: b/286882707
Change-Id: I01393f8cad96bf8857a0dfb1638ff2c6366c28a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4668228
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org >
Commit-Queue: Yuxin Hu <yuxinhu@google.com >
Reviewed-by: Yuxin Hu <yuxinhu@google.com >
2023-07-10 20:32:44 +00:00
Amirali Abdolrashidi
b0e262fbb4
Group Texture3DTestES2 skips on iOS GL
...
Bug: angleproject:8213
Change-Id: Ib00bd8d28aa58a56012f2b46f4ac153481d1be38
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4674080
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com >
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
2023-07-10 19:25:15 +00:00
angle-autoroll
db6b035713
Manual roll Chromium from 8a1e61637248 to 749d653d9a36 (139 revisions)
...
Manual roll requested by ynovikov@google.com
8a1e616372..749d653d9ahttps://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com ,cnorthrop@google.com ,ynovikov@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* testing: 11876f21fd..24349b4e60https://chromium.googlesource.com/catapult.git/+log/ {catapult_..7d7df42f80
* third_party/turbine: 9rSngS4o9OIlNubLcU1zXF_w0dPYif6AS-_k1pPAV1kC..2I2Nz480QsuCxpQ1lMfbigX8l5HAhX3_ykWU4TKRGo4C
No update to Clang.
Bug: None
Tbr: cnorthrop@google.com ,ynovikov@google.com
Change-Id: I7fd7532722aca9f5a7d7bdd42bf3a0ef92fe95f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675961
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-07-10 17:17:34 +00:00
Geoff Lang
8b0e541355
Metal: Put a limit on the total MTLLibrary objects cached
...
Use an MRU for holding the cached libraries in mtl::LibraryCache.
Using a maximum cache size of 128 and a GC size of 32 yields the same
ratio of cache hits as before (40%) while cycling out the more unique
shaders that are not re-used. Lowering the cache size to 64 or 96
yields a hit rate of 30-35%.
Bug: chromium:1329376
Change-Id: I75dd6b20cf3f8b67c4b3c31da4e05e1857ad61db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4614362
Reviewed-by: Quyen Le <lehoangquyen@chromium.org >
Commit-Queue: Geoff Lang <geofflang@chromium.org >
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-10 15:10:07 +00:00
Yuly Novikov
1019496633
Skip 2 flaky Perf tests on Win Intel Vulkan
...
pubg_mobile_launch flaky timeout
monster_hunter_stories flaky context lost
Bug: angleproject:7929, angleproject:7557
Change-Id: I45d7b22bd3186419a584314c6c1f52ed0427ec8a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4674342
Auto-Submit: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Roman Lavrov <romanl@google.com >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
Reviewed-by: Roman Lavrov <romanl@google.com >
2023-07-10 14:47:23 +00:00
Yuly Novikov
b2b1363ae6
Skip Texture3DTestES2.DefineTexture2DArrayShouldFail on iOS GL
...
Bug: angleproject:8213
Change-Id: I5487bd7b0a8033445d5552bb8d86dc3af80f1305
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4674340
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Auto-Submit: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
2023-07-10 13:06:28 +00:00
angle-autoroll
5d3ca3bada
Roll Chromium from 96802d0bdfdd to 8a1e61637248 (514 revisions)
...
96802d0bdf..8a1e616372https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com ,ianelliott@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: 6b59eb95c1..194f8687fef11186bf34..1cc82962cbb4958339ec..11876f21fdhttps://chromium.googlesource.com/catapult.git/+log/ {catapult_..7d7df42f80
* third_party/depot_tools: 4303140531..247429efd9f37f647574..7b20bcffe950358e9b66..eaa6ca74e2ianelliott@google.com
Change-Id: I28cf76358fda84b7e4df0cf18c344821adec4fbf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4674826
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-07-10 08:00:00 +00:00
Yuxin Hu
6ee402f6c1
Clamp the max Framebuffer width and height to 16 bit
...
GraphicsDriverUniforms struct packs framebuffer
width and height into a 32 bit uint, meaning the
maximum width and height supported are 16 bit each.
We should make sure below values do not exceed the
maximum value of a 16-bit uint:
caps.maxFramebufferWidth
caps.maxFramebufferHeight
caps.maxRenderbufferSize
so that the application won't try to create a FBO
with width/height exceeding 16-bit.
We have clamped the caps.max2DTextureSize to
32768, it makes sense to clamp the FBO width and height
to the same value.
Bug: b/286921997
Change-Id: Iae598b37215c58d1a0f6a50bba9f391d4d23d1f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4671327
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
Reviewed-by: Charlie Lao <cclao@google.com >
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-08 01:58:43 +00:00
Yuxin Hu
3c814a34b8
Include files declared in compiler.gni in shader program cache key
...
We should invalidate the program cache when the
files declared in compiler.gni changes. Add those
files for shader cache key calculations.
Bug: angleproject:4981
Bug: b/285871779
Change-Id: I9a8a65c1b02c4efcc6126d8b77017ddd8328e7a2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4662395
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
Commit-Queue: Yuxin Hu <yuxinhu@google.com >
Reviewed-by: Cody Northrop <cnorthrop@google.com >
2023-07-07 21:55:57 +00:00
Alexey Knyazev
b57d5638dc
Reland "Cleanup multiview support"
...
This is a reland of commit 9a7c0b88bahttps://chromium-review.googlesource.com/c/angle/angle/+/4669604
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com >
2023-07-07 21:22:07 +00:00
Mohan Maiya
8b680c93c2
Vulkan: Bug fix in GetAvailableValidationLayers(...)
...
GetAvailableValidationLayers(...) had a bug where it did
not account for a subset of kVkValidationLayerNames
being available.
Bug: angleproject:8247
Change-Id: Id7bc3570b2caf5550ca9d011a3ba9429702af8af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4673189
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
Commit-Queue: mohan maiya <m.maiya@samsung.com >
2023-07-07 20:27:44 +00:00
Roman Lavrov
5997f1d70c
Fix little_cpu_power collection.
...
Currently always getting 0, significantly undercounting cpu power at
least in some cases (e.g. I saw 1700 vs 4300 in fishdom)
Bug: b/284462263
Change-Id: Idd525f25cfc419a4a9d23a3fc99e938e99e1e715
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672592
Auto-Submit: Roman Lavrov <romanl@google.com >
Reviewed-by: Cody Northrop <cnorthrop@google.com >
Commit-Queue: Roman Lavrov <romanl@google.com >
2023-07-07 20:26:28 +00:00
Charlie Lao
3cc3327c52
Vulkan: limit preferCPUForBufferSubData flag to mali job manager
...
This feature flag was introduced with testing on pixel 6 pro with
aliexpress trace. The GPU has a job manager does the scheduling and
transfer workload was put in the same job queue as geometry work which
causing unnecessary bubble in the pipeline. This problem does not exist
on newer GPU architecture where it has a command stream front end that
transfer has its own dedicated queue. As test result on pixel 7 devices
indicates, this feature flag shows no difference on pixel 7with
aliexpress trace, and has negative perf impact with gangstar_vegas
trace. This CL limits the feature flag to ARM's job manager based GPU.
This improves gangstar_vegas frame time from 8.4576ms to 4.6370ms on
pixel 7 pro.
Bug: b/289436017
Change-Id: I604fb1e26d0a99bcf8f4c2574ced360c31ac712d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4671326
Commit-Queue: Charlie Lao <cclao@google.com >
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-07 20:22:21 +00:00
Shahbaz Youssefi
04c0cc8d59
Simplify aliasing-exception logic in entry point generation
...
Bug: angleproject:8224
Change-Id: Ic54c233ab3d8a0f9a1ac803804aea770c6f7cc07
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672145
Reviewed-by: Roman Lavrov <romanl@google.com >
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-07 20:06:31 +00:00
Shahbaz Youssefi
51320fab57
Make most GLES1 entry points lockless
...
These entry points only set context-local state and thus don't require
locking.
Bug: angleproject:8224
Change-Id: I80223340348d62a56109324ab3e4f935e53419b3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4670407
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com >
Reviewed-by: Charlie Lao <cclao@google.com >
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-07 19:51:12 +00:00
Shahbaz Youssefi
eb205e689d
Make the glPatchParameteri entry point lockless
...
This entry points only sets context-local state and thus doesn't require
locking.
Bug: angleproject:8224
Change-Id: I17975a97aa7f68c3ddf2ef78069b8f519fdc4c1a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4670405
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
Reviewed-by: Charlie Lao <cclao@google.com >
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com >
2023-07-07 19:42:31 +00:00
Shahbaz Youssefi
5869fb3b05
Remove big-GL files from normal builds of ANGLE
...
Bug: angleproject:7533
Change-Id: I3616296d9923310200830a921190813e3ecfe80b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672146
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
Reviewed-by: Roman Lavrov <romanl@google.com >
2023-07-07 19:41:32 +00:00
Shahbaz Youssefi
732a8f07d0
Move max-shader-compile-threads state out of LocalState
...
While this state is indeed context-local, setting it calls into the
backend (GL backend specifically, where it forwards the call to the
driver). The call to set this state is rare and now worth the risk
associated with making it lockless.
Bug: angleproject:8224
Change-Id: I3af395721fa18b9345698870c0da63e8cac83610
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666355
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com >
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org >
Reviewed-by: Charlie Lao <cclao@google.com >
Commit-Queue: Charlie Lao <cclao@google.com >
2023-07-07 17:12:15 +00:00
angle-autoroll
f9b1659317
Manual roll Chromium from e506ce09bac4 to 96802d0bdfdd (1526 revisions)
...
Manual roll requested by ynovikov@google.com
e506ce09ba..96802d0bdfhttps://autoroll.skia.org/r/chromium-angle-autoroll
Please CC
angle-team@google.com ,ianelliott@google.com ,ynovikov@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: f87ccdf42a..6b59eb95c16d00f8d8c5..f11186bf34ac3cb62a5a..b4958339ecb5862634ee..ae5ee2a38f4cb10f1315..fa6fe6645436fd99b5ae..6514de5457a72ec125fa..4b4eee2d24https://chromium.googlesource.com/catapult.git/+log/ {catapult_..451fa58bf6
* third_party/depot_tools: 872ac9bd3d..430314053119617929c3..e2247b370813f4e8c9e2..006709ba3e678d565421..c468546c25f999826d2d..7eff33bc0039d4cc4ec8..f37f64757475c7faf556..50358e9b6633899440a1..21264809df57b3b9e7c0..9a047fd494159b3b88fd..4b4a95848075c7faf556..50358e9b66ianelliott@google.com ,ynovikov@google.com
Change-Id: I6af984fb327e9b028cb3d48b89be73676192ba1c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672995
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-07-07 16:46:35 +00:00
Roman Lavrov
9cd1205f2e
Skip street_fighter_iv_ce on SwiftShader
...
keyframe=86, runs very slow on SwS: https://anglebug.com/8243#c1
Bug: angleproject:8243
Change-Id: Iae3c758ea6b6e6a2a68f91a1355c10bc9c92f432
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672588
Commit-Queue: Roman Lavrov <romanl@google.com >
Auto-Submit: Roman Lavrov <romanl@google.com >
Reviewed-by: Cody Northrop <cnorthrop@google.com >
2023-07-07 16:44:03 +00:00
Roman Lavrov
44acab29bd
Use latest build-tools from android_sdk (same as catapult)
...
https://crsrc.org/c/third_party/catapult/devil/devil/android/sdk/build_tools.py;drc=8a3feaaaab63b383fb6b138be2986e9ad6dcaca2;l=61
Also do not fall back to just 'aapt' as that isn't hermetic.
Bug: angleproject:7670
Change-Id: Ided9dfe16d6c6815c3425bdc64b2d572bbe564c5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672808
Auto-Submit: Roman Lavrov <romanl@google.com >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
2023-07-07 16:42:17 +00:00
Roman Lavrov
da710ac3f7
Stop rolling third_party/cpu_features
...
It was probably needed for zlib previously but now zlib already depends
on the ndk's cpufeatures. There are no references to third_party
cpu_features in the generated Android.bp.
Bug: b/289259681
Change-Id: Ib849b26391d0c23e533662094e74384c267c8620
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4656761
Reviewed-by: Solti Ho <solti@google.com >
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org >
Auto-Submit: Roman Lavrov <romanl@google.com >
Commit-Queue: Solti Ho <solti@google.com >
2023-07-07 15:45:23 +00:00
Anne Redulla
66c2e4fca2
[ssci] Added Shipped field to READMEs
...
This CL adds the Shipped field (and may update the
License File field) in Chromium READMEs. Changes were
automatically created, so if you disagree with any of
them (e.g. a package is used only for testing purposes
and is not shipped), comment the suggested change and
why.
See the LSC doc at go/lsc-chrome-metadata.
Bug: b/285450740
Change-Id: I770554248e33c1e50938cc32daee36a83b643ec9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672125
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-07 13:44:43 +00:00
angle-autoroll
65ae56ba61
Roll vulkan-deps from c421d230f1c1 to 869b279baef4 (3 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/c421d230f1c1..869b279baef4
Changed dependencies:
* vulkan-validation-layers: f2f60da66f..db466666achttps://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com ,ianelliott@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ianelliott@google.com
Change-Id: Ifaa2d0b7d639fe0a5c9fa392c05b384f75e8b458
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672746
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2023-07-07 11:17:47 +00:00
Shahbaz Youssefi
7e0fb7e402
Make glIsEnabled* entry points lockless
...
These entry points only set context-local state and thus don't require
locking.
Bug: angleproject:8224
Change-Id: I6fe40bf4381e1d42248358f773ec9d5675883ada
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666356
Reviewed-by: Charlie Lao <cclao@google.com >
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com >
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-07 04:17:53 +00:00
Shahbaz Youssefi
72c269263c
Make pack/unpack and hint entry points lockless
...
These entry points only set context-local state and thus don't require
locking.
Bug: angleproject:8224
Change-Id: I5694d319df61a7a9df1766cf1f723b9a05208209
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666352
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com >
Reviewed-by: Charlie Lao <cclao@google.com >
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-07 03:53:06 +00:00
Shahbaz Youssefi
208dfe2860
Make glStencil* entry points lockless
...
These entry points only set context-local state and thus don't require
locking.
Bug: angleproject:8224
Change-Id: I612d8219ba038464173490b2c261e9e7b229c83f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661702
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com >
Reviewed-by: Charlie Lao <cclao@google.com >
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-07 01:23:26 +00:00
Shahbaz Youssefi
c3c2f45046
Make glBlend* entry points lockless
...
These entry points only set context-local state and thus don't require
locking.
Bug: angleproject:8224
Change-Id: Ie811c35ae7b65106db9af9f7531ad3a5e0bd4f8c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661701
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com >
Reviewed-by: Charlie Lao <cclao@google.com >
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-07 00:32:19 +00:00
Shahbaz Youssefi
4439593002
Make various state setting entry points lockless
...
These entry points only set context-local state and thus don't require
locking.
Bug: angleproject:8224
Change-Id: I428c23cc862e9356d571bc085b5df0bf48017175
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661700
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com >
Reviewed-by: Charlie Lao <cclao@google.com >
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
2023-07-06 23:38:50 +00:00
Shahbaz Youssefi
9daac2b7dd
Make glEnable/Disable entry points lockless
...
These entry points only set context-local state and thus don't require
locking.
Bug: angleproject:8224
Change-Id: Id4eab729115bd75f82e1ec7a27355c821a7c4320
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661697
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com >
Reviewed-by: Charlie Lao <cclao@google.com >
2023-07-06 21:04:53 +00:00
Shahbaz Youssefi
fede75ffbd
Fix multi-draw's gl_DrawID in non-multi-draw draws
...
The uniform value for gl_DrawID was never reset, so if a program was
first used with multi-draw and then without it, gl_DrawID would not
contain zero.
Test credit info-tibo@orange.fr
Bug: angleproject:8245
Change-Id: I73a613ab2858cde4633fadf6a1a523e462167eb0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4662137
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org >
Reviewed-by: Steven Noonan <steven@uplinklabs.net >
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com >
2023-07-06 18:05:55 +00:00
Shahbaz Youssefi
0892420bcf
Vulkan: Optimize PBO download between RGBA and BGRA
...
Google Meet hits this path in Chrome when blurring the background. The
CPU readback was particularly slow on Intel/Mesa where readback from the
temp buffer took hundreds of milliseconds.
This change adds a compute shader that directly copies from the image to
the pack buffer in simple but common cases.
Bug: b/286882707
Change-Id: I9877ea01e3d8377db96f2539362aca67cf832b4a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4657058
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org >
Reviewed-by: Yuxin Hu <yuxinhu@google.com >
Reviewed-by: Charlie Lao <cclao@google.com >
Commit-Queue: Yuxin Hu <yuxinhu@google.com >
2023-07-06 17:45:07 +00:00
Yuxin Hu
c934d86be8
Update dEQP-GLES mustpass List
...
1. Reordered gCaseListFiles.
2. Added below must pass list as they are
required by the Khronos CTS:
gles2-khr-noctx-master.txt
gles32-khr-noctx-master.txt
gles32-khr-single.txt
3. Added new test package to run the tests
in these mustpass lists:
angle_deqp_khr_noctx_gles2_tests
angle_deqp_khr_noctx_gles32_tests
angle_deqp_khr_single_gles32_tests
Newly added tests will not be executed on bot yet.
There will be follow-up CL to add these tests on bot.
Bug: b/286921997
Change-Id: Ibc7dbf81dca67ad7be440d559f5b4ee0211c6c41
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4654841
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Yuxin Hu <yuxinhu@google.com >
2023-07-06 17:07:24 +00:00
