Jamie Madill
aed52e6704
Set dcheck_always_on on every ANGLE builder.
...
This GN argument is necessary because some build components
reference it directly. Letting it be specified implicitly will
caused undesired side-effects.
Bug: chromium:1227171
Change-Id: Ib12cc3add58ecc8ae0360f816d30587158d756c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3048850
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-07-23 13:17:37 +00:00
Jamie Madill
2b86e2d60f
GN: Update dcheck/assert conditions.
...
In preparation for a Chromium change that makes dchecks enabled
by default in Release builds, we'll keep ASSERT disabled in
Release by default. We add a new flag 'angle_assert_always_on'
for controlling ANGLE ASSERT behaviour.
Also slightly refactors the direct SPIR-V generation GN.
Chromium CL: https://crrev.com/c/2893204
Bug: chromium:1225701
Change-Id: I01a6def28d7c21e771e9800889a6b9c274972de2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035447
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
Reviewed-by: Dirk Pranke <dpranke@google.com >
Reviewed-by: Geoff Lang <geofflang@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-07-19 19:05:44 +00:00
angle-autoroll
783c2f93ba
Roll Chromium from 7d1a6713a379 to 624f8c7a15ff (526 revisions)
...
7d1a6713a3..624f8c7a15
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: 70f58488ed..9c63d2e3b0
* testing: e065358b5a..d749d1b98b
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ {catapult_..3345f09ed6
* third_party/zlib: 199485df6c..f376b41126
* tools/clang: 3fa819890a..aca9f71bde
* tools/luci-go: git_revision:2f836b4882d2fa8c7a44c8ac8881c3a17fad6a86..git_revision:2ac8bd9cbc20824bb04a39b0f1b77178ace930b3
* tools/luci-go: git_revision:2f836b4882d2fa8c7a44c8ac8881c3a17fad6a86..git_revision:2ac8bd9cbc20824bb04a39b0f1b77178ace930b3
* tools/luci-go: git_revision:2f836b4882d2fa8c7a44c8ac8881c3a17fad6a86..git_revision:2ac8bd9cbc20824bb04a39b0f1b77178ace930b3
* tools/mb: 783612b47d..1820a3adb0
* tools/perf: 511dbaffd9..6dad62e2eb
* tools/skia_goldctl/linux: tu1vY2W9BQ6Wx0o3zk5oqBwnr5rfFQGiaztbTpGiRNgC..R0Jd4IlcndZlI5C9Pejy7DqtmVEQT8Sc6Ye09MGyFxYC
* tools/skia_goldctl/mac: DPVSayDIq4ga78XaXXcfTzeTE2v33yM8z1w-eaD-ZuQC..5NoUEq08DuYUlQWnf2yj6rQvBtlMvWiDqfuUuE5nJFIC
* tools/skia_goldctl/win: HMJwTrgrkRmSqDuyQtWly6YxYSHJXsM6zQJFLkojAVwC..M2_R9AXWaN0xmm6nz_nRzKlhpzzOp3P9EUxNaLZ5owMC
No update to Clang.
Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ie14d842df225cfc1f60d087386147904a8120ae4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3023670
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2021-07-13 09:53:34 +00:00
Takuto Ikuta
d91af7b8d9
infra/config: remove unused isolated property
...
angle is migrated to RBE-CAS from isolate.
Bug: chromium:1224266
Change-Id: Id2ca778edf6b34f5241da0fbfcd86b43941f83b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007600
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-07-06 12:49:11 +00:00
Jamie Madill
ec8cdd5d4d
infra: Add perf tests to Android/Linux/Mac.
...
These use the same config as the previous perf bots.
Bug: angleproject:6090
Change-Id: I0ed4bc32cdc5b27f1fbd00fded1fa8d2ccbe45d9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993458
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-06-29 21:48:15 +00:00
Jamie Madill
72c8d46dfc
infra: Build traces on perf bots.
...
This is necessary to ensure they run the trace tests in perf.
Bug: angleproject:6090
Change-Id: Ib96418c4371f700dbbd54933241b1b88912f9938
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2991903
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-06-29 12:21:05 +00:00
Jamie Madill
8b24e2a4f7
infra: Add perf mb configs.
...
This will set up the GN args for the perf builders.
Bug: angleproject:6090
Change-Id: I3c00a5b78932ae41199953a46c525b435b566d12
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2989669
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-06-25 19:27:21 +00:00
Jamie Madill
8b4f6e6db0
infra: Add perf configs.
...
Adds Win/Linux/Android configs.
Bug: angleproject:6090
Change-Id: Ie80a12a16997aab08e9dbba0cc0a9b14414fc8f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988793
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-06-25 18:11:06 +00:00
Yuly Novikov
cc280ff33e
Remove obsolete Android bots from CQ
...
android-angle-chromium-try + android-angle-try replace
android_angle_deqp_rel_ng + android_angle_rel_ng
Bug: angleproject:4483
Change-Id: I96d51ee610ca7b025e1976d0076409c4990836c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988792
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
2021-06-25 15:47:10 +00:00
Jamie Madill
ce22ad1042
infra: Add symbol_level=1 in Release.
...
This should enable better crash file/line information.
Bug: angleproject:6070
Change-Id: I54280461160f2ac6404dbd4b88abdcfd31f3814e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2971956
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-06-18 20:27:19 +00:00
Ian Elliott
f89f244d52
Doc: Add component info for filing Chromium bugs
...
Bug: None
Change-Id: I7b8517e2312174a2e2b9221b7c99425978406024
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2966011
Reviewed-by: Kenneth Russell <kbr@chromium.org >
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: Ian Elliott <ianelliott@google.com >
2021-06-17 00:51:36 +00:00
Yuly Novikov
c7c3cac090
Add Android chromium.angle bots to CQ
...
Bug: angleproject:4483
Change-Id: I5a2d76bb9f5183752cbcd6f9381c4aef83edecd7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2950267
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
2021-06-11 04:50:58 +00:00
Yuly Novikov
166dd0c75c
Roll chromium_revision 6c5859c895..399855f4bb (890175:891326)
...
Manual changes:
1. Fix generate_test_spec_json.py to correctly handle ADDITIONAL_MIXINS
Needed after angle_skia_gold_test mixin removed from Chromium in
crrev.com/890333
2. Copy third_party/logdog from Chromium
Needed after crrev.com/890539 in order to create isolates on Android
and for tools/perf/process_perf_results.py
Change log: 6c5859c895..399855f4bb
Full diff: 6c5859c895..399855f4bb
Changed dependencies
* build: 8870cb4120..2192a63c23
* buildtools: c793cca886..9d8449e380
* buildtools/linux64: git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810..git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa
* buildtools/mac: git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810..git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa
* buildtools/third_party/libc++abi/trunk: 7e3b76855b..2c53623d59
* buildtools/win: git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810..git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa
* testing: a62f8260df..ab567bcc84
* third_party/abseil-cpp: 7949d87093..bd17c406ba
* third_party/android_deps: 887e8d9009..fa47598982
* third_party/android_sdk: 1cfc90728e..816daa2545
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ {catapult_..17cf72ca75
* third_party/depot_tools: b508ecd932..6d099d543d
* third_party/nasm: 19f3fad68d..e9be5fd6d7
* third_party/protobuf: 82f8803671..f4241bd0f2
* third_party/turbine: _iPtB_ThhxlMOt2TsYqVppwriEEn0mp-NUNRwDwYLUAC..Om6yIEXgJxuqghErK29h9RcMH6VaymMbxwScwXmcN6EC
* tools/clang: 09481f56be..fd14318cc9
* tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:725192cc79f07ea946e10a64baac06625c206968
* tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:725192cc79f07ea946e10a64baac06625c206968
* tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:725192cc79f07ea946e10a64baac06625c206968
* tools/mb: 94630dfc19..12c8fa872b
* tools/perf: 5c84710692..2e6477d751
DEPS diff: 6c5859c895..399855f4bb /DEPS
Clang version changed llvmorg-13-init-11999-g50c0aaed:llvmorg-13-init-12491-g055770d5
Details: 09481f56be..fd14318cc9 /scripts/update.py
Bug: angleproject:4483, angleproject:6037
Change-Id: I9035126bce55642d4dfce54eeace85093bdd1782
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2954241
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
2021-06-10 23:52:34 +00:00
Jamie Madill
c778f93f7e
infra: Reduce sharding on GLES3 GL/Metal tests.
...
Bug: None
Change-Id: I56593374d027db20a5ed0ebf09ca2210e219f244
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2945431
Commit-Queue: Jamie Madill <jmadill@chromium.org >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
2021-06-08 21:15:33 +00:00
Jamie Madill
3bc28a2723
infra: Add flaky retries to Metal GLES 3 tests.
...
These have been somewhat flaky on the waterfall.
Bug: angleproject:6019
Change-Id: I4d76411ab54ad5fbfb9c49775c44a12b99def846
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2945430
Commit-Queue: Jamie Madill <jmadill@chromium.org >
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
2021-06-08 05:25:56 +00:00
Jamie Madill
d99864c0fa
Gold Tests: Fix flaky test handling.
...
Indead of just retrying the batch, retry individual tests.
This should correctly handle the Intel flake pattern.
Bug: angleproject:5415
Change-Id: I029c2514ff8e7a45184c5c105bf2d0350171da29
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2940049
Commit-Queue: Jamie Madill <jmadill@chromium.org >
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
2021-06-08 05:12:46 +00:00
Jamie Madill
f03f7bdb72
infra: Don't run trace tests in perf smoke tests.
...
These test were already being run more safely in the gold tests step.
Bug: angleproject:5977
Change-Id: I4fb1062926fcda19384835723555d0fab0b42aae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939469
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-06-08 04:33:16 +00:00
Jamie Madill
2917ab347b
infra: Override Gold mixin.
...
This mixin is being removed from the Chromium version of the mixins.
Therefore we have to move it into the additional mixins option of the
generator.
Bug: angleproject:6037
Change-Id: I605b7cbf35d6282754bf5fb26246e32b2edcea10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939466
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-06-08 04:30:06 +00:00
angle-autoroll
a14a806c76
Roll Chromium from b078d3ef5de8 to 5ffd2ab3bece (403 revisions)
...
b078d3ef5d..5ffd2ab3be
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Changed dependencies
* build: 20ee3d5c60..bf4ecd926c
* buildtools: cd7b8c0c22..eb65cc3594
* testing: b97a23bcf3..f39abc2692
* third_party/android_deps: bb99706b87..baaf1482ba
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ {catapult_..712eb08096
* third_party/depot_tools: c8f63d390c..9705687c25
* tools/clang: 19eadef5e7..af7a363dfe
* tools/luci-go: git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e..git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0
* tools/luci-go: git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e..git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0
* tools/luci-go: git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e..git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0
* tools/skia_goldctl/linux: SIbSqtgKfmhBASeojfVyHGkIx2ZItagJYLeJt9yef1oC..fVbmAq5SyEKlNV_cPvOrlJbBRmDAWApv309sIMdbgq8C
* tools/skia_goldctl/mac: WB42GE3e_7-dR5RnBBCICQtMkfpOoJvlT9tMG_6Fj1UC..SGAjTHEDDOpAgPQYJcSEmMh4E6afvlKQKzBjwSTf5dwC
* tools/skia_goldctl/win: BL1QYX6LBgah6_XEB3KHs9jZiFQtq2z8PUZRswCFvN8C..hySBvc3hf9NRFmfS2oG52F9ZzLpvX9bFuyybtZ92CNAC
Clang version changed llvmorg-13-init-10392-gd3676d4b:llvmorg-13-init-11649-g4d788fb8
Details: 19eadef5e7..af7a363dfe /scripts/update.py
Bug: None
Tbr: ynovikov@google.com
Change-Id: I21b2bbea54c6f43c1c7c7ab540af8eee345d7c41
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939486
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2021-06-04 08:18:06 +00:00
Cody Northrop
71584e3636
Tests: Disable trace compilation for MSVC and GCC
...
New traces are hitting string literal limits with MSVC. Since we
don't use MSVC or GCC for trace development or testing, this CL
disables trace compilation for non-clang setups.
Bug: b/181794064
Bug: angleproject:6009
Change-Id: I0377792a049153a5505ecda4346a3cec57c12e9e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2922682
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: Cody Northrop <cnorthrop@google.com >
2021-06-02 22:20:21 +00:00
Jamie Madill
163f6ac055
Gold Tests: Add batching.
...
This should speed up test runs on Android, which are currently much
slower than the other platforms.
Bug: angleproject:5966
Change-Id: I57890522b64d1d195ea0be56b4f68b6d54192d64
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2919888
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-05-26 19:51:37 +00:00
Jamie Madill
17c45b6535
infra: Shard restricted_trace_gold_tests.
...
Reduces shard time from 50+ min to <10 min per shard.
Bug: angleproject:5966
Change-Id: Ia230d71a66ac9a273a10e0389cc04d8c5737bc4a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2915566
Commit-Queue: Jamie Madill <jmadill@chromium.org >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
2021-05-26 15:05:56 +00:00
Jamie Madill
cf24370562
infra: Remove Pixel 2 (android_vk) tests from CQ.
...
These tests are now fully running on the Pixel 4.
Bug: angleproject:5941
Change-Id: Ic0bb094c917226867c3b34ede19986e95ce69b7f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2915565
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-05-26 14:19:04 +00:00
Jamie Madill
fad9053f81
infra: Add isolated script tests to Pixel 4.
...
This includes angle_perftests and angle_restricted_trace_gold_tests.
Bug: angleproject:5941
Change-Id: I6f24d2c2752086ae6f7abba26880070c4a4f0472
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2911034
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Reviewed-by: Cody Northrop <cnorthrop@google.com >
2021-05-21 23:02:44 +00:00
Jamie Madill
c71fbc162e
infra: Add dEQP tests to the Pixel 4.
...
Also updates expectations. For simplicity we use SKIP everywhere and
specify each skipped test individually instead of using wildcards.
Bug: angleproject:5941
Change-Id: If2cb85b06ecd250222dbf1376d99392ad10b71aa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2896172
Reviewed-by: Geoff Lang <geofflang@chromium.org >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-05-20 17:32:56 +00:00
Jamie Madill
328a5c89d9
infra: Add tests to Android Pixel 4 bot.
...
Only angle_end2end_tests and angle_unittests to start.
Also adds test expectations for the Pixel 4 end2end_tests.
Patch Series:
1. http://crrev.com/c/2885381
2. http://crrev.com/c/2885346
3. http://crrev.com/c/2885383
4. This CL
Bug: angleproject:5941
Bug: angleproject:5946
Bug: angleproject:5947
Bug: angleproject:5981
Change-Id: Iaaea0b427513804575d0ad7773a81379ea932eb5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885384
Commit-Queue: Jamie Madill <jmadill@chromium.org >
Reviewed-by: Geoff Lang <geofflang@chromium.org >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
2021-05-18 18:32:49 +00:00
angle-autoroll
cf1064e67d
Roll Chromium from fff9d6fb8ddf to 3fb708290557 (495 revisions)
...
fff9d6fb8d..3fb7082905
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Changed dependencies
* build: 4ff4105cd8..129bd6c0c0
* testing: 504fae9f10..43828a290e
* third_party/abseil-cpp: 93eae7d9dc..371f2bea4f
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ {catapult_..302ca09b2d
* third_party/depot_tools: cb17bc6028..6e5b0a5c45
* third_party/protobuf: 5243354177..66e0a5d62b
* third_party/zlib: 618ddecd59..c3edbeed8a
* tools/clang: e76c8f17cf..53a9334ffe
* tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1
* tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1
* tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1
* tools/mb: df10bb0bf8..ac77520e0e
* tools/skia_goldctl/mac: 5o7ziB6qRrSdtYJwKop8-5OFmvVQcxuNkGY1DRYggMsC..qwctaMZfXlU0u7OsbxWgOY_sBjsUYhlqwjJRbAXX3oYC
Clang version changed llvmorg-13-init-7296-ga749bd76:llvmorg-13-init-9302-g897d7bce
Details: e76c8f17cf..53a9334ffe /scripts/update.py
Bug: None
Tbr: timvp@google.com
Change-Id: Iff9b5446b67a948eeb60e1aa7aaacf0725714c05
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891629
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com >
2021-05-12 08:33:29 +00:00
Jamie Madill
cd535d2cce
infra: Switch Android ARM64 bots to compile-and-test.
...
This will start to trigger tests on the Pixel 4 64-bit bots.
Patch Series:
1. http://crrev.com/c/2885381
2. http://crrev.com/c/2885346
3. This CL
4. http://crrev.com/c/2885384
Bug: angleproject:5941
Change-Id: Ib76fd27d0814896522aad84443f52b7f47566e85
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885383
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-05-11 19:19:27 +00:00
Jamie Madill
6e3c5321c6
infra: Remove old TODO.
...
Bug: angleproject:5114
Change-Id: I3b7255cc06bffd177f0b5ee8cad12bf2aad3089e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885382
Commit-Queue: Jamie Madill <jmadill@chromium.org >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
2021-05-11 16:53:08 +00:00
Jamie Madill
930db29463
infra: Add Android swarming spec placeholder.
...
These will trigger tests on the Pixel 4 in standalone. For
now we do not specify any tests.
Patch Series:
1. This CL
2. http://crrev.com/c/2885346
3. http://crrev.com/c/2885383
4. http://crrev.com/c/2885384
Bug: angleproject:5941
Change-Id: Iad1bc27c316724b244fbfbf694f6e83fdf5c0507
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885381
Commit-Queue: Jamie Madill <jmadill@chromium.org >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
2021-05-11 15:53:27 +00:00
Jamie Madill
91429bb159
infra: Remove duplicated trybots from the CQ.
...
Removes duplicate Linux, Win and Mac testing.
These are superceded by the standalone bots now.
Android is still entirely Chromium-based.
Bug: angleproject:5114
Change-Id: I745758547b2eaa5f82779b11e7f3a8512c3cdd94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2872072
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-05-10 14:11:04 +00:00
Jamie Madill
e61909f655
infra: Re-enable swarming tests.
...
Changes since the revert:
- Include runtime_deps: http://crrev.com/c/2878093
- Add missing perf scripts: http://crrev.com/c/2877011
- Include build_properties: http://crrev.com/c/2878373
Bug: angleproject:5114
Change-Id: If7d1e5693c4ade72d3f45f5d60635cb27de7599e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877012
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-05-07 19:56:25 +00:00
Jamie Madill
1572c3728e
infra: Temporarily disable all swarming tests.
...
There seem to be some unusal failures on CI. Maybe Try as well.
Bug: angleproject:5114
Change-Id: Ia681d6fdb8575b851dd526c1ab9463ad047735c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875767
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-05-06 14:30:26 +00:00
Jamie Madill
c75969e1dc
Revert "Temporarily remove standalone tester bots from CQ."
...
This reverts commit 8f26346b53 .
Reason for revert: Should be fixed by updated exclusion spec.
Original change's description:
> Temporarily remove standalone tester bots from CQ.
>
> Due to RECIPE CRASH, e.g.
> https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/21245/overview
>
> No-try: true
> Bug: angleproject:5114
> Change-Id: I42f76fb370ee5423430955643bffb8c2204fa25f
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875717
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
Bug: angleproject:5114
Change-Id: I781a5a409a9ede005feaf0f3d7bcedac31eaa036
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876986
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-05-06 13:38:20 +00:00
Jamie Madill
aa19de17d2
infra: Fix exclusion spec JSON.
...
The extra comma caused the CQ to fail reading the file.
Bug: angleproject:5114
Change-Id: I5d36f1ae7c4dc5ebcb5599d5cd37471ee4085990
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876985
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-05-06 13:37:26 +00:00
Yuly Novikov
8f26346b53
Temporarily remove standalone tester bots from CQ.
...
Due to RECIPE CRASH, e.g.
https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/21245/overview
No-try: true
Bug: angleproject:5114
Change-Id: I42f76fb370ee5423430955643bffb8c2204fa25f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875717
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Yuly Novikov <ynovikov@chromium.org >
2021-05-06 02:28:41 +00:00
Jamie Madill
0fb204bdbf
infra: Exclude infra/specs from analyze.
...
This will force any changes to the infra/specs folder to trigger a
full set of tests on a builder.
Bug: angleproject:5114
Change-Id: Ie640b52dd7f12163d0c91843d80dbab7f33209d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875356
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-05-06 00:18:01 +00:00
Jamie Madill
db670c82bf
infra: Enable dcheck_always_on in Release.
...
This will assure that ANGLE ASSERT macros work in Release.
Bug: angleproject:5114
Change-Id: I0fe6b83592ac3ff3462e55b8a73a11c8f114a4a7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875355
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-05-05 22:51:58 +00:00
Jamie Madill
167480ccbe
infra: Switch CI to use component builds everywhere.
...
This makes the build the same as the Chromium-based configuration.
This also works around a problem with the Mac bots where the
shader cache workaround isn't operational in non-component builds.
Bug: angleproject:5114
Bug: angleproject:5928
Change-Id: Ib466942f4a69e1ba3e61e078c84d74d0b54bb396
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875354
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-05-05 22:09:18 +00:00
Jamie Madill
18c9aa0dc3
Run test spec update as part of codegen.
...
Test specs now will be updated when the Chromium build files change.
It will be automatically included as part of the Chromium->ANGLE roll.
Bug: angleproject:5114
Change-Id: If99c2a20033d417a5999295f425a3bb203f5da3a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2860962
Commit-Queue: Jamie Madill <jmadill@chromium.org >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
2021-05-05 19:39:47 +00:00
Jamie Madill
167a4b6df9
infra: Add Linux isolated scripts to specs.
...
We were missing the perftests and Gold tests from Linux Intel/NV.
Bug: angleproject:5114
Change-Id: I1cfc0963b3890c621f0646bb5879e47ea6d336a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2873457
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-05-05 18:09:25 +00:00
Andrii Shyshkalov
ab3b50bcde
[infra][realms] upgrade to LUCI security realms in all Angle builds.
...
To be landed after ~1 day at 25% if all is well.
Change-Id: I106add7cc9103bde8d77a1c61438ad0fcb54a7b3
Bug: chromium:1204972
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867636
Commit-Queue: Andrii Shyshkalov <tandrii@google.com >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
Reviewed-by: Jamie Madill <jmadill@chromium.org >
2021-05-04 21:56:34 +00:00
Jamie Madill
83a1a385c6
infra: Add trybot_analyze_config.
...
This file is used to specify ignores and excludes for analyze.
Initially only contains DEPS. Whenever a file in exclusions is
changed, we'll run the entire CQ instead of only the affected tests.
Bug: angleproject:5114
Change-Id: Ie7328604f5ee56288f992710d5c3dbc559e6d9a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867886
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
Commit-Queue: Jamie Madill <jmadill@chromium.org >
2021-05-03 19:02:18 +00:00
Andrii Shyshkalov
dd4564cacc
[infra][realms] bump usage to 25% of all builds.
...
Change-Id: I106add7749103bde8d77a1c61438ad0fcb54a7b3
Bug: chromium:1204972
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867633
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: Andrii Shyshkalov <tandrii@google.com >
2021-05-03 18:43:56 +00:00
Andrii Shyshkalov
03a9bf1ea4
[infra] use realms on 5% of Angle builds.
...
All swarming tasks triggered from realm-enabled build will be
realm-enabled, too.
This CL is safe to revert in case of problems.
The problems, if any, should not affect CQ badly due to retries,
but on CI they'd probably manifest as purple builds that won't be
retried without human involvement or new Git commit.
Change-Id: I106a587749103bde8d77a1c61438ad0fcb54a7b3
Bug: chromium:1204972
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867083
Commit-Queue: Andrii Shyshkalov <tandrii@google.com >
Reviewed-by: Jamie Madill <jmadill@chromium.org >
2021-05-03 15:33:17 +00:00
Andrii Shyshkalov
32ed50698d
infra: init LUCI Realms config for Angle.
...
This doesn't yet have any effect on Angle builds/tasks,
but allows to associate Angle pools with the Realms config in
https://crrev.com/i/3802849
Change-Id: Id756c14e7e181cc1820cee735668949bf9567d0c
Bug: chromium:1204972
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867082
Commit-Queue: Andrii Shyshkalov <tandrii@google.com >
Reviewed-by: Jamie Madill <jmadill@chromium.org >
2021-05-03 15:12:47 +00:00
Andrii Shyshkalov
de3753d4b9
infra: validate configs using lucicfg tool in PRESUBMIT.py
...
This validates that:
a) checked in generated files correspond to what lucicfg
actually generates;
b) lucicfg is formatted
c) (same as before) configs are validated against respective
LUCI services.
Change-Id: I727723beb4172c3dd265c4a4edbc2ecbfb479eb9
Bug: chromium:1204972
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867081
Commit-Queue: Andrii Shyshkalov <tandrii@google.com >
Reviewed-by: Jamie Madill <jmadill@chromium.org >
2021-05-03 15:08:47 +00:00
Andrii Shyshkalov
471e62c88a
infra: remove redundant ACL.
...
Bug: chromium:1204972
Change-Id: If3ab89699adfc47d0a163f8b999da17b10d86ebd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867079
Commit-Queue: Andrii Shyshkalov <tandrii@google.com >
Reviewed-by: Jamie Madill <jmadill@chromium.org >
2021-05-03 14:54:20 +00:00
John Plate
df657c96f1
Disable OpenCL support for Windows UWP CI builds
...
Bug: angleproject:5908
Change-Id: I451e232e545248ff9755cc3f2a4907b8af2fdc2c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859742
Reviewed-by: Jamie Madill <jmadill@chromium.org >
Commit-Queue: John Plate <jplate@google.com >
2021-04-29 17:04:15 +00:00
Jamie Madill
a29ab50f60
infra: Add isolate server properties.
...
These are necessary to work correctly with swarming.
Bug: angleproject:5114
Change-Id: I634e408e523284a935b77f62b95c9bc85e9e997f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859982
Commit-Queue: Jamie Madill <jmadill@chromium.org >
Reviewed-by: Yuly Novikov <ynovikov@chromium.org >
2021-04-29 17:03:25 +00:00