godotengine/godot-angle-static
1
0
Fork 0
mirror of https://github.com/godotengine/godot-angle-static.git synced 2026-01-07 06:09:57 +03:00
Code Issues Packages Projects Releases Wiki Activity
21,459 Commits 3 Branches 8 Tags
7de7b9a4f61538880a8cf1fc374f986c9df5b26d
Commit Graph

1600 Commits

Author SHA1 Message Date
angle-autoroll
7de7b9a4f6 Roll vulkan-deps from 869b279baef4 to 03c816988bfd (17 revisions) 
https://chromium.googlesource.com/vulkan-deps.git/+log/869b279baef4..03c816988bfd

Changed dependencies:
* glslang: 3ebb72cc74..eaa7057768
* spirv-tools: 870fd1e17a..4be7d0e3ca
* vulkan-headers: 179b26a792..2565ffa31e
* vulkan-loader: 9d38cccf33..8b94e87bff
* vulkan-tools: 39090f9152..6e7fa4d975
* vulkan-validation-layers: db466666ac..db290809b5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Idb10483c233a386723d71bd478c396ba5546947c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675703
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2023-07-11 11:03:13 +00:00
Shahbaz Youssefi
04c0cc8d59 Simplify aliasing-exception logic in entry point generation 
Bug: angleproject:8224
Change-Id: Ic54c233ab3d8a0f9a1ac803804aea770c6f7cc07
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672145
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-07-07 20:06:31 +00:00
Shahbaz Youssefi
51320fab57 Make most GLES1 entry points lockless 
These entry points only set context-local state and thus don't require
locking.

Bug: angleproject:8224
Change-Id: I80223340348d62a56109324ab3e4f935e53419b3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4670407
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-07-07 19:51:12 +00:00
Shahbaz Youssefi
eb205e689d Make the glPatchParameteri entry point lockless 
This entry points only sets context-local state and thus doesn't require
locking.

Bug: angleproject:8224
Change-Id: I17975a97aa7f68c3ddf2ef78069b8f519fdc4c1a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4670405
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com>
 2023-07-07 19:42:31 +00:00
Shahbaz Youssefi
7e0fb7e402 Make glIsEnabled* entry points lockless 
These entry points only set context-local state and thus don't require
locking.

Bug: angleproject:8224
Change-Id: I6fe40bf4381e1d42248358f773ec9d5675883ada
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666356
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-07-07 04:17:53 +00:00
Shahbaz Youssefi
72c269263c Make pack/unpack and hint entry points lockless 
These entry points only set context-local state and thus don't require
locking.

Bug: angleproject:8224
Change-Id: I5694d319df61a7a9df1766cf1f723b9a05208209
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666352
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-07-07 03:53:06 +00:00
Shahbaz Youssefi
208dfe2860 Make glStencil* entry points lockless 
These entry points only set context-local state and thus don't require
locking.

Bug: angleproject:8224
Change-Id: I612d8219ba038464173490b2c261e9e7b229c83f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661702
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-07-07 01:23:26 +00:00
Shahbaz Youssefi
c3c2f45046 Make glBlend* entry points lockless 
These entry points only set context-local state and thus don't require
locking.

Bug: angleproject:8224
Change-Id: Ie811c35ae7b65106db9af9f7531ad3a5e0bd4f8c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661701
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-07-07 00:32:19 +00:00
Shahbaz Youssefi
4439593002 Make various state setting entry points lockless 
These entry points only set context-local state and thus don't require
locking.

Bug: angleproject:8224
Change-Id: I428c23cc862e9356d571bc085b5df0bf48017175
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661700
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-07-06 23:38:50 +00:00
Shahbaz Youssefi
9daac2b7dd Make glEnable/Disable entry points lockless 
These entry points only set context-local state and thus don't require
locking.

Bug: angleproject:8224
Change-Id: Id4eab729115bd75f82e1ec7a27355c821a7c4320
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661697
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
 2023-07-06 21:04:53 +00:00
Shahbaz Youssefi
0892420bcf Vulkan: Optimize PBO download between RGBA and BGRA 
Google Meet hits this path in Chrome when blurring the background.  The
CPU readback was particularly slow on Intel/Mesa where readback from the
temp buffer took hundreds of milliseconds.

This change adds a compute shader that directly copies from the image to
the pack buffer in simple but common cases.

Bug: b/286882707
Change-Id: I9877ea01e3d8377db96f2539362aca67cf832b4a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4657058
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
 2023-07-06 17:45:07 +00:00
Shahbaz Youssefi
be41fe2949 Make glColor/DepthMask entry points lockless 
These entry points only set state that is entirely accessed by the
owning context (context-local) and thus don't require locking.
glColorMask* functions also affect the cached context state (in
particular draw validity), so the relevant cached state is also modified
to support being locklessly modified.

Bug: angleproject:8224
Change-Id: I221b4efa25fc1c11419d1ac942f1c37e59ec92c0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4658173
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-07-06 16:49:07 +00:00
Cody Northrop
ec8fb51b69 Tests: Add Evony: The King's Return trace 
Test: angle_trace_tests --gtest_filter="*evony_the_kings_return*"
Bug: b/266237531
Bug: b/275096133
Change-Id: I32daa8b1bd4f3253887d02a5127ef4682df4951a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4664602
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
 2023-07-05 19:51:21 +00:00
Shahbaz Youssefi
4db1308136 Make glClearColor/Depth/Stencil entry points lockless 
These entry points only set state that is entirely accessed by the
owning context and thus don't require locking.

Bug: angleproject:8224
Change-Id: I6cddee865ffd38e228f8f87dd14adffb916e0fed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4658172
Reviewed-by: Igor Nazarov <i.nazarov@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-07-05 18:52:57 +00:00
angle-autoroll
cb5cd76d1e Manual roll vulkan-deps from 2b2cba62bfea to e21365bc9170 (38 revisions) 
Manual roll requested by ynovikov@google.com
Suppress new VUIDs:
    "VUID-vkCmdDrawIndexed-None-08608",
    "VUID-vkCmdDraw-None-08753",
    "VUID-vkCmdDrawIndexed-None-08753",

https://chromium.googlesource.com/vulkan-deps.git/+log/2b2cba62bfea..e21365bc9170

Changed dependencies:
* glslang: 9575e33186..3ebb72cc74
* spirv-cross: 2d3a152081..b8e742c91b
* spirv-tools: 310a67020a..58459c2b1a
* vulkan-headers: b6a29e5ca8..ad5f8ee975
* vulkan-loader: a1d9d485ce..dce85674e2
* vulkan-tools: 247c806c93..2e5260d44c
* vulkan-validation-layers: 926ffb1f41..4400858043

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC
angle-team@google.com,ianelliott@google.com,ynovikov@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: angleproject:8242
Change-Id: I475146b418565e633043f6b57cb07baedcff02ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4662877
Commit-Queue: Ian Elliott <ianelliott@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
 2023-07-04 18:24:43 +00:00
angle-autoroll
0e8a8e0f16 Roll VK-GL-CTS from 12bc45af35d5 to e7b180ad5366 (12 revisions) 
12bc45af35..e7b180ad53

2023-07-03 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.6
into vk-gl-cts/main
2023-06-30 lorenzo@khronosgroup.org Merge "Merge remote-tracking branch
'vk-gl-cts/vulkansc-cts-1.0.1'" into main
2023-06-30 aitor@lunarg.com Add EGL_ANDROID_RECORDABLE to config testing
2023-06-30 rgarcia@igalia.com Add GPL variants to fragment shader
barycentric tests
2023-06-30 rgarcia@igalia.com Test tessellation state switches
2023-06-30 cturner@igalia.com Vk Video: Upgrade the NVIDIA parser
interface to version 0.9.9
2023-06-30 paulthomson@google.com Skip dEQP-VK.api.info.android.* if not
Android
2023-06-30 scerveau@igalia.com cts: add deviceName to SessionInfo
2023-06-30 rgarcia@igalia.com Test maxSamplerLodBias
2023-06-30 cturner@igalia.com Update handling of field flags for
improved compatibility.
2023-06-26 gleese@broadcom.com Switch float controls tests from deBool
to C++ bool
2023-06-26 gleese@broadcom.com Remove duplicate direct linking options

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,ianelliott@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I55e947c71f921d7ef55ffb5f2b61b0a19f304170
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4662878
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2023-07-03 18:47:15 +00:00
angle-autoroll
574d163f57 Manual roll vulkan-deps from 23a32754e715 to 2b2cba62bfea (29 revisions) 
Manual roll requested by ynovikov@google.com

https://chromium.googlesource.com/vulkan-deps.git/+log/23a32754e715..2b2cba62bfea

Changed dependencies:
* spirv-headers: 10db9d4e19..3469b164e2
* spirv-tools: 54691dcd73..310a67020a
* vulkan-headers: c1a8560c5c..b6a29e5ca8
* vulkan-loader: b02d69f3a1..a1d9d485ce
* vulkan-tools: 07924a8a49..247c806c93
* vulkan-validation-layers: cb9c77d609..926ffb1f41

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC
angle-team@google.com,ianelliott@google.com,ynovikov@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com,ynovikov@google.com
Change-Id: I4b5e433bdd24644f6e502f10f21974b670b2a0b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4662876
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2023-07-03 15:30:50 +00:00
angle-autoroll
f015b25357 Roll VK-GL-CTS from f29bd2feeaff to 12bc45af35d5 (10 revisions) 
f29bd2feea..12bc45af35

2023-06-23 lorenzo@khronosgroup.org Merge remote-tracking branch
'vk-gl-cts/opengl-es-cts-3.2.9'
2023-06-23 piotr.byszewski@mobica.com Regenerate mustpass
2023-06-23 aitor@lunarg.com Test partial binding of depth/stencil images
2023-06-23 piotr.byszewski@mobica.com Test commands on transfer-only
queue
2023-06-23 cturner@igalia.com Allow DECODE_OUTPUT and DECODE_DPB
features for YCbCr formats
2023-06-23 matt.coster@imgtec.com Don't attempt pipeline library tests
without VK_KHR_pipeline_library
2023-06-23 rgarcia@igalia.com Test occlusion and frag shader inv counts
with flat shading
2023-06-23 alyssa@rosenzweig.io surfaceless: Fix shared contexts and
implement makeCurrent
2023-06-23 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.6
into vk-gl-cts/main
2023-06-22 alexander.galazin@imgtec.com Notice of withdrawal of Vulkan
CTS 1.3.3.x

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: solti@google.com
Change-Id: I96a35e762f3cd5585027a5afa84d160619ee02c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4646068
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2023-06-26 16:20:45 +00:00
angle-autoroll
174742fd66 Roll VK-GL-CTS from 7fcb3c6e0082 to f29bd2feeaff (19 revisions) 
Suppress dEQP-EGL failures.

7fcb3c6e00..f29bd2feea

2023-06-18 lorenzo@khronosgroup.org Merge vk-gl-cts/github-main into
vk-gl-cts/main
2023-06-16 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9
into vk-gl-cts/main
2023-06-16 piotr.byszewski@mobica.com Split pipeline.txt in vksc-default
2023-06-16 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.6
into vk-gl-cts/main
2023-06-16 alexander.galazin@imgtec.com Fix check_build_sanity.py error
2023-06-16 lorenzo@khronosgroup.org Add missing line in AndroidGen.mk
for vktFragmentShadingRateMiscTests.cpp
2023-06-16 rgarcia@igalia.com Test FSR in a pipeline without fragment
shader
2023-06-16 ziga@lunarg.com Add xfb test drawing outside of xfb begin
2023-06-16 piotr.byszewski@mobica.com Test RT interaction with flags
added by GPL
2023-06-16 rgarcia@igalia.com Test gl_SampleMaskIn with sample shading
2023-06-16 rgarcia@igalia.com Test enabling and disabling VRS statically
2023-06-16 rgarcia@igalia.com Test allocation and binding offsets with
index buffers
2023-06-16 pdaniell@nvidia.com Remove the "Error:" prefix with
NotSupported results
2023-06-16 jenatali@microsoft.com Fix skipping when synchronization2 is
unsupported on Windows
2023-06-16 gleese@broadcom.com Remove 64-bit test code for builtins
which don't support it
2023-06-16 jenatali@microsoft.com Don't include windows.h in the vk
namespace
2023-06-16 rgarcia@igalia.com Disallow direct linking of GLES libraries
by default
2023-06-16 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.6
into vk-gl-cts/main
2023-06-15 younggwan.kim@arm.com Merge dev/EXT_shader_tile_image into
main

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,syoussefi@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: angleproject:8214
Change-Id: I84598fb784adf1e30abbeaac3c53dcd97108d58a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4624553
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-06-20 13:35:54 +00:00
angle-autoroll
949d9e344b Roll vulkan-deps from 58c6e1ea988a to c5656423525b (18 revisions) 
https://chromium.googlesource.com/vulkan-deps.git/+log/58c6e1ea988a..c5656423525b

Changed dependencies:
* glslang: 72713baf74..5793fbd624
* spirv-tools: d33bea5847..a720a6926e
* vulkan-headers: cb71b646f1..c1a8560c5c
* vulkan-loader: bcfb502054..db51885950
* vulkan-tools: 17edcc1455..ca8bb4ee3c
* vulkan-validation-layers: 4d4fc0e5a2..fff7423f1c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,syoussefi@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I1268ec340ea63b9cf151e77a7e69ae1d261ba77d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4626257
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2023-06-19 11:05:12 +00:00
Roman Lavrov
f102184dd7 Make Test spec JSON generator hashless. 
Removes scripts/code_generation_hashes/Test_spec_JSON.json

Instead, run codegen in --verify-only mode and compare content.
This run during presubmits and is fast (~0.2s in my tests)

Similar to https://crrev.com/c/4604579

With this, should be able to auto-resolve conflicts in
infra/specs/angle.json

Also testing/buildbot/mixins.pyl
seems to have had hashes routinely updated by autorolls.

Bug: angleproject:8193
Change-Id: Ic1a657dbf464e6f4a8066ea8c5e18297e27a3b4c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4605467
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Roman Lavrov <romanl@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-06-15 15:31:38 +00:00
Yuly Novikov
df787cf049 Add ANGLE experimental SwiftShader builders 
For testing Ubuntu 22.04

Recipe-side CL http://crrev.com/c/4614428

Testers:
linux-exp-swiftshader
linux-exp-swiftshader-asan
linux-exp-swiftshader-tsan

Builders:
linux-exp-asan-test
linux-exp-tsan-test

Modify LUCI MILO console to show only the active experimental builders.

Bug: chromium:1380082
Change-Id: Iac74b606fca7b1762028cebf4868e691b3ed074c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4614533
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
 2023-06-15 15:16:18 +00:00
angle-autoroll
e8a29d6cd7 Roll Chromium from bfc7c889fd6c to 7df45c601f1c (609 revisions) 
bfc7c889fd..7df45c601f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,syoussefi@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: a838ac9f43..1889753ce5
* buildtools/linux64: git_revision:1cd35c1b722472e714c30d12031af81443bb20ae..git_revision:4bd1a77e67958fb7f6739bd4542641646f264e5d
* buildtools/mac: git_revision:1cd35c1b722472e714c30d12031af81443bb20ae..git_revision:4bd1a77e67958fb7f6739bd4542641646f264e5d
* buildtools/win: git_revision:1cd35c1b722472e714c30d12031af81443bb20ae..git_revision:4bd1a77e67958fb7f6739bd4542641646f264e5d
* testing: ed771cb046..da030c5a1c
* third_party/abseil-cpp: 85f7b5752b..834450f113
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..89fad9023d
* third_party/depot_tools: 2b19afb820..dedeb88991
* third_party/fuchsia-sdk/sdk: version:13.20230613.4.1..version:13.20230614.3.1
* third_party/r8: AostPkk2hQv2Pz7k7JMtoD346t5IWWll26jAdkVHk2wC..vw5kLlW3-suSlCKSO9OQpFWpR8oDnvQ8k1RgKNUapQYC
* tools/clang: 21289a1a1b..573d371dff
* tools/luci-go: git_revision:e99800d3fd42249c9cdda3f58ba31c674b4876f6..git_revision:39f255d5875293d3e1d978888b819ac124a8b0cc
* tools/luci-go: git_revision:e99800d3fd42249c9cdda3f58ba31c674b4876f6..git_revision:39f255d5875293d3e1d978888b819ac124a8b0cc
* tools/mb: b69b0ca417..bf6c9c4977
* tools/perf: 1b905778b8..3a42bc4aaa
* tools/skia_goldctl/linux: TCcuUOFbPU3igS_xlEVBu_d1nZ71zngQ3oL-Bdm0GOoC..tVDltUu_xw7_tk4k-rnp7Ua8pKhf3EEHmTwX5c6BS4AC
* tools/skia_goldctl/mac_amd64: Btg2SHJpGjd1aivMSCt0RT5G6j33TDTYYfLANClZApYC..ov_DuOSHCneWQSTW6AZ9gWHEeoJxXEYDX9dl_0rA_d0C
* tools/skia_goldctl/mac_arm64: SW3HcHhCf69xzWwap7_fHNSualUgKeG_3N6xTMmVuVoC..3wDkZAVD4vV1dNhXfRNMOUBvODbzJ23AVmmsFbTsbkQC
* tools/skia_goldctl/win: yDoSOjnzDYE9APn8a3d-FcPJ6wwwq2FXWUTOJpf2__8C..yW7os_HVMoE-wq04olb6B7GNgEmaYZYPN0ecTzPPBdkC
No update to Clang.

Bug: None
Tbr: syoussefi@google.com
Change-Id: I9b6216bdb66bdc0c30c64226a785ec25e2da3b2a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4617669
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2023-06-15 08:26:25 +00:00
Igor Nazarov
36c3e0f546 Implement "Shared Context Mutex" functionality. 
Existing implementation uses single `GlobalMutex` for
- EGL calls
- GL calls for Contexts with concurrent access.

This CL introduces abstract `egl::ContextMutex` with two
implementations:
- SingleContextMutex;
- SharedContextMutex<Mutex>;

Note:
`std::mutex` is used in this commit. It is very easy to change mutex
type either at compile-time or at run-time (single type per Display).

When Context:
- is not Shared;
- does not use `EGLImage`s;
- does not use EGL_DISPLAY_TEXTURE_SHARE_GROUP_ANGLE
- does not use EGL_DISPLAY_SEMAPHORE_SHARE_GROUP_ANGLE
then it will be using `SingleContextMutex` with minimal overhead.

Before such Context is used as `shareContext` or uses `EGLImage`
its mutex replaced by `SharedContextMutex<Mutex>`.

The `GlobalMutex` is only used for EGL calls, while `egl::ContextMutex`
implementations for GL calls. Because some EGL calls use Context,
explicit `egl::ContextMutex` lock is required. This is implemented by
generating "egl_context_mutex_autogen.h" header, and insertion of
`ANGLE_EGL_SCOPED_CONTEXT_LOCK()` macro before `ANGLE_EGL_VALIDATE()`
in each EGL entry point. Implementation in "egl_context_lock_impl.h"
returns lock for required APIs. Special cases of `egl::ContextMutex`
lock handled separately. `std::unique_lock<>` is not used for
performance reasons.

`egl::ContextMutex` explicitly locked when capturing EGL calls.

Fixes EGLImage problem:
    e18240d136
    Mark contexts as shared when importing EGL images.

Details:
- EGLImage inherits Context's mutex when created.
  Mutex is used when the EGLImage accessed or destroyed.
- When EGLImage is used in Context with other `egl::ContextMutex`,
  two mutexes are merged into one.
- After the mutex merge, Context Groups will remain separate,
  but will not be able to run in parallel.

Fixes race when checking `context->isShared()` in the
`SCOPED_SHARE_CONTEXT_LOCK()` macro. One Context may start executing GL
call while not "Shared", but become "Shared" inside the call. New
(second) "Shared" Context may immediately start using GL and potentially
corrupt some "Shared" state.

Possible performance benefit: allows parallel execution in some cases,
when single `GlobalMutex` would block.

Important note:
    Process of replacing the `SingleContextMutex` by
    `SharedContextMutex<Mutex>` is not 100% safe. This mean that
    original Context may still be using `SingleContextMutex` after
    activating `SharedContextMutex<Mutex>`. However, this was always
    the case before introduction of this CL. Old `Context::mShared`
    member update was not synchronized in any way at all. In other
    words, this solution does not 100% fix the original problem.
    For 100% safe solution `SingleContextMutex` should not be used
    (always pass `SharedContextMutex<Mutex>` to the `gl::Context`
    constructor). See `lockAndActivateSharedContextMutex()` for more
    details.

CL adds new build option:
    angle_enable_shared_context_mutex = true

Behavior with other build options:
- When:
    `angle_enable_shared_context_mutex`    is disabled or
    `angle_enable_share_context_lock`      is disabled or
    `angle_force_context_check_every_call` is enabled,
  Contexts will always have `SingleContextMutex`, however it will be
  only used in special cases. `SCOPED_SHARE_CONTEXT_LOCK()` will use
  `GlobalMutex` when applicable.
- Otherwise, `SCOPED_SHARE_CONTEXT_LOCK()` will use `egl::ContextMutex`.

Some GFXBench "1080p Driver Overhead 2 Offscreen" performance numbers.
Tested on S906B (Samsung Galaxy S22+) on old ANGLE base:
    807c94ea85
    Capture/Replay: Adjust tests do adhere to capture limits

Each test result is an average frame number from 6 runs.

    SingleContextMutex                            6579 ( +0.13%)
    (old) GetContextLock() (mShared is false)     6570

Forced `mShared = true` or NOT using `SingleContextMutex`.

    SharedContextMutex<std::mutex> FORCE          5061 (-22.97%)
    (old) GetContextLock() FORCE                  4766 (-27.46%)

Bug: angleproject:6957
Bug: chromium:1336126
Change-Id: Idcd919f9d4bf482b9ae489bd8b4415ec96048e32
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4374545
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-06-14 16:59:15 +00:00
angle-autoroll
341dabf8e5 Roll vulkan-deps from 701c5daafb72 to cebf5626ca50 (30 revisions) 
https://chromium.googlesource.com/vulkan-deps.git/+log/701c5daafb72..cebf5626ca50

Changed dependencies:
* glslang: a6662c53ce..72713baf74
* spirv-cross: 030d0be28c..2d3a152081
* spirv-tools: 93c13345e1..40dde04ca2
* vulkan-headers: 605dc6d3e7..cb71b646f1
* vulkan-loader: c97930ba36..88d70047fb
* vulkan-validation-layers: ee8fe8140a..5cde5d21a3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,syoussefi@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Id2fb37c26ef6d6ca61d4b72a1c18dc5180e18654
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4614205
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2023-06-14 10:56:48 +00:00
angle-autoroll
1e06b31e38 Roll VK-GL-CTS from 7dc49a77dd0f to f7646f53ba61 (6 revisions) 
7dc49a77dd..f7646f53ba

2023-06-12 marcin.zajac@mobica.com Vulkan video capabilities tests for
1.3.253
2023-06-12 alexander.galazin@imgtec.com Merge vk-gl-cts-public/main into
vk-gl-cts/main
2023-06-12 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-cts-4.6.3
into vk-gl-cts/main
2023-06-12 piotr.byszewski@mobica.com Merge
vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main
2023-06-12 marcin.zajac@mobica.com Enabling storage image write support
2023-06-12 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.6
into vk-gl-cts/main

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,syoussefi@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Idf35864a0c0a40546477e0352fd35cd59613500b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4606371
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2023-06-13 07:47:04 +00:00
Roman Lavrov
1572f609c1 Disable hashes for ANGLE features generator 
Features autogen files are small, fast to regenerate.
Run the generator in --verify-only mode and check content every time,
instead of using hashes.

Bug: angleproject:8193
Change-Id: I3988ab50a6c33171b7b7252c03f34a74f09fcf18
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4604579
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-06-12 22:14:32 +00:00
Roman Lavrov
21f16cb163 Disable clang-format on ANGLE features autogen outputs 
Updates the script to produce reasonably formatted code without
clang-format.

Autogen files moved to autogen/ sub-directories because clang-format
does not support per-file settings ;(

This allows to run this codegen very quickly
(~50ms on my machine)

Bug: angleproject:8193
Change-Id: Ie84282090d574ebb4debe3edcfd82f983f27a5ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4604578
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-06-12 17:52:18 +00:00
Steven Noonan
a01a566c48 extension xmls: fix incorrect use of <ptype> tags 
I was having trouble using some GL/EGL loader generators because of some
errors in the XML definitions for ANGLE.

The first major problem is the content of the <ptype> tags. Let's refer
to the Khronos registry XML schema (which is annoyingly a PDF rather
than an xsd that we can test against, though I don't know if an xsd
would catch this anyway):

    https://raw.githubusercontent.com/KhronosGroup/OpenGL-Registry/master/xml/readme.pdf

In section 12.4.2, "Contents of <param> tags" it states:

    The <ptype> tag is optional, and contains text which is a valid type
    name found in <type> tag, and indicates that this type must be
    previously defined for the definition of the command to succeed.
    Builtin C types, and any derived types which are expected to be
    found in other header files, should not be wrapped in <ptype> tags

Note that the above is repeated for the contents of <proto> tags as
well.

The extension XML files currently have a bunch of <ptype> tags which
don't meet the expectations described above. The correct transformation
for them would be, for example:

    <ptype>GLfloat *</ptype>      ->   <ptype>GLfloat</ptype> *
    <ptype>void *</ptype>         ->   void *
    <ptype>const char *</ptype>   ->   const char *
    <ptype>EGLAttrib *</ptype>    ->   <ptype>EGLAttrib</ptype> *

The next issue is that some tags have some typos, such as "<pytpe>"
instead of "<ptype>". (Now *that* is something an .xsd would catch...)

The last issue is the use of the typename "GLvoid" which is not as
serious a problem. It is still defined in Khronos' gl.xml <types> block,
but Khronos no longer uses it in their XML registries. The comment for
the "GLvoid" type in their <types> block states:

    <type comment="Not an actual GL type, though used in headers in the past">typedef void <name>GLvoid</name>;</type>

So we might as well replace those with just plain "void".

Anyway, long story short: to apply these transformations, I used Perl
regular expressions, and applied these expressions in order:

- Fix the tag misspellings:

    s#<(/?)pytpe>#<\1ptype>#g

- Move the const qualifiers (if present) and pointer asterisk(s) (if
  any) outside the <ptype> tag itself:

    s#<ptype>(const )?([A-Za-z0-9]+)[ ]?(\*\*?)</ptype> #\1<ptype>\2</ptype> \3#g

- Replace "GLvoid", "char", and "void" inside ptype tags to normal
  C types outside tags:

    s#<ptype>(GLvoid|void|char)</ptype>#\1#g

Bug: angleproject:8190
Change-Id: Ib0bea79fecb7e714910b6e92124bb9f52994d0fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4603709
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-06-09 21:15:16 +00:00
Mark Lobodzinski
72df42832e Tests: Add Lotsa Slots trace 
Test: angle_trace_tests --gtest_filter=TraceTest.lotsa_slots
Bug: b/286514838
Change-Id: I8756a21596f2a09abff8262b3a9489b638d3522d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4603714
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
 2023-06-09 18:24:26 +00:00
Steven Noonan
beeb465b6c xml: fix enum EGL_SYNC_METAL_SHARED_EVENT_SIGNALED_ANGLE 
The name in the extension/require block did not match the name in the
enum specification block. This caused some EGL loader generators to fail
to run properly.

Bug: angleproject:8190
Change-Id: I6ce6e226121e7ea9aa611c7d331a8fd1bc83e55b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4603708
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
 2023-06-09 17:56:22 +00:00
Roman Lavrov
3e4f4caebc Tests: reduce load on perf bots by collecting less data 
Collecting this data takes a significant amount of resources but we do
not actively use it at the moment.

Disable --split-shard-samples (will avoid separate calibration on each
shard)
Reduce samples to 6 (from default 10)

Bug: angleproject:7671
Change-Id: I87d45f21badb30ed44de9b9854c94fe7f67ecdc8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4605335
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
 2023-06-09 17:21:46 +00:00
Roman Lavrov
5215293366 Add trace_interface: functions and callbacks for traces 
Defines the interface between the test suite
(or an other TraceLibrary class user) and trace libraries.

TraceFunctions defines entry points for calls suite->trace, such as
SetupReplay() or SetBinaryDataDir().

TraceCallbacks defines entry points for calls trace->suite, for example
for loading .angledata.gz files.

These are set up via the exported SetupEntryPoints() call. Functions
like SetupReplay etc no longer need to be exported from the trace
library.

TraceInfo (parsed representation of the trace json) is moved to
trace_interface as is. This is convenient for further changes to the
fixture that will allow to easily move some of the captured parameters
to json.

This also moves Decompress functionality (and memory ownership) to test
suite entirely, which avoids Decompress/Delete callbacks - the trace
just calls LoadBinaryData via TraceCallbacks and TraceLibrary releases
the memory either on FinishReplay or in its destructor.
This should also take care of the memory leak described in
https://crrev.com/c/3858185

Bug: b/286072760
Change-Id: Ibc6f6f64156ad805b1917c8fc41a3b0d2c0d6375
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4594445
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
 2023-06-08 20:06:15 +00:00
Yuly Novikov
b5d261ac5c Roll chromium_revision be1b60e248..510a3dff2b (1154868:1154869) 
Change fuchsia_sdk_cipd_prefix from fuchsia/sdk/gn to fuchsia/sdk/core
per https://chromium-review.googlesource.com/c/chromium/src/+/4544541

Change log: be1b60e248..510a3dff2b
Full diff: be1b60e248..510a3dff2b

Changed dependencies
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2d01747514
* third_party/fuchsia-sdk/sdk: version:12.20230601.2.1..version:12.20230607.1.1
* third_party/r8: e9kuk0ZE8fKLVJ33ULiDJQ43Sg-S8wbRD0pG7hEcP9AC..4nvRHMrsaaAwaTGCTVhj-rVB4rr7rtMUb01KL83_TA8C
* third_party/zlib: 9c8e4fdccb..6fe0f7956f
* tools/android: a16d54239e..b9d0126966
* tools/clang: 66d5da40df..cc47a7ca0f
* tools/luci-go: git_revision:2eaf659a45c8945c3e15f202c4e8a734243f8270..git_revision:0ecab437ae2532a879b1203efc48f54bc6cadb77
* tools/luci-go: git_revision:2eaf659a45c8945c3e15f202c4e8a734243f8270..git_revision:0ecab437ae2532a879b1203efc48f54bc6cadb77
* tools/mb: 6b669febe1..ccf90ad0a2
* tools/memory: cc6bc21649..57b3b9e7c0
* tools/perf: 7aca1a25c2..8ba510e8e2
DEPS diff: be1b60e248..510a3dff2b/DEPS

No update to Clang.

Bug: None
Change-Id: Ib0dd750864863bdec2229c5b0fc50a36930870f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4598293
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
 2023-06-08 15:00:45 +00:00
angle-autoroll
ae9953cefb Roll vulkan-deps from a6525fe76b4c to c5a1402a455f (35 revisions) 
https://chromium.googlesource.com/vulkan-deps.git/+log/a6525fe76b4c..c5a1402a455f

Changed dependencies:
* spirv-cross: 12542fc6fc..030d0be28c
* spirv-tools: ec244c8598..59b4febd81
* vulkan-headers: 3df77fb3e4..605dc6d3e7
* vulkan-loader: 1f20a308fc..c97930ba36
* vulkan-tools: 9a252664d7..2c83dd6cb2
* vulkan-validation-layers: 2e88dc0a67..ee8fe8140a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,geofflang@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: Ia832a37a1f46eb2a740c1101f0db0b22508813c0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4599934
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2023-06-08 10:37:33 +00:00
angle-autoroll
176989ad00 Roll Chromium from 9e0b5e8b8a85 to fe5f79e217c4 (537 revisions) 
9e0b5e8b8a..fe5f79e217

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,geofflang@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: c884d70f0c..7921c7ccf1
* testing: 098d0a11e4..c1df87f08b
* third_party/android_build_tools/lint: FObSM0x4tmlkstBzjEhG3sHenn993tmoNjl5naaW28AC..3AJFzcPQ9EDTP7XlHY6bgKZvGn7D812ptquuXFcUWzEC
* third_party/android_build_tools/manifest_merger: u2r6t6i4MR-JZBn40RJTHzLBwT4y59mjHv6kkrAlLSQC..nGzWwB6kx8dBDTH7L1jUxm8y3INDX3qVm9co3ntGk7EC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1c6d2fbaf7
* third_party/depot_tools: 0d627781be..e445df0bfb
* third_party/r8: iTbMDX2gRMW4nmoA8J7oToRDDsMcjm6hJNVH-RpYKIoC..e9kuk0ZE8fKLVJ33ULiDJQ43Sg-S8wbRD0pG7hEcP9AC
* tools/android: 81976120c2..a16d54239e
* tools/mb: 38995191a8..6b669febe1
* tools/memory: 1084fb884e..cc6bc21649
* tools/perf: 7813c31dc3..7aca1a25c2
No update to Clang.

Bug: None
Tbr: geofflang@google.com
Change-Id: Ic0801cd566edf88973d7bfef7a83374268dda2ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4593673
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2023-06-07 08:45:20 +00:00
angle-autoroll
31aa3fa5da Roll Chromium from d6f22a2a164b to 9e0b5e8b8a85 (1063 revisions) 
Manually update third_party/flatbuffers from Chromium

d6f22a2a16..9e0b5e8b8a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,geofflang@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: defeac7e7d..c884d70f0c
* buildtools/third_party/libunwind/trunk: cd144ced35..b5a43ecdac
* testing: 21f1443014..098d0a11e4
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..dc627ec37b
* third_party/depot_tools: 9e0ff22bfb..0d627781be
* third_party/flatbuffers/src: a56f9ec50e..13fc75cb6b
* third_party/r8: 0LMjUUpzAmxHrlftkzbDAaeuTDNXrOEgTgyJm8qIyvMC..iTbMDX2gRMW4nmoA8J7oToRDDsMcjm6hJNVH-RpYKIoC
* third_party/turbine: Foa7uRpVoKr4YoayCKc9EERkjpmGOE3DAUTWFLL7gKEC..G8Cku1fztaDd9to_8gk3PNWM2iRacAxD9zcUAgUPUEAC
* third_party/zlib: 982b036a25..9c8e4fdccb
* tools/android: 07b548d993..81976120c2
* tools/clang: 499a012d25..66d5da40df
* tools/mb: 10c4d4779d..38995191a8
* tools/perf: f08244f24a..7813c31dc3
* tools/skia_goldctl/linux: UMqOqE8nlXwo9xj56g4W9ySvvqo2Tsw3B6tWZLo19L8C..7Xu0Ohf2xgwAgLoFgq7LiZmi_Uk3x5gIX5Dta-tZg40C
* tools/skia_goldctl/mac_amd64: vjY1ew6KN-bIFZEk7IbwPCAb6xZxib9uqLXMwbi8JLQC..KYHtCI8pS_1-ZVhMhj0d7h-3H8ZdNtaGLYsYnDqRbnMC
* tools/skia_goldctl/mac_arm64: twOZsJTmRSqlOwstPpWMhT_fXhiOaijMu24-UJLGK20C..h-5CLVE7g4EEE3-uXZ610OaDlIMoYEx3RLgGWHXRA9AC
* tools/skia_goldctl/win: wveYksSfL51dPfdRZ5474IFmCMkL8gg6ygZxxPdBezAC..VWg6iFKkt4rAdHxGoJNLVlgsRlbT-Woz_41P6cFybmYC
No update to Clang.

Bug: angleproject:8178
Tbr: geofflang@google.com
Change-Id: Id46eb10ca81c88f396e42c17b55ead4f77af08c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4593140
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
 2023-06-06 14:52:52 +00:00
Roman Lavrov
e7a9275be2 Make run_code_generation faster using python3 for auto_script 
Only changes the way we get auto_script inputs/outputs.
Before this CL, some of the scripts (depending on the shebang)
are run via vpython3 - which can take a few seconds. But the
inputs/outputs code generally doesn't require any unusual imports, so we
can just add little hacks to suppress those imports where needed when
an argument is given to the script.

Bug: angleproject:8184
Change-Id: Ib09a35b839318253fe7e913e24a756d2cb46dad1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4585820
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-06-05 13:50:57 +00:00
angle-autoroll
e64794b2ab Manual roll VK-GL-CTS from 356e6d2f8796 to 0c2e936905ea (9 revisions) 
Manual roll requested by solti@google.com

356e6d2f87..0c2e936905

2023-06-02 rgarcia@igalia.com Test in-bounds attribute in out-of-bounds
stride
2023-06-02 marcin.zajac@mobica.com vk-build-programs executors limiter
2023-06-02 ziga@lunarg.com Add xfb query copy tests with availablity
2023-06-02 rgarcia@igalia.com Test negative vertex offset indices with
indexed draws
2023-06-02 gleese@broadcom.com Change normalize precision to reduce
needless inaccuracy
2023-06-02 vantablack@google.com Add VkFormat to AHB Format cases to
dEQP
2023-06-02 gleese@broadcom.com Fix reference values for double precision
degrees and radians
2023-06-02 piotr.byszewski@mobica.com Auto-generate
knownConformanceVersions
2023-06-02 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.6
into vk-gl-cts/main

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: solti@google.com
Change-Id: Ia8229869be6fc13fac4e9d58b5780ac74bdd7746
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4582660
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2023-06-02 16:30:59 +00:00
angle-autoroll
5726566af0 Roll vulkan-deps from 354eac3ca8c8 to a6525fe76b4c (50 revisions) 
https://chromium.googlesource.com/vulkan-deps.git/+log/354eac3ca8c8..a6525fe76b4c

Changed dependencies:
* glslang: 9fbc561947..a6662c53ce
* spirv-headers: 69155b22b3..8e2ad27488
* spirv-tools: f29e11dcb6..ec244c8598
* vulkan-headers: 9e61870ecb..3df77fb3e4
* vulkan-loader: b95d065ec5..1f20a308fc
* vulkan-tools: 9aafa3cf1a..9a252664d7
* vulkan-validation-layers: 27c61c8dd6..2e88dc0a67

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: solti@google.com
Change-Id: I1cc7ff765daf355cab281712b6a3fb9cedd8a4ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4577893
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2023-06-01 10:54:03 +00:00
Shahbaz Youssefi
b0e9bbd79f Vulkan: Split features for dynamic state 
When a driver bug with dynamic state is encountered, it is hard to debug
which dynamic state exactly is causing an issue, due to the current
granularity of disabling all entire state from an extension.  With this
change, every dynamic state gets its own ANGLE feature, and can be
toggled as necessary.

Disabling the supportsExtendedDynamicState* features implicitly
disables all dependent features.

Bug: b/285124778
Bug: b/275210062
Bug: fuchsia:107106
Bug: angleproject:5906
Change-Id: Ic291279872df2d0eb58618ff364ab118bdcc4a9f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4577553
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
 2023-06-01 00:37:50 +00:00
Mark Lobodzinski
29ad234a5b Tests: Add Off The Road trace 
Test: angle_trace_tests --gtest_filter=TraceTest.off_the_road
Bug: b/285110104
Change-Id: I63e86ea9a18f9f60680ac758e284cc1b5e90c0ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4576882
Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
 2023-05-31 16:31:47 +00:00
Yuxin Hu
dfb2bab0bb Apply Aliased Decorators To Image DataTypes 
Bug: b/274478912
Bug: b/266235549
Change-Id: I2cd272a1e7481a8803be63efe0be11c61560b23e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4568287
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-05-31 16:25:55 +00:00
Roman Lavrov
8447e2792a code_generation_hashes json files end with newline 
Bug: None
Change-Id: Iddd2c1777a1d5486a4d390c6e3d56ffb09f47f02
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4574569
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Roman Lavrov <romanl@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
 2023-05-30 18:08:28 +00:00
angle-autoroll
89228c43bb Roll Chromium from c0f2c5cab1b4 to 57b220f0ca60 (1475 revisions) 
c0f2c5cab1..57b220f0ca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: 40ec269a47..6cb0fb63f3
* buildtools/linux64: git_revision:e9e83d9095d3234adf68f3e2866f25daf766d5c7..git_revision:e3978de3e8dafb50a2b11efa784e08699a43faf8
* buildtools/mac: git_revision:e9e83d9095d3234adf68f3e2866f25daf766d5c7..git_revision:e3978de3e8dafb50a2b11efa784e08699a43faf8
* buildtools/third_party/libc++abi/trunk: 982e218cb8..5c8dbff7a4
* buildtools/third_party/libunwind/trunk: 55ceecab99..cd144ced35
* buildtools/win: git_revision:e9e83d9095d3234adf68f3e2866f25daf766d5c7..git_revision:e3978de3e8dafb50a2b11efa784e08699a43faf8
* testing: 06f1c1ef67..5102dd5718
* third_party/android_build_tools/aapt2: aidBg3POIv_jPt-kZ7O9aQ6-UdFSuLd8uBgGg4REBjsC..STY0BXlZxsEhudnlXQFed-B5UpwehcoM0sYqor6qRqsC
* third_party/android_build_tools/lint: AS57ntD4VO2MAIu0pkI0b3c3cFkdGt0cAkmSkiRimZkC..pSX8QZklEn1odNNyvBBDnanIA4IBlNNFgsAYPXnk-SYC
* third_party/android_build_tools/manifest_merger: HW7DJwNOXl50MEneaQnyD1Yg1sy_0Eej5E1nKepXq40C..guwWgYx931yQa5Mj6M08VMupp2R1bo_2F6zOS-azX9UC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..44beba1e6d
* third_party/depot_tools: 456d085e75..530d86d40b
* third_party/fuchsia-sdk/sdk: version:12.20230520.1.1..version:12.20230529.1.1
* third_party/r8: dJL8gwEiDUoK5pirX6la4l7ofdBufwcc1HUaCv4CZ8cC..9dmrdF_0VI2W4VoKglVJJXLHpn8Aw00PAHSpkQL63hcC
* third_party/zlib: 14dd4c4455..337322d10f
* tools/clang: 88e8637696..6cf0c7b139
* tools/perf: b7e3f403e3..2ff63e72c7
No update to Clang.

Bug: angleproject:8178
Tbr: solti@google.com
Change-Id: Ic974cb92ecf2a6c87f80a740bd7110effccfb392
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4572632
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2023-05-30 08:02:32 +00:00
Roman Lavrov
16b9a16ae4 Add supports_legacy_dithering feature 
VK_EXT_legacy_dithering =>
VkPhysicalDeviceLegacyDitheringFeaturesEXT.legacyDithering =>
supportsLegacyDithering

Now getting enabled=true on Android master.

Bug: b/284462263
Change-Id: Ibf43184c78d9847044b10413d2050b653e452c9b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4567572
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-05-26 21:08:32 +00:00
angle-autoroll
4dcfd08c07 Roll VK-GL-CTS from f7a3350256a6 to 356e6d2f8796 (9 revisions) 
f7a3350256..356e6d2f87

2023-05-26 piotr.byszewski@mobica.com Merge vk-gl-cts/opengl-cts-4.6.3
into vk-gl-cts/main
2023-05-25 gleese@broadcom.com Fix problems when buffer_storage not
supported
2023-05-25 gleese@broadcom.com Remove deFloatCmp functions
2023-05-25 rgarcia@igalia.com Test clearing images with 64-bit formats
2023-05-25 matt.coster@imgtec.com Add pre-VK_KHR_maintenance1 implied
features to compressed formats
2023-05-25 lionel.g.landwerlin@intel.com Enable descriptor buffer tests
on implementation without compute only queues
2023-05-25 piotr.byszewski@mobica.com Merge vk-gl-cts/vulkan-cts-1.3.6
into vk-gl-cts/main
2023-05-22 piotr.byszewski@mobica.com Split pipeline.txt mustpass into
multiple files
2023-05-20 alexander.galazin@imgtec.com Add option to skip build post
checks

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-team@google.com,romanl@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: romanl@google.com
Change-Id: I09d94c9696c30eb81f374608ac778fb80b2fe4e7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4571063
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
 2023-05-26 16:28:26 +00:00
Mark Lobodzinski
c52826611c Tests: Add Infinity Ops Trace 
Test: angle_trace_tests --gtest_filter=TraceTest.infinity_ops
Bug: b/284273677
Change-Id: I19daa0a0e96a619ff3ec18074012cda213854947
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4566950
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
 2023-05-25 20:26:11 +00:00
Kenneth Russell
aea8856277 Reland "Metal: Optimized BufferSubData per device" 
This reverts commit ee64836f70 ,
relanding the patch stack described there.

Between patchsets 1 and 5:

- The shadow buffer allocation has been replaced with a multimap of
  precisely-sized buffers, rather than rounding up buffer sizes.

- Garbage collection of shadow buffers is triggered in three situations:

  - A certain number of context switches have occurred; this number
    was hand-tuned to avoid GC every frame.

  - A certain number of command buffer submissions has occurred; this
    number was hand-tuned to GC no more often than every few seconds
    on representative workloads.

  - The total size of the allocated shadow buffers is more than 1 MB,
    and either more than twice the size at the last garbage
    collection, or 64 MB more than at the last garbage collection. In
    this case, aggressive GC is performed in order to reclaim shadow
    buffers more quickly.

Performance before and after these changes appears identical on
microbenchmarks. On one Figma test case, comparing GPU memory
allocated inside the BufferManager, peak consumption is decreased by
over 75%, and steady-state consumption decreases by over 88%.

Patchset 6 adds a needed workaround for a bug in the
AMDMTLBronzeDriver affecting uploads of client-side data, and
therefore some dEQP tests. It also streamlines the aggressive GC.

Bug: angleproject:7544
Change-Id: I81b061f0b33c27fa403527fa12d626f4e9c88ebe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4497413
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
 2023-05-25 18:43:45 +00:00
Mike Schuchardt
c18972fdef Tests: Add Gangstar Vegas trace 
Test: angle_trace_tests --gtest_filter=TraceTest.gangstar_vegas

Bug: b/280785771
Change-Id: Ia1d5de22d45979b44b0711fc510d2dfb7600b910
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4507340
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
 2023-05-24 23:27:52 +00:00