godotengine/godot-angle-static
1
0
Fork 0
mirror of https://github.com/godotengine/godot-angle-static.git synced 2026-01-06 02:09:55 +03:00
Code Issues Packages Projects Releases Wiki Activity

Improve documentation about selecting intial CL reviewers.

Browse Source 
BUG=angleproject:2274
BUG=769026

Change-Id: I8128a438a0831ebc4d6693085a41c41182d259c7
Reviewed-on: https://chromium-review.googlesource.com/803854
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
This commit is contained in:
Geoff Lang
2017-12-01 11:30:14 -05:00
parent f5be5bafa6
commit bf0a40bbcd
2 changed files with 24 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
doc/ContributingCode.md
View File

@@ -82,8 +82,7 @@
[ANGLE Gerrit](https://chromium-review.googlesource.com/q/project:angle/angle).
* Follow the generated URL to the new issue.
* Take a moment to perform a self-review of your code. Gerrit's viewer makes it easy to see whitespace errors, erroneous tabs, and other simple style problems.
* Designate reviewers-- if you don't do this, reviewers may not realize you're requesting a review!
* If you don't know who to use, select either `geofflang at chromium dot org` or `jmadill at chromium dot org`.
* [Select reviewers](#selecting-reviewers). If you don't do this, reviewers may not realize you're requesting a review!
* Make changes, upload and repeat as necessary.
* Project members and others will review your code as described in the [CodeReviewProcess](CodeReviewProcess.md).
5. If your change list needs revision:
@@ -95,6 +94,23 @@
7. Pull and integrate reviewed CL:
* `git pull --rebase`
### Selecting reviewers
ANGLE has a loose owners structure but the following mapping can be useful for choosing initial reviewers:
* Compiler/preprocessor `src/compiler`
* `cwallez at chromium dot org`
* OpenGL ES/EGL frontend `src/libANGLE`
* `geofflang at chromium dot org`
* `jmadill at chromium dot org`
* Direct3D backends `src/libANGLE/renderer/d3d`
* `jmadill at chromium dot org`
* OpenGL backend `src/libANGLE/renderer/gl`
* `geofflang at chromium dot org`
* Vulkan backend `src/libANGLE/renderer/vulkan`
* `jmadill at chromium dot org`
* Android integration `src/libANGLE/renderer/*/android`
* `ynovikov at chromium dot org`
* ChromeOS integration `src/libANGLE/renderer/*/ozone`
* `fjhenigman at chromium dot org`
See also: