godotengine/godot-angle-static
1
0
Fork 0
mirror of https://github.com/godotengine/godot-angle-static.git synced 2026-01-03 14:09:33 +03:00
Code Issues Packages Projects Releases Wiki Activity

Improve logging when crashing due to locked screen.

Browse Source 
When screen is locked we see this message in logcat:

    02-07 10:13:42.663  1623  4713 V SplashScreenExceptionList: SplashScreen checking exception for package com.android.angle.test (target sdk:33) -> false

followed by ANGLE crash due to nullptr.

Bug: chromium:1405504
Change-Id: Ib3c00cae160e950f8207c9cc0297c92c8b8afe98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4227987
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Roman Lavrov <romanl@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
This commit is contained in:
Roman Lavrov
2023-02-07 10:18:25 -05:00
committed by Angle LUCI CQ
parent 3886af6e44
commit 1857345f92
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
util/android/AndroidWindow.cpp
View File

@@ -120,6 +120,12 @@ bool AndroidWindow::resize(int width, int height)
}
pthread_mutex_unlock(&sInitWindowMutex);
if (sApp->window == nullptr)
{
// Note: logging isn't initalized yet but this message shows up in logcat.
FATAL() << "Window is NULL (is screen locked? e.g. SplashScreen in logcat)";
}
// TODO: figure out a way to set the format as well,
// which is available only after EGLWindow initialization
int32_t err = ANativeWindow_setBuffersGeometry(sApp->window, mWidth, mHeight, 0);