mirror of
https://github.com/godotengine/buildroot.git
synced 2026-01-04 06:10:16 +03:00
utils/get-developers: implement a -v action for DEVELOPERS file validation
Commit "45aabcddc5 utils/get-developers: really make it callable from elsewhere than the toplevel directory" had a unforeseen side-effect: the fact that check-developers with no arguments used to validate the syntax of the DEVELOPERS no longer works. Indeed, the parse_developers() call was moved *after* the check that verifies if at least one action is passed. Due to this, the check-DEVELOPERS verification in Gitlab CI, which invokes get-developers without argument to validate the DEVELOPERS file... no longer does anything useful. In order to fix this, we introduce an explicit action in get-developers to request the validation of the DEVELOPERS file. The implementation is trivial, as the validation is already done by calling parse_developers(), but at least now we have an action that does "nothing", except execute until the validation is done. This is also much more explicit than "invoke get-developers without arguments to just do validation". The initial investigation of the issue was done by Ricardo Martincoski <ricardo.martincoski@gmail.com> and reported at https://patchwork.ozlabs.org/project/buildroot/patch/20220528014832.289907-1-ricardo.martincoski@gmail.com/, but we have chosen to introduce a separate -v option rather than making the validation part of the existing -c action, which serves a different purpose. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
This commit is contained in:
@@ -45,5 +45,6 @@ the +DEVELOPERS+ file for various tasks:
|
||||
list the ones that are not handled by any developer. The purpose of
|
||||
this option is to help completing the +DEVELOPERS+ file.
|
||||
|
||||
- When using without any arguments, it validates the integrity of the
|
||||
DEVELOPERS file and will note WARNINGS for items that don't match.
|
||||
- When using the +-v+ command line option, it validates the integrity
|
||||
of the DEVELOPERS file and will note WARNINGS for items that don't
|
||||
match.
|
||||
|
||||
Reference in New Issue
Block a user